Sign upLogin

spritejs/sprite-core

View on GitHub
Star

Showing 120 of 120 total issues

Function attr has a Cognitive Complexity of 169 (exceeds 25 allowed). Consider refactoring.
Open

export function attr(options) {
  let cache = false,
    reflow = false,
    relayout = false,
    quiet = false,
Severity: Minor
Found in src/utils/decorators.js - About 3 days to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File basesprite.js has 735 lines of code (exceeds 350 allowed). Consider refactoring.
Open

import {Matrix, Vector} from 'sprite-math';
import {Timeline} from 'sprite-animator';
import {flow, absolute, rectVertices, deprecate, drawRadiusBox, findColor, cacheContextPool} from '../utils';
import BaseAttr from './baseattr';
import BaseNode from './basenode';
Severity: Major
Found in src/core/basesprite.js - About 1 day to fix

    Function dispatchEvent has a Cognitive Complexity of 81 (exceeds 25 allowed). Consider refactoring.
    Open

      dispatchEvent(type, evt, collisionState = false, swallow = false, useCapturePhase = null) { // eslint-disable-line complexity
    const handlers = this.getEventHandlers(type);
    if(swallow && handlers.length === 0) {
      return;
    }
    Severity: Minor
    Found in src/core/layer.js - About 1 day to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    File stylesheet.js has 612 lines of code (exceeds 350 allowed). Consider refactoring.
    Open

    import {isMatched, compile} from '../dom/selector';
import {parseFont, sizeToPixel, relatedAttributes} from '../../utils';

const cssWhat = require('css-what');
    Severity: Major
    Found in src/modules/css/stylesheet.js - About 1 day to fix

      Function parseRuleAttrs has 198 lines of code (exceeds 50 allowed). Consider refactoring.
      Open

      function parseRuleAttrs(rule) { // eslint-disable-line complexity
  let styleAttrs;
  const isStyleMap = !!rule.styleMap;
  if(!isStyleMap) {
    if(!rule.style) return;
      Severity: Major
      Found in src/modules/css/stylesheet.js - About 6 hrs to fix

        Function attr has 181 lines of code (exceeds 50 allowed). Consider refactoring.
        Open

        export function attr(options) {
  let cache = false,
    reflow = false,
    relayout = false,
    quiet = false,
        Severity: Major
        Found in src/utils/decorators.js - About 6 hrs to fix

          Function decorator has 160 lines of code (exceeds 50 allowed). Consider refactoring.
          Open

            const decorator = function (elementDescriptor) {
    if(arguments.length === 3) {
      elementDescriptor = polyfillLegacy.apply(this, arguments);
    }
    const {key, kind} = elementDescriptor;
          Severity: Major
          Found in src/utils/decorators.js - About 5 hrs to fix

            File decorators.js has 459 lines of code (exceeds 350 allowed). Consider refactoring.
            Open

            import {notice} from './utils';
import {attributeNames, relatedAttributes} from './store';

const _attrAbsolute = Symbol('attrAbsolute');
            Severity: Minor
            Found in src/utils/decorators.js - About 4 hrs to fix

              File basenode.js has 447 lines of code (exceeds 350 allowed). Consider refactoring.
              Open

              // import stylesheet from './stylesheet';
import NodeAttr from './attr';
import {inheritAttributes, parseFont} from '../utils';

function createAttribute(attr, key) {
              Severity: Minor
              Found in src/core/basenode.js - About 4 hrs to fix

                Function dispatchEvent has a Cognitive Complexity of 49 (exceeds 25 allowed). Consider refactoring.
                Open

                  dispatchEvent(type, evt, collisionState = false, swallow = false, useCapturePhase = null) {
    const handlers = this.getEventHandlers(type);
    if(swallow && handlers.length === 0) {
      return;
    }
                Severity: Minor
                Found in src/core/group.js - About 4 hrs to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                File node.js has 431 lines of code (exceeds 350 allowed). Consider refactoring.
                Open

                import BaseSprite from '../../core/basesprite';

function doActions(ret, target, act) {
  const actions = target.children.map(c => c[act]()).filter(d => d.promise);
  if(ret.promise) {
                Severity: Minor
                Found in src/modules/actions/node.js - About 3 hrs to fix

                  Function exit has 111 lines of code (exceeds 50 allowed). Consider refactoring.
                  Open

                    exit(toState, onbyone = false) {
    const _exit = () => {
      const states = this.attr('states');
      let ret;
      const afterEnter = states.afterEnter || {};
                  Severity: Major
                  Found in src/modules/actions/node.js - About 3 hrs to fix

                    Function resolveToken has a Cognitive Complexity of 43 (exceeds 25 allowed). Consider refactoring.
                    Open

                    function resolveToken(token) { // eslint-disable-line complexity
  let ret = '',
    priority = 0,
    valid = true;
                    Severity: Minor
                    Found in src/modules/css/stylesheet.js - About 3 hrs to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                      @attr({reflow, value: null})
  set clip(val) {
    if(val) {
      val = typeof val === 'string' ? {d: val} : val;
      this.subject.svg = createSvgPath(val);
                    Severity: Major
                    Found in src/core/group.js and 1 other location - About 3 hrs to fix
                    src/core/path.js on lines 10..20

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 98.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                      @attr({reflow})
  set path(val) {
    if(val) {
      val = typeof val === 'string' ? {d: val} : val;
      this.subject.svg = createSvgPath(val);
                    Severity: Major
                    Found in src/core/path.js and 1 other location - About 3 hrs to fix
                    src/core/group.js on lines 25..35

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 98.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                        if(!texturesSize || texturesSize[0] !== width || texturesSize[1] !== height) {
      const attrSize = subject.attrSize;
      if(attrSize[0] === '' || attrSize[1] === '') {
        subject.reflow();
        subject.clearLayout();
                    Severity: Major
                    Found in src/core/sprite.js and 1 other location - About 2 hrs to fix
                    src/core/label.js on lines 88..94

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 91.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                      if(!boxSize || boxSize[0] !== width || boxSize[1] !== height) {
    const attrSize = node.attrSize;
    if(attrSize[0] === '' || attrSize[1] === '') {
      node.reflow();
      node.clearLayout();
                    Severity: Major
                    Found in src/core/label.js and 1 other location - About 2 hrs to fix
                    src/core/sprite.js on lines 69..75

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 91.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Function _exit has 91 lines of code (exceeds 50 allowed). Consider refactoring.
                    Open

                        const _exit = () => {
      const states = this.attr('states');
      let ret;
      const afterEnter = states.afterEnter || {};
      if(states && (states.beforeExit || states.afterExit)) {
                    Severity: Major
                    Found in src/modules/actions/node.js - About 2 hrs to fix

                      Function resolveToken has 86 lines of code (exceeds 50 allowed). Consider refactoring.
                      Open

                      function resolveToken(token) { // eslint-disable-line complexity
  let ret = '',
    priority = 0,
    valid = true;
                      Severity: Major
                      Found in src/modules/css/stylesheet.js - About 2 hrs to fix

                        Function exit has a Cognitive Complexity of 38 (exceeds 25 allowed). Consider refactoring.
                        Open

                          exit(toState, onbyone = false) {
    const _exit = () => {
      const states = this.attr('states');
      let ret;
      const afterEnter = states.afterEnter || {};
                        Severity: Minor
                        Found in src/modules/actions/node.js - About 2 hrs to fix

                        Cognitive Complexity

                        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                        A method's cognitive complexity is based on a few simple rules:

                        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                        • Code is considered more complex for each "break in the linear flow of the code"
                        • Code is considered more complex when "flow breaking structures are nested"

                        Further reading

                        Severity
                        Category
                        Status
                        Source
                        Language