Sign upLogin

spritejs/sprite-core

View on GitHub
Star
src/modules/css/stylesheet.js

Summary

Maintainability
F
3 days
Test Coverage

File stylesheet.js has 612 lines of code (exceeds 350 allowed). Consider refactoring.
Open

import {isMatched, compile} from '../dom/selector';
import {parseFont, sizeToPixel, relatedAttributes} from '../../utils';

const cssWhat = require('css-what');
Severity: Major
Found in src/modules/css/stylesheet.js - About 1 day to fix

    Function parseRuleAttrs has 198 lines of code (exceeds 50 allowed). Consider refactoring.
    Open

    function parseRuleAttrs(rule) { // eslint-disable-line complexity
  let styleAttrs;
  const isStyleMap = !!rule.styleMap;
  if(!isStyleMap) {
    if(!rule.style) return;
    Severity: Major
    Found in src/modules/css/stylesheet.js - About 6 hrs to fix

      Function resolveToken has a Cognitive Complexity of 43 (exceeds 25 allowed). Consider refactoring.
      Open

      function resolveToken(token) { // eslint-disable-line complexity
  let ret = '',
    priority = 0,
    valid = true;
      Severity: Minor
      Found in src/modules/css/stylesheet.js - About 3 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function resolveToken has 86 lines of code (exceeds 50 allowed). Consider refactoring.
      Open

      function resolveToken(token) { // eslint-disable-line complexity
  let ret = '',
    priority = 0,
    valid = true;
      Severity: Major
      Found in src/modules/css/stylesheet.js - About 2 hrs to fix

        Consider simplifying this complex logical expression.
        Open

          if('fontSize' in attrs
    || 'fontFamily' in attrs
    || 'fontStyle' in attrs
    || 'fontVariant' in attrs
    || 'fontWeight' in attrs) {
        Severity: Critical
        Found in src/modules/css/stylesheet.js - About 2 hrs to fix

          Function computeStyle has 81 lines of code (exceeds 50 allowed). Consider refactoring.
          Open

            computeStyle(el) {
    if(!el.attributes) return {};
    el.__styleNeedUpdate = false;
    if(cssRules.length <= 0) return {};
    const attrs = {};
          Severity: Major
          Found in src/modules/css/stylesheet.js - About 2 hrs to fix

            Function fromDocumentCSS has a Cognitive Complexity of 30 (exceeds 25 allowed). Consider refactoring.
            Open

              fromDocumentCSS(stylesheets, override) /* istanbul ignore next */ {
    if(override) {
      cssRules = cssRules.filter(r => !r.fromDoc);
    }
    if(typeof document === 'undefined') return;
            Severity: Minor
            Found in src/modules/css/stylesheet.js - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Avoid deeply nested control flow statements.
            Open

                  if(name === 'class') {
        ret = `.${value}`;
      } else {
        ret = `[${name}~="${value}"]`;
      }
            Severity: Major
            Found in src/modules/css/stylesheet.js - About 45 mins to fix

              Avoid deeply nested control flow statements.
              Open

                  } else if(action === 'any') {
      ret = `[${name}*="${value}"]`;
    } else if(action === 'hyphen') {
      ret = `[${name}|="${value}"]`;
    }
              Severity: Major
              Found in src/modules/css/stylesheet.js - About 45 mins to fix

                Avoid deeply nested control flow statements.
                Open

                        } else if(key === 'transitionDelay') {
          transition = transition || {};
          transition.delay = value;
        } else if(key === 'transitionDuration') {
          transition = transition || {};
                Severity: Major
                Found in src/modules/css/stylesheet.js - About 45 mins to fix

                  Avoid deeply nested control flow statements.
                  Open

                            if(/Color$/.test(key)) {
            attrs.borderColor = value;
          } else if(/Style$/.test(key)) {
            attrs.borderStyle = value;
          } else if(/Width$/.test(key)) {
                  Severity: Major
                  Found in src/modules/css/stylesheet.js - About 45 mins to fix

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                        } else if(action === 'element') {
      if(name === 'class') {
        ret = `.${value}`;
      } else {
        ret = `[${name}~="${value}"]`;
                    Severity: Major
                    Found in src/modules/css/stylesheet.js and 1 other location - About 1 hr to fix
                    src/modules/css/stylesheet.js on lines 445..468

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 55.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 2 locations. Consider refactoring.
                    Open

                        } else if(action === 'equals') {
      if(name === 'id') {
        ret = `#${value}`;
      } else {
        ret = `[${name}="${value}"]`;
                    Severity: Major
                    Found in src/modules/css/stylesheet.js and 1 other location - About 1 hr to fix
                    src/modules/css/stylesheet.js on lines 458..468

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 55.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    There are no issues that match your filters.

                    Category
                    Status