Sign upLogin

spritejs/sprite-core

View on GitHub
Star
src/utils/decorators.js

Summary

Maintainability
F
6 days
Test Coverage

Function attr has a Cognitive Complexity of 169 (exceeds 25 allowed). Consider refactoring.
Open

export function attr(options) {
  let cache = false,
    reflow = false,
    relayout = false,
    quiet = false,
Severity: Minor
Found in src/utils/decorators.js - About 3 days to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function attr has 181 lines of code (exceeds 50 allowed). Consider refactoring.
Open

export function attr(options) {
  let cache = false,
    reflow = false,
    relayout = false,
    quiet = false,
Severity: Major
Found in src/utils/decorators.js - About 6 hrs to fix

    Function decorator has 160 lines of code (exceeds 50 allowed). Consider refactoring.
    Open

      const decorator = function (elementDescriptor) {
    if(arguments.length === 3) {
      elementDescriptor = polyfillLegacy.apply(this, arguments);
    }
    const {key, kind} = elementDescriptor;
    Severity: Major
    Found in src/utils/decorators.js - About 5 hrs to fix

      File decorators.js has 459 lines of code (exceeds 350 allowed). Consider refactoring.
      Open

      import {notice} from './utils';
import {attributeNames, relatedAttributes} from './store';

const _attrAbsolute = Symbol('attrAbsolute');
      Severity: Minor
      Found in src/utils/decorators.js - About 4 hrs to fix

        Function applyRative has a Cognitive Complexity of 31 (exceeds 25 allowed). Consider refactoring.
        Open

        function applyRative(elementDescriptor, type) {
  const {descriptor} = elementDescriptor;

  const setter = descriptor.set;
        Severity: Minor
        Found in src/utils/decorators.js - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Avoid deeply nested control flow statements.
        Open

                    if(subject[_attrAbsolute]) {
              return pv * ret.v;
            }
        Severity: Major
        Found in src/utils/decorators.js - About 45 mins to fix

          Avoid deeply nested control flow statements.
          Open

                      if(pv !== ret.pv) {
              this[key] = ret.rv;
              return this[key];
            }
          Severity: Major
          Found in src/utils/decorators.js - About 45 mins to fix

            Avoid deeply nested control flow statements.
            Open

                        if(subject[_attrAbsolute]) {
              return pv * ret.v;
            }
            Severity: Major
            Found in src/utils/decorators.js - About 45 mins to fix

              Avoid deeply nested control flow statements.
              Open

                          if(layer) {
              if(relative === 'rw') {
                pv = layer.resolution[0];
              } else if(relative === 'rh') {
                pv = layer.resolution[1];
              Severity: Major
              Found in src/utils/decorators.js - About 45 mins to fix

                Avoid deeply nested control flow statements.
                Open

                            if(value != null) break;
                Severity: Major
                Found in src/utils/decorators.js - About 45 mins to fix

                  Avoid deeply nested control flow statements.
                  Open

                              if(pv !== ret.pv) {
              this[key] = ret.rv;
              return this[key];
            }
                  Severity: Major
                  Found in src/utils/decorators.js - About 45 mins to fix

                    Consider simplifying this complex logical expression.
                    Open

                          if(cache || reflow || relayout || quiet || value || extra) {
        throw new Error('Cannot apply state to composit attribute.');
      }
                    Severity: Major
                    Found in src/utils/decorators.js - About 40 mins to fix

                      Avoid too many return statements within this function.
                      Open

                                  return ret.rv;
                      Severity: Major
                      Found in src/utils/decorators.js - About 30 mins to fix

                        Avoid too many return statements within this function.
                        Open

                                return ret;
                        Severity: Major
                        Found in src/utils/decorators.js - About 30 mins to fix

                          Avoid too many return statements within this function.
                          Open

                                        return pv * ret.v;
                          Severity: Major
                          Found in src/utils/decorators.js - About 30 mins to fix

                            Similar blocks of code found in 2 locations. Consider refactoring.
                            Open

                                if(!target.hasOwnProperty('__inheritDefaults')) { // eslint-disable-line no-prototype-builtins
      target.__inheritDefaults = Object.create(target.__inheritDefaults || null);
    }
                            Severity: Minor
                            Found in src/utils/decorators.js and 1 other location - About 35 mins to fix
                            src/utils/decorators.js on lines 327..329

                            Duplicated Code

                            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                            Tuning

                            This issue has a mass of 46.

                            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                            Refactorings

                            Further Reading

                            Similar blocks of code found in 2 locations. Consider refactoring.
                            Open

                                  if(!proto.hasOwnProperty('__inheritDefaults')) { // eslint-disable-line no-prototype-builtins
        proto.__inheritDefaults = Object.create(proto.__inheritDefaults || null);
      }
                            Severity: Minor
                            Found in src/utils/decorators.js and 1 other location - About 35 mins to fix
                            src/utils/decorators.js on lines 316..318

                            Duplicated Code

                            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                            Tuning

                            This issue has a mass of 46.

                            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                            Refactorings

                            Further Reading

                            There are no issues that match your filters.

                            Category
                            Status