Sign upLogin

squirrelphp/queries

View on GitHub
Star

Showing 38 of 38 total issues

Function getFlattenedFloatFields has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
Open

    public function getFlattenedFloatFields(): array
    {
        $values = $this->getFlattenedFields();

        foreach ($values as $key => $value) {
Severity: Minor
Found in src/Builder/FlattenedFieldsWithTypeTrait.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function buildTableJoins has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
Open

    public function buildTableJoins(array $tables): array
    {
        // List of query values for PDO
        $queryValues = [];
Severity: Minor
Found in src/Doctrine/DBConvertStructuredQueryToSQL.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method insert has 32 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function insert(string $table, array $row = [], string $autoIncrement = ''): ?string
    {
        // No table name specified
        if (\strlen($table) === 0) {
            throw Debug::createException(
Severity: Minor
Found in src/Doctrine/DBAbstractImplementation.php - About 1 hr to fix

    Function internalCall has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
    Open

        protected function internalCall(
        string $name,
        array $arguments,
        array $connectionRetries,
        array $lockRetries,
    Severity: Minor
    Found in src/Doctrine/DBErrorHandler.php - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method insertOrUpdate has 30 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function insertOrUpdate(string $table, array $row = [], array $index = [], ?array $update = null): void
    {
        $this->validateMandatoryUpsertParameters($table, $row, $index);

        $update = $this->prepareUpsertRowUpdates($update, $row, $index);
    Severity: Minor
    Found in src/Doctrine/DBMySQLImplementation.php - About 1 hr to fix

      Method validateMandatoryUpsertParameters has 30 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          protected function validateMandatoryUpsertParameters(
        string $tableName,
        array $row,
        array $indexColumns,
    ): void {
      Severity: Minor
      Found in src/Doctrine/DBAbstractImplementation.php - About 1 hr to fix

        Method getFlattenedFloatFields has 29 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function getFlattenedFloatFields(): array
    {
        $values = $this->getFlattenedFields();

        foreach ($values as $key => $value) {
        Severity: Minor
        Found in src/Builder/FlattenedFieldsWithTypeTrait.php - About 1 hr to fix

          Method buildTableJoins has 29 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public function buildTableJoins(array $tables): array
    {
        // List of query values for PDO
        $queryValues = [];
          Severity: Minor
          Found in src/Doctrine/DBConvertStructuredQueryToSQL.php - About 1 hr to fix

            Function getFlattenedIntegerFields has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
            Open

                public function getFlattenedIntegerFields(): array
    {
        $values = $this->getFlattenedFields();

        foreach ($values as $key => $value) {
            Severity: Minor
            Found in src/Builder/FlattenedFieldsWithTypeTrait.php - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function getFlattenedBooleanFields has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
            Open

                public function getFlattenedBooleanFields(): array
    {
        $values = $this->getFlattenedFields();

        foreach ($values as $key => $value) {
            Severity: Minor
            Found in src/Builder/FlattenedFieldsWithTypeTrait.php - About 55 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function convertStructuredSelectToQuery has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
            Open

                protected function convertStructuredSelectToQuery(array $select): array
    {
        // Make sure all options are correctly defined
        $select = $this->structuredQueryConverter->verifyAndProcessOptions([
            'fields' => [],
            Severity: Minor
            Found in src/Doctrine/DBAbstractImplementation.php - About 45 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                    $query = 'INSERT INTO ' . $this->quoteIdentifier($tableName) .
            ' (' . (\count($columnsForInsert) > 0 ? \implode(',', $columnsForInsert) : '') . ') ' .
            'VALUES (' . (\count($columnsForInsert) > 0 ? \implode(',', $placeholdersForInsert) : '') . ') ' .
            'ON CONFLICT (' . \implode(',', \array_map([$this, 'quoteIdentifier'], $indexColumns)) . ') ';
            Severity: Minor
            Found in src/Doctrine/DBPostgreSQLImplementation.php and 1 other location - About 40 mins to fix
            src/Doctrine/DBMySQLImplementation.php on lines 34..37

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 94.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                    $query = 'INSERT INTO ' . $this->quoteIdentifier($table) .
            ' (' . (\count($columnsForInsert) > 0 ? \implode(',', $columnsForInsert) : '') . ') ' .
            'VALUES (' . (\count($columnsForInsert) > 0 ? \implode(',', $placeholdersForInsert) : '') . ') ' .
            'ON DUPLICATE KEY UPDATE ' . $updatePart;
            Severity: Minor
            Found in src/Doctrine/DBMySQLImplementation.php and 1 other location - About 40 mins to fix
            src/Doctrine/DBPostgreSQLImplementation.php on lines 97..100

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 94.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Consider simplifying this complex logical expression.
            Open

                        if (
                \str_contains($expression, ' ')
                || \str_contains($expression, '=')
                || \str_contains($expression, '<')
                || \str_contains($expression, '>')
            Severity: Major
            Found in src/Doctrine/DBConvertStructuredQueryToSQL.php - About 40 mins to fix

              Function getFlattenedStringFields has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
              Open

                  public function getFlattenedStringFields(): array
    {
        $values = $this->getFlattenedFields();

        foreach ($values as $key => $value) {
              Severity: Minor
              Found in src/Builder/FlattenedFieldsWithTypeTrait.php - About 35 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function addQueryVariablesNoNull has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
              Open

                  private function addQueryVariablesNoNull(array $existingValues, mixed $newValues): array
    {
        // Convert to array of values if not already done
        if (!\is_array($newValues)) {
            $newValues = [$newValues];
              Severity: Minor
              Found in src/Doctrine/DBConvertStructuredQueryToSQL.php - About 25 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function insertOrUpdate has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
              Open

                  public function insertOrUpdate(string $table, array $row = [], array $index = [], ?array $update = null): void
    {
        $this->validateMandatoryUpsertParameters($table, $row, $index);

        $update = $this->prepareUpsertRowUpdates($update, $row, $index);
              Severity: Minor
              Found in src/Doctrine/DBMySQLImplementation.php - About 25 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function validateMandatoryUpsertParameters has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
              Open

                  protected function validateMandatoryUpsertParameters(
        string $tableName,
        array $row,
        array $indexColumns,
    ): void {
              Severity: Minor
              Found in src/Doctrine/DBAbstractImplementation.php - About 25 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Severity
              Category
              Status
              Source
              Language