Sign upLogin

sreichel/magento-StackExchange_LockAttributes

View on GitHub
Star
src/app/code/community/StackExchange/LockAttributes/Model/Observer.php

Summary

Maintainability
A
0 mins
Test Coverage

Function lockProductAttributes has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Invalid

    public function lockProductAttributes(Varien_Event_Observer $observer)
    {
        if ($this->isNotAllowed()) {
            $product = $observer->getProduct();
            if ($product instanceof Mage_Catalog_Model_Product) {
Severity: Minor
Found in src/app/code/community/StackExchange/LockAttributes/Model/Observer.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid excessively long class names like StackExchange_LockAttributes_Model_Observer. Keep class name length under 40.
Open

class StackExchange_LockAttributes_Model_Observer
{
    /**
     * Make product attributes uneditable
     *
Severity: Minor
Found in src/app/code/community/StackExchange/LockAttributes/Model/Observer.php by phpmd

LongClassName

Since: 2.9

Detects when classes or interfaces are declared with excessively long names.

Example

class ATooLongClassNameThatHintsAtADesignProblem {

}

interface ATooLongInterfaceNameThatHintsAtADesignProblem {

}

Source https://phpmd.org/rules/naming.html#longclassname

Each class must be in a namespace of at least one level (a top-level vendor name)
Invalid

class StackExchange_LockAttributes_Model_Observer
Severity: Minor
Found in src/app/code/community/StackExchange/LockAttributes/Model/Observer.php by phpcodesniffer

Class name "StackExchange_LockAttributes_Model_Observer" is not in camel caps format
Invalid

class StackExchange_LockAttributes_Model_Observer
Severity: Minor
Found in src/app/code/community/StackExchange/LockAttributes/Model/Observer.php by phpcodesniffer

There are no issues that match your filters.

Category
Status