Sign upLogin

sshaw/itunes_store_transporter

View on GitHub
Star
lib/itunes/store/transporter/shell.rb

Summary

Maintainability
B
4 hrs
Test Coverage

Method poll has a Cognitive Complexity of 24 (exceeds 5 allowed). Consider refactoring.
Open

        def poll(stdout, stderr)
          read = [ stdout, stderr ]

          loop do
            # TODO: Not working on jruby
Severity: Minor
Found in lib/itunes/store/transporter/shell.rb - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method default_path has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

          def default_path
            case
              when windows?
                # The Transporter installer prefers x86
                # But... I think ruby normalizes this to just PROGRAMFILES
Severity: Minor
Found in lib/itunes/store/transporter/shell.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method exec has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

        def exec(argv, &block)
          raise ArgumentError, "block required" unless block_given?

          begin
            process = ChildProcess.build(path, *argv)
Severity: Minor
Found in lib/itunes/store/transporter/shell.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

There are no issues that match your filters.

Category
Status