Sign upLogin

ssokolow/quicktile

View on GitHub
Star
tests/test_quicktile.py

Summary

Maintainability
A
3 hrs
Test Coverage

Cyclomatic complexity is too high in method test_creates_on_first_run. (6)
Open

    def test_creates_on_first_run(self):
        """Config file is created if it doesn't exist"""
        self.assertFalse(os.path.exists(self.testpath))
        parsed = config.load_config(self.testpath)
        self.assertTrue(os.path.exists(self.testpath))
Severity: Minor
Found in tests/test_quicktile.py by radon

Cyclomatic Complexity

Cyclomatic Complexity corresponds to the number of decisions a block of code contains plus 1. This number (also called McCabe number) is equal to the number of linearly independent paths through the code. This number can be used as a guide when testing conditional logic in blocks.

Radon analyzes the AST tree of a Python program to compute Cyclomatic Complexity. Statements have the following effects on Cyclomatic Complexity:

Construct Effect on CC Reasoning
if +1 An if statement is a single decision.
elif +1 The elif statement adds another decision.
else +0 The else statement does not cause a new decision. The decision is at the if.
for +1 There is a decision at the start of the loop.
while +1 There is a decision at the while statement.
except +1 Each except branch adds a new conditional path of execution.
finally +0 The finally block is unconditionally executed.
with +1 The with statement roughly corresponds to a try/except block (see PEP 343 for details).
assert +1 The assert statement internally roughly equals a conditional statement.
Comprehension +1 A list/set/dict comprehension of generator expression is equivalent to a for loop.
Boolean Operator +1 Every boolean operator (and, or) adds a decision point.

Source: http://radon.readthedocs.org/en/latest/intro.html

Cyclomatic complexity is too high in method test_remapping_invalid_keynames. (6)
Open

    def test_remapping_invalid_keynames(self):
        """Punctuation keybinds get remapped to keysyms"""
        # Assert defaults different than test value
        parsed = config.load_config(self.testpath)
        for name in (',', '.', '+', '-', 'comma', 'period', 'plus', 'minus'):
Severity: Minor
Found in tests/test_quicktile.py by radon

Cyclomatic Complexity

Cyclomatic Complexity corresponds to the number of decisions a block of code contains plus 1. This number (also called McCabe number) is equal to the number of linearly independent paths through the code. This number can be used as a guide when testing conditional logic in blocks.

Radon analyzes the AST tree of a Python program to compute Cyclomatic Complexity. Statements have the following effects on Cyclomatic Complexity:

Construct Effect on CC Reasoning
if +1 An if statement is a single decision.
elif +1 The elif statement adds another decision.
else +0 The else statement does not cause a new decision. The decision is at the if.
for +1 There is a decision at the start of the loop.
while +1 There is a decision at the while statement.
except +1 Each except branch adds a new conditional path of execution.
finally +0 The finally block is unconditionally executed.
with +1 The with statement roughly corresponds to a try/except block (see PEP 343 for details).
assert +1 The assert statement internally roughly equals a conditional statement.
Comprehension +1 A list/set/dict comprehension of generator expression is equivalent to a for loop.
Boolean Operator +1 Every boolean operator (and, or) adds a decision point.

Source: http://radon.readthedocs.org/en/latest/intro.html

Function test_creates_on_first_run has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

    def test_creates_on_first_run(self):
        """Config file is created if it doesn't exist"""
        self.assertFalse(os.path.exists(self.testpath))
        parsed = config.load_config(self.testpath)
        self.assertTrue(os.path.exists(self.testpath))
Severity: Minor
Found in tests/test_quicktile.py - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

TODO found
Open

# TODO: Implement tests for trigger_keyboard_action
Severity: Minor
Found in tests/test_quicktile.py by fixme

TODO found
Open

# TODO: Implement tests for workspace_go
Severity: Minor
Found in tests/test_quicktile.py by fixme

TODO found
Open

    # TODO: Check schema version
Severity: Minor
Found in tests/test_quicktile.py by fixme

TODO found
Open

# TODO: Implement tests for cycle_dimensions
Severity: Minor
Found in tests/test_quicktile.py by fixme

TODO found
Open

# TODO: Implement tests for toggle_state
Severity: Minor
Found in tests/test_quicktile.py by fixme

TODO found
Open

# TODO: Implement tests for toggle_decorated
Severity: Minor
Found in tests/test_quicktile.py by fixme

TODO found
Open

# TODO: Implement tests for QuickTileApp
Severity: Minor
Found in tests/test_quicktile.py by fixme

TODO found
Open

#     # TODO: Implement tests for CommandRegistry
Severity: Minor
Found in tests/test_quicktile.py by fixme

TODO found
Open

# TODO: Implement tests for toggle_desktop
Severity: Minor
Found in tests/test_quicktile.py by fixme

TODO found
Open

# TODO: Implement tests for workspace_send_window
Severity: Minor
Found in tests/test_quicktile.py by fixme

TODO found
Open

# TODO: Implement tests for move_to_position
Severity: Minor
Found in tests/test_quicktile.py by fixme

TODO found
Open

# TODO: I need a functional test to make sure issue #25 doesn't regress
Severity: Minor
Found in tests/test_quicktile.py by fixme

TODO found
Open

# TODO: Implement tests for cycle_monitors
Severity: Minor
Found in tests/test_quicktile.py by fixme

TODO found
Open

# TODO: Implement tests for KeyBinder
Severity: Minor
Found in tests/test_quicktile.py by fixme

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        for name, mapping in (
                ('comma', 'left'),
                ('period', 'right'),
                ('plus', 'top'),
                ('minus', 'bottom')):
Severity: Major
Found in tests/test_quicktile.py and 1 other location - About 1 hr to fix
tests/test_quicktile.py on lines 136..141

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 43.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        for name, mapping in (
                ('comma', 'left'),
                ('period', 'right'),
                ('plus', 'top'),
                ('minus', 'bottom')):
Severity: Major
Found in tests/test_quicktile.py and 1 other location - About 1 hr to fix
tests/test_quicktile.py on lines 127..132

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 43.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status