Sign upLogin

ssplatt/the_dw

View on GitHub
Star

Showing 11 of 11 total issues

Method show has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring.
Open

  def show
    @lineup = Lineup.find(params[:id])
    @nfl = NFLApi.new
    @weekstats = @nfl.get_players_stats({:statType => "weekStats",:season => @lineup.team.league.season, :week => @lineup.week})["players"]
Severity: Minor
Found in app/controllers/lineups_controller.rb - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method players_week_stats has 54 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def players_week_stats(nfl, week, season)
    nfl_qbs = nfl.get_players_stats(
      {
        :position => "QB",
        :week => week,
Severity: Major
Found in app/models/csvout.rb - About 2 hrs to fix

    Method calc_totals has 32 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def calc_totals
    # init for fresh totals
    self.s1_total = 0
    self.s2_total = 0
    self.s3_total = 0
    Severity: Minor
    Found in app/models/team.rb - About 1 hr to fix

      Method calc_score has 28 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          def calc_score(player_week_stats)
      score = 0
      
      player_week_stats["stats"].each do |k,v|
        case k
      Severity: Minor
      Found in app/controllers/lineups_controller.rb - About 1 hr to fix

        Method selected_players has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
        Open

            def selected_players
      @selected_players = []
      lus = current_team.lineups.where.not(id: @lineup.id)
      lus.each do |p|
        if p.qb_id
        Severity: Minor
        Found in app/controllers/lineups_controller.rb - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method create has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
        Open

          def create
    user = User.find_by(email: params[:session][:email].downcase)
    if user && user.authenticate(params[:session][:password])
      if user.activated?
        log_in user
        Severity: Minor
        Found in app/controllers/sessions_controller.rb - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method calc_totals has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
        Open

          def calc_totals
    # init for fresh totals
    self.s1_total = 0
    self.s2_total = 0
    self.s3_total = 0
        Severity: Minor
        Found in app/models/team.rb - About 55 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method current_user has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

          def current_user
    if (user_id = session[:user_id])
      @current_user ||= User.find_by(id: user_id)
    elsif (user_id = cookies.signed[:user_id])
      user = User.find_by(id: user_id)
        Severity: Minor
        Found in app/helpers/sessions_helper.rb - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

          def get_players_stats(options={format: "json"})
    #player stats
    #http://api.fantasy.nfl.com/v1/docs/service?serviceName=playersStats
    #stattype, season, week, position
    # stattype: seasonStats, weekStats, seasonProjectedStats, weekProjectedStats, twoWeekStats, fourWeekStats
        Severity: Minor
        Found in lib/nflapi.rb and 2 other locations - About 15 mins to fix
        lib/nflapi.rb on lines 10..12
        lib/nflapi.rb on lines 39..44

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 26.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

          def get_players_weekstats(options={format: "json"})
    #live stats
    #http://api.fantasy.nfl.com/v1/docs/service?serviceName=playersWeekStats
    #season, week, position
    Rails.cache.fetch(["/players/weekstats", { query: options }], :expires => 1.hour) do
        Severity: Minor
        Found in lib/nflapi.rb and 2 other locations - About 15 mins to fix
        lib/nflapi.rb on lines 10..12
        lib/nflapi.rb on lines 16..25

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 26.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

          def get_stats_headers(options={format: "json"})
    Rails.cache.fetch(["/game/stats", { query: options }], :expires => 1.hour) do
      self.class.get("/game/stats", { query: options })
        Severity: Minor
        Found in lib/nflapi.rb and 2 other locations - About 15 mins to fix
        lib/nflapi.rb on lines 16..25
        lib/nflapi.rb on lines 39..44

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 26.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Severity
        Category
        Status
        Source
        Language