Sign upLogin

ssplatt/the_dw

View on GitHub
Star

Showing 8 of 11 total issues

Method show has a Cognitive Complexity of 22 (exceeds 5 allowed). Consider refactoring.
Open

  def show
    @lineup = Lineup.find(params[:id])
    @nfl = NFLApi.new
    @weekstats = @nfl.get_players_stats({:statType => "weekStats",:season => @lineup.team.league.season, :week => @lineup.week})["players"]
Severity: Minor
Found in app/controllers/lineups_controller.rb - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method players_week_stats has 54 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def players_week_stats(nfl, week, season)
    nfl_qbs = nfl.get_players_stats(
      {
        :position => "QB",
        :week => week,
Severity: Major
Found in app/models/csvout.rb - About 2 hrs to fix

    Method calc_totals has 32 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def calc_totals
    # init for fresh totals
    self.s1_total = 0
    self.s2_total = 0
    self.s3_total = 0
    Severity: Minor
    Found in app/models/team.rb - About 1 hr to fix

      Method calc_score has 28 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          def calc_score(player_week_stats)
      score = 0
      
      player_week_stats["stats"].each do |k,v|
        case k
      Severity: Minor
      Found in app/controllers/lineups_controller.rb - About 1 hr to fix

        Method selected_players has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
        Open

            def selected_players
      @selected_players = []
      lus = current_team.lineups.where.not(id: @lineup.id)
      lus.each do |p|
        if p.qb_id
        Severity: Minor
        Found in app/controllers/lineups_controller.rb - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method create has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
        Open

          def create
    user = User.find_by(email: params[:session][:email].downcase)
    if user && user.authenticate(params[:session][:password])
      if user.activated?
        log_in user
        Severity: Minor
        Found in app/controllers/sessions_controller.rb - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method calc_totals has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
        Open

          def calc_totals
    # init for fresh totals
    self.s1_total = 0
    self.s2_total = 0
    self.s3_total = 0
        Severity: Minor
        Found in app/models/team.rb - About 55 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method current_user has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

          def current_user
    if (user_id = session[:user_id])
      @current_user ||= User.find_by(id: user_id)
    elsif (user_id = cookies.signed[:user_id])
      user = User.find_by(id: user_id)
        Severity: Minor
        Found in app/helpers/sessions_helper.rb - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Severity
        Category
        Status
        Source
        Language