ssube/isolex

Similar blocks of code found in 2 locations. Consider refactoring.

Open

  it('should reply with approval when checks pass', async () => {
    const { container, services } = await createServiceContainer();
    const createReview = reviewResponse();
    const pullGetter = pullGetResponse([]);

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

  it('should reply with errors when checks fail', async () => {
    const { container, services } = await createServiceContainer();
    const createReview = reviewResponse();
    const pullGetter = pullGetResponse([]);

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

  it('should reload config while running', async () => {
    const { bot, ctr } = await createBot(TEST_CONFIG_SERVICE);
    const { svc, spies } = await serviceSpy({});

    const [module] = ctr.getModules();

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

  it('should reset metrics while running', async () => {
    const { bot, ctr } = await createBot(TEST_CONFIG_SERVICE);
    const { svc, spies } = await serviceSpy({});

    const [module] = ctr.getModules();

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

  describe('any operator', async () => {
    it('should match a single string to itself', async () => {
      const match = createMatch({
        operator: RuleOperator.Any,
        values: [{ string: 'bar' }],

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

  describe('every operator', async () => {
    it('should match a single string to itself', async () => {
      const match = createMatch({
        operator: RuleOperator.Every,
        values: [{ string: 'bar' }],

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

  it('should fail when author is not trusted', async () => {
    const { container, services } = await createServiceContainer();
    const listForRef = checkResponse([]);
    const getCombinedStatusForRef = statusResponse([]);

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

  it('should handle projects with zero checks', async () => {
    const { container, services } = await createServiceContainer();
    const listForRef = checkResponse([]);
    const getCombinedStatusForRef = statusResponse([]);

• Read up
  Read up

File TestApproveController.ts has 355 lines of code (exceeds 250 allowed). Consider refactoring.

Open

import { Octokit } from '@octokit/rest';
import { expect } from 'chai';
import { ineeda } from 'ineeda';
import { match, spy, stub } from 'sinon';

File GitlabEndpoint.ts has 279 lines of code (exceeds 250 allowed). Consider refactoring.

Open

import { mustExist } from '@apextoaster/js-utils';
import { Request, Response } from 'express';
import { Inject } from 'noicejs';

import { Endpoint, Handler } from '.';

File Bot.ts has 277 lines of code (exceeds 250 allowed). Consider refactoring.

Open

import { ExternalModule, removeNone, isNone, mustExist, mustFind } from '@apextoaster/js-utils';
import { Container, Inject, LogLevel } from 'noicejs';
import { Registry } from 'prom-client';
import { Subject } from 'rxjs';

File DiscordListener.ts has 257 lines of code (exceeds 250 allowed). Consider refactoring.

Open

import { doesExist, InvalidArgumentError, isNil, mustExist, NotFoundError } from '@apextoaster/js-utils';
import {
  Channel,
  ChannelLogsQueryOptions,
  Client,

Function createEndpoint has 46 lines of code (exceeds 30 allowed). Consider refactoring.

Open

export async function createEndpoint<
  TEndpoint extends BaseEndpoint<EndpointData>,
  TData extends EndpointData
>(
  epType: Constructor<TEndpoint, BaseEndpointOptions<TData>>,

Function setupPassport has 41 lines of code (exceeds 30 allowed). Consider refactoring.

Open

  protected async setupPassport(): Promise<passport.Authenticator> {
    const auth = new passport.Passport();
    auth.use(new JwtStrategy({
      audience: this.data.token.audience,
      issuer: this.data.token.issuer,

Similar blocks of code found in 2 locations. Consider refactoring.

Open

  it('should get past messages', async () => {
    const { container } = await createServiceContainer();
    const sendMessage = spy();
    const graph = await createService(container, GraphSchema, {
      [INJECT_BOT]: ineeda<Bot>({

• Read up
  Read up

Similar blocks of code found in 2 locations. Consider refactoring.

Open

  it('should get past commands', async () => {
    const { container } = await createServiceContainer();
    const sendMessage = spy();
    const graph = await createService(container, GraphSchema, {
      [INJECT_BOT]: ineeda<Bot>({

• Read up
  Read up

Function createTokenSession has 37 lines of code (exceeds 30 allowed). Consider refactoring.

Open

  protected async createTokenSession(data: JwtFields, done: VerifiedCallback) {
    this.logger.debug({ data }, 'creating session from token');
    const token = await this.tokenRepository.findOne({
      id: data.jti,
    }, {

Function checkRef has 36 lines of code (exceeds 30 allowed). Consider refactoring.

Open

  public async checkRef(options: ProjectRef, author: string): Promise<RefResult> {
    const results = await this.collectChecks(options);
    const project = this.data.projects.find((it) => it.owner === options.owner && it.project === options.repo);
    if (isNil(project)) {
      return errorResult({

Function approveRefOrRequest has 33 lines of code (exceeds 30 allowed). Consider refactoring.

Open

  @Handler(NOUN_APPROVE, CommandVerb.Create)
  @CheckRBAC()
  public async approveRefOrRequest(cmd: Command, ctx: Context): Promise<void> {
    const owner = cmd.getHeadOrDefault('owner', ctx.sourceUser.name);
    const repo = cmd.getHead('project');

Similar blocks of code found in 2 locations. Consider refactoring.

Open

  describe('readiness route', async () => {
    it('should succeed when storage is connected', async () => {
      const endpoint = await createEndpoint(HealthEndpoint, true, true);
      const { response, status } = createRequest();
      await endpoint.getReadiness(ineeda<Request>({}), response);

• Read up
  Read up