stadux/stadux

View on GitHub

Showing 4 of 4 total issues

Function createStore has 44 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export const createStore = <T>(defaultState: T): Store<T> => {
  let state = defaultState
  let watchers: Array<(store: T) => void> = []
  const setState = (newState: T) => {
    state = newState
Severity: Minor
Found in src/createStore.ts - About 1 hr to fix

    Function createEffect has 26 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    export const createEffect = <Params = void, Done = void, Fail = Error>(
      effector: Handler<Params, Done>
    ) => {
      let handler: Handler<Params, Done> = effector
      let watcher: Watcher<Params> = noop
    Severity: Minor
    Found in src/createEffect.ts - About 1 hr to fix

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

          watch(cb: (store: T) => void) {
            watchers.push(cb)
            return () => {
              watchers = watchers.filter(v => v !== cb)
            }
      Severity: Minor
      Found in src/createStore.ts and 1 other location - About 35 mins to fix
      src/createEvent.ts on lines 13..18

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 46.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

        instance.watch = cb => {
          watchers.push(cb)
          return () => {
            watchers = watchers.filter(v => v !== cb)
          }
      Severity: Minor
      Found in src/createEvent.ts and 1 other location - About 35 mins to fix
      src/createStore.ts on lines 43..48

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 46.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Severity
      Category
      Status
      Source
      Language