Sign upLogin

stage3systems/node-html5-purifier

View on GitHub
Star

Showing 22 of 22 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

function strip(styles, postfix, cb) {
  var obj = css.parse(styles);
  var sheet = obj.stylesheet;
  var isReverted = false;
  sheet.rules.forEach(function(rule, ruleIndex) {
Severity: Major
Found in lib/style_parser/namespacer/postfixer.js and 1 other location - About 1 day to fix
lib/style_parser/namespacer/prefixer.js on lines 26..41

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 199.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

function strip(styles, prefix, cb) {
  var obj = css.parse(styles);
  var sheet = obj.stylesheet;
  var isReverted = false;
  sheet.rules.forEach(function(rule, ruleIndex) {
Severity: Major
Found in lib/style_parser/namespacer/prefixer.js and 1 other location - About 1 day to fix
lib/style_parser/namespacer/postfixer.js on lines 42..58

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 199.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    function(prefixedStyles, cb1) {
      if (postfix) {
        var reverted = true;
        async.whilst(function() {
          return reverted;
Severity: Major
Found in lib/style_parser/namespacer/index.js and 1 other location - About 4 hrs to fix
lib/style_parser/namespacer/index.js on lines 41..59

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 123.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    function(cb1) {
      if (prefix) {
        var reverted = true;
        async.whilst(function() {
          return reverted;
Severity: Major
Found in lib/style_parser/namespacer/index.js and 1 other location - About 4 hrs to fix
lib/style_parser/namespacer/index.js on lines 61..79

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 123.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function namespace has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
Open

function namespace(htmlInput, prefix, postfix, cb) {
  var outputCache = [];

  var omit = function(node) {
    outputCache.push(node);
Severity: Minor
Found in lib/html_parser/namespacer/index.js - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function stripNamespace has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
Open

function stripNamespace(htmlInput, prefix, postfix, cb) {
  var outputCache = [];
  var replaced = false;

  var omit = function(node) {
Severity: Minor
Found in lib/html_parser/namespacer/index.js - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function stripNamespace has 50 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function stripNamespace(htmlInput, prefix, postfix, cb) {
  var outputCache = [];
  var replaced = false;

  var omit = function(node) {
Severity: Minor
Found in lib/html_parser/namespacer/index.js - About 2 hrs to fix

    Function namespace has 49 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    function namespace(htmlInput, prefix, postfix, cb) {
  var outputCache = [];

  var omit = function(node) {
    outputCache.push(node);
    Severity: Minor
    Found in lib/html_parser/namespacer/index.js - About 1 hr to fix

      Function sanitize has 45 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      function sanitize(htmlInput, cb) {
  var outputCache = [];

  var omit = function(node) {
    outputCache.push(node);
      Severity: Minor
      Found in lib/style_parser/sanitizer/index.js - About 1 hr to fix

        Function stripNamespace has 40 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        function stripNamespace(styles, prefix, postfix, cb) {
  async.waterfall([
    // strip styles
    function(cb1) {
      if (prefix) {
        Severity: Minor
        Found in lib/style_parser/namespacer/index.js - About 1 hr to fix

          Function parsePurified has 33 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          function parsePurified(htmlInput, prefix, postfix, cb) {
  async.waterfall([
    // remove invalid pcdata, ie) <![if mso ...]>
    function(cb) {
      pcdataValidator.filter(htmlInput, cb);
          Severity: Minor
          Found in lib/html_parser/index.js - About 1 hr to fix

            Function startTag has 31 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                startTag: function(tagNameLowerCase, attribs, outputCache) {
      outputCache.push('<' + tagNameLowerCase); // output open tag and the tag's name

      var hasClass = false;
      var blacklisted = blacklister.verify(tagNameLowerCase);
            Severity: Minor
            Found in lib/html_parser/namespacer/index.js - About 1 hr to fix

              Function validate has 30 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

              function validate(htmlInput, cb) {
  var outputCache = [];

  // TODO: move this out to a private function, where base sanitizer can extend from
  var omit = function(node) {
              Severity: Minor
              Found in lib/html_parser/tag_validator/index.js - About 1 hr to fix

                Function startTag has 30 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                    startTag: function(tagNameLowerCase, attribs, outputCache) {
      outputCache.push('<' + tagNameLowerCase); // output open tag and the tag's name

      var blacklisted = blacklister.verify(tagNameLowerCase);
                Severity: Minor
                Found in lib/html_parser/namespacer/index.js - About 1 hr to fix

                  Function validate has 27 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                  function validate(htmlInput, cb) {
  var outputCache = [];

  // TODO: move this out to a private function, where base sanitizer can extend from
  var omit = function(node) {
                  Severity: Minor
                  Found in lib/html_parser/attribute_validator/index.js - About 1 hr to fix

                    Similar blocks of code found in 3 locations. Consider refactoring.
                    Open

                    function verify(tagName) {
  for (var i = 0; i < whitelist.length; i++)
    if (tagName === whitelist[i])
      return true;
                    Severity: Major
                    Found in lib/style_parser/sanitizer/whitelister.js and 2 other locations - About 55 mins to fix
                    lib/html_parser/namespacer/blacklister.js on lines 21..27
                    lib/html_parser/tag_validator/whitelister.js on lines 161..167

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 53.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 3 locations. Consider refactoring.
                    Open

                    function verify(tagName) {
  for (var i = 0; i < blacklist.length; i++)
    if (tagName === blacklist[i])
      return true;
                    Severity: Major
                    Found in lib/html_parser/namespacer/blacklister.js and 2 other locations - About 55 mins to fix
                    lib/html_parser/tag_validator/whitelister.js on lines 161..167
                    lib/style_parser/sanitizer/whitelister.js on lines 20..26

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 53.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Similar blocks of code found in 3 locations. Consider refactoring.
                    Open

                    function verify(tagName) {
  for (var i = 0; i < whitelist.length; i++)
    if (tagName === whitelist[i])
      return true;
                    Severity: Major
                    Found in lib/html_parser/tag_validator/whitelister.js and 2 other locations - About 55 mins to fix
                    lib/html_parser/namespacer/blacklister.js on lines 21..27
                    lib/style_parser/sanitizer/whitelister.js on lines 20..26

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 53.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Identical blocks of code found in 2 locations. Consider refactoring.
                    Open

                        endTag: function(tagName, outputCache) {
      var whitelisted = whitelister.verify(tagName);

      if (whitelisted)
        outputCache.push('</' + tagName + '>');
                    Severity: Minor
                    Found in lib/html_parser/tag_validator/index.js and 1 other location - About 45 mins to fix
                    lib/style_parser/sanitizer/index.js on lines 48..53

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 50.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Identical blocks of code found in 2 locations. Consider refactoring.
                    Open

                        endTag: function(tagName, outputCache) {
      var whitelisted = whitelister.verify(tagName);

      if (whitelisted)
        outputCache.push('</' + tagName + '>');
                    Severity: Minor
                    Found in lib/style_parser/sanitizer/index.js and 1 other location - About 45 mins to fix
                    lib/html_parser/tag_validator/index.js on lines 46..51

                    Duplicated Code

                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                    Tuning

                    This issue has a mass of 50.

                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                    Refactorings

                    Further Reading

                    Severity
                    Category
                    Status
                    Source
                    Language