Sign upLogin

staltz/cycle

View on GitHub
Star
devtool/src/graphSerializer.ts

Summary

Maintainability
B
6 hrs
Test Coverage

File graphSerializer.ts has 348 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/* tslint:disable:max-file-line-count */
import xs, {Stream, Listener} from 'xstream';
import {DevToolEnabledSource} from '@cycle/run';
import debounce from 'xstream/extra/debounce';
import * as dagre from 'dagre';
Severity: Minor
Found in devtool/src/graphSerializer.ts - About 4 hrs to fix

    Function setupZapping has 29 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    function setupZapping(
  [graph, zapSpeed]: [dagre.graphlib.Graph, ZapSpeed],
): Diagram {
  const registry: ZapRegistry = new ZapRegistry();
  const sourceNodes: Array<string> = graph['sources']();
    Severity: Minor
    Found in devtool/src/graphSerializer.ts - About 1 hr to fix

      Function visitEdge has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

        graph: dagre.graphlib.Graph,
  idTable: IdTable,
  inStream: Stream<any>,
  operator: InternalProducer,
  outStream: Stream<any>,
      Severity: Minor
      Found in devtool/src/graphSerializer.ts - About 35 mins to fix

        Function sinksAreXStream has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

        function sinksAreXStream(sinks: Object | null): boolean {
  if (sinks === null) {
    return false;
  }
  for (const key in sinks) {
        Severity: Minor
        Found in devtool/src/graphSerializer.ts - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        There are no issues that match your filters.

        Category
        Status