status-im/status-go

View on GitHub
protocol/communities/persistence.go

Summary

Maintainability
F
5 days
Test Coverage
C
74%

File persistence.go has 1833 lines of code (exceeds 900 allowed). Consider refactoring.
Open

package communities

import (
    "context"
    "crypto/ecdsa"
Severity: Major
Found in protocol/communities/persistence.go - About 3 days to fix

    Persistence has 119 methods (exceeds 21 allowed). Consider refactoring.
    Open

    type Persistence struct {
        db *sql.DB
    
        recordBundleToCommunity func(*CommunityRecordBundle) (*Community, error)
    }
    Severity: Major
    Found in protocol/communities/persistence.go - About 2 days to fix

      Identical blocks of code found in 3 locations. Consider refactoring.
      Open

          err := p.db.QueryRow(`SELECT community_id, address, type, name, symbol, description, supply_str, infinite_supply,
              transferable, remote_self_destruct, chain_id, deploy_state, image_base64, decimals, deployer, privileges_level, tx_hash, version
              FROM community_tokens WHERE community_id = ? AND chain_id = ? AND address = ?`, communityID, chainID, address).Scan(&token.CommunityID, &token.Address, &token.TokenType, &token.Name,
              &token.Symbol, &token.Description, &supplyStr, &token.InfiniteSupply, &token.Transferable,
              &token.RemoteSelfDestruct, &token.ChainID, &token.DeployState, &token.Base64Image, &token.Decimals,
      Severity: Major
      Found in protocol/communities/persistence.go and 2 other locations - About 55 mins to fix
      protocol/communities/persistence.go on lines 1274..1279
      protocol/communities/persistence.go on lines 1300..1303

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 123.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 3 locations. Consider refactoring.
      Open

          err := p.db.QueryRow(`SELECT community_id, address, type, name, symbol, description, supply_str, infinite_supply,
              transferable, remote_self_destruct, chain_id, deploy_state, image_base64, decimals, deployer, privileges_level, tx_hash, version
              FROM community_tokens WHERE chain_id = ? AND address = ?`, chainID, address).Scan(&token.CommunityID, &token.Address, &token.TokenType, &token.Name,
              &token.Symbol, &token.Description, &supplyStr, &token.InfiniteSupply, &token.Transferable,
              &token.RemoteSelfDestruct, &token.ChainID, &token.DeployState, &token.Base64Image, &token.Decimals,
      Severity: Major
      Found in protocol/communities/persistence.go and 2 other locations - About 55 mins to fix
      protocol/communities/persistence.go on lines 1251..1256
      protocol/communities/persistence.go on lines 1300..1303

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 123.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 3 locations. Consider refactoring.
      Open

              err := rows.Scan(&token.CommunityID, &token.Address, &token.TokenType, &token.Name,
                  &token.Symbol, &token.Description, &supplyStr, &token.InfiniteSupply, &token.Transferable,
                  &token.RemoteSelfDestruct, &token.ChainID, &token.DeployState, &token.Base64Image, &token.Decimals,
                  &token.Deployer, &token.PrivilegesLevel, &token.TransactionHash, &token.Version)
      Severity: Major
      Found in protocol/communities/persistence.go and 2 other locations - About 55 mins to fix
      protocol/communities/persistence.go on lines 1251..1256
      protocol/communities/persistence.go on lines 1274..1279

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 123.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status