Sign upLogin

status-im/status-go

View on GitHub
Star
protocol/communities_events_utils_test.go

Summary

Maintainability
F
3 days
Test Coverage

File communities_events_utils_test.go has 1852 lines of code (exceeds 900 allowed). Consider refactoring.
Open

package protocol

import (
    "context"
    "errors"
Severity: Major
Found in protocol/communities_events_utils_test.go - About 3 days to fix

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

        err = tt.RetryWithBackOff(func() error {
        rejectedRequests, err := base.GetControlNode().DeclinedRequestsToJoinForCommunity(community.ID())
        if err != nil {
            return err
        }
    Severity: Major
    Found in protocol/communities_events_utils_test.go and 1 other location - About 1 hr to fix
    protocol/communities_events_utils_test.go on lines 1460..1476

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 140.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

        err = tt.RetryWithBackOff(func() error {
        // request to join is now marked as rejected
        rejectedRequests, err := base.GetControlNode().DeclinedRequestsToJoinForCommunity(community.ID())
        if err != nil {
            return err
    Severity: Major
    Found in protocol/communities_events_utils_test.go and 1 other location - About 1 hr to fix
    protocol/communities_events_utils_test.go on lines 1498..1512

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 140.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 3 locations. Consider refactoring.
    Open

        _, err = WaitOnMessengerResponse(
        base.GetEventSender(),
        func(r *MessengerResponse) bool {
            acceptedRequests, err := base.GetEventSender().AcceptedRequestsToJoinForCommunity(community.ID())
            return err == nil && len(acceptedRequests) == 2 && (acceptedRequests[1].PublicKey == common.PubkeyToHex(&user.identity.PublicKey))
    Severity: Major
    Found in protocol/communities_events_utils_test.go and 2 other locations - About 50 mins to fix
    protocol/communities_events_utils_test.go on lines 1160..1167
    protocol/communities_events_utils_test.go on lines 2400..2407

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 120.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 3 locations. Consider refactoring.
    Open

        _, err = WaitOnMessengerResponse(
        base.GetEventSender(),
        func(r *MessengerResponse) bool {
            acceptedRequests, err := base.GetEventSender().AcceptedRequestsToJoinForCommunity(community.ID())
            return err == nil && len(acceptedRequests) == 2 && (acceptedRequests[1].PublicKey == common.PubkeyToHex(&user.identity.PublicKey))
    Severity: Major
    Found in protocol/communities_events_utils_test.go and 2 other locations - About 50 mins to fix
    protocol/communities_events_utils_test.go on lines 1160..1167
    protocol/communities_events_utils_test.go on lines 2284..2291

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 120.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 3 locations. Consider refactoring.
    Open

        _, err = WaitOnMessengerResponse(
        base.GetEventSender(),
        func(r *MessengerResponse) bool {
            acceptedRequests, err := base.GetEventSender().AcceptedRequestsToJoinForCommunity(community.ID())
            return err == nil && len(acceptedRequests) == 2 && (acceptedRequests[1].PublicKey == common.PubkeyToHex(&user.identity.PublicKey))
    Severity: Major
    Found in protocol/communities_events_utils_test.go and 2 other locations - About 50 mins to fix
    protocol/communities_events_utils_test.go on lines 2284..2291
    protocol/communities_events_utils_test.go on lines 2400..2407

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 120.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status