Sign upLogin

status-im/status-go

View on GitHub
Star
protocol/communities_messenger_test.go

Summary

Maintainability
F
1 wk
Test Coverage

File communities_messenger_test.go has 3457 lines of code (exceeds 900 allowed). Consider refactoring.
Open

package protocol

import (
    "bytes"
    "context"
Severity: Major
Found in protocol/communities_messenger_test.go - About 1 wk to fix

    MessengerCommunitiesSuite has 62 methods (exceeds 21 allowed). Consider refactoring.
    Open

    type MessengerCommunitiesSuite struct {
    suite.Suite
    owner *Messenger
    bob   *Messenger
    alice *Messenger
    Severity: Major
    Found in protocol/communities_messenger_test.go - About 1 day to fix

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

          err = tt.RetryWithBackOff(func() error {
        response, err = bobRetrieveAll()
        if err != nil {
            return err
        }
      Severity: Major
      Found in protocol/communities_messenger_test.go and 1 other location - About 1 hr to fix
      protocol/communities_messenger_test.go on lines 1106..1127

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 166.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

          err = tt.RetryWithBackOff(func() error {
        response, err = bobRetrieveAll()
        if err != nil {
            return err
        }
      Severity: Major
      Found in protocol/communities_messenger_test.go and 1 other location - About 1 hr to fix
      protocol/communities_messenger_test.go on lines 1321..1342

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 166.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 5 locations. Consider refactoring.
      Open

              channelPermissionRequest := requests.CreateCommunityTokenPermission{
            CommunityID: community.ID(),
            Type:        protobuf.CommunityTokenPermission_CAN_VIEW_CHANNEL,
            TokenCriteria: []*protobuf.TokenCriteria{
                &protobuf.TokenCriteria{
      Severity: Major
      Found in protocol/communities_messenger_test.go and 4 other locations - About 50 mins to fix
      protocol/communities_messenger_token_permissions_test.go on lines 1131..1144
      protocol/communities_messenger_token_permissions_test.go on lines 1337..1350
      protocol/communities_messenger_token_permissions_test.go on lines 1428..1441
      protocol/communities_messenger_token_permissions_test.go on lines 1906..1919

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 118.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

          _, err = s.owner.CreateCommunityTokenPermission(&requests.CreateCommunityTokenPermission{
        CommunityID: c.ID(),
        Type:        protobuf.CommunityTokenPermission_BECOME_MEMBER,
        TokenCriteria: []*protobuf.TokenCriteria{{
            ContractAddresses: map[uint64]string{3: "0x933"},
      Severity: Minor
      Found in protocol/communities_messenger_test.go and 1 other location - About 40 mins to fix
      protocol/communities_messenger_test.go on lines 3791..3802

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 111.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

          _, err = s.owner.CreateCommunityTokenPermission(&requests.CreateCommunityTokenPermission{
        CommunityID: c.ID(),
        Type:        protobuf.CommunityTokenPermission_BECOME_MEMBER,
        TokenCriteria: []*protobuf.TokenCriteria{{
            ContractAddresses: map[uint64]string{3: "0x933"},
      Severity: Minor
      Found in protocol/communities_messenger_test.go and 1 other location - About 40 mins to fix
      protocol/communities_messenger_test.go on lines 3688..3699

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 111.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status