Sign upLogin

status-im/status-go

View on GitHub
Star
protocol/persistence.go

Summary

Maintainability
D
2 days
Test Coverage
C
73%

File persistence.go has 1365 lines of code (exceeds 900 allowed). Consider refactoring.
Open

package protocol

import (
    "bytes"
    "context"
Severity: Major
Found in protocol/persistence.go - About 1 day to fix

    sqlitePersistence has 41 methods (exceeds 21 allowed). Consider refactoring.
    Open

    type sqlitePersistence struct {
    *common.RawMessagesPersistence
    db *sql.DB
}
    Severity: Minor
    Found in protocol/persistence.go - About 5 hrs to fix

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

          if iconError == nil && len(icons) > 0 {
        icon := finder.IconInSizeRange(besticon.SizeRange{Min: 48, Perfect: 48, Max: 100})
        if icon != nil {
            bookmark.ImageURL = icon.URL
        } else {
      Severity: Minor
      Found in protocol/persistence.go and 1 other location - About 45 mins to fix
      services/browsers/database.go on lines 77..86

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 116.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 3 locations. Consider refactoring.
      Open

          if tx == nil {
        tx, err = db.db.BeginTx(context.Background(), &sql.TxOptions{})
        if err != nil {
            return err
        }
      Severity: Minor
      Found in protocol/persistence.go and 2 other locations - About 30 mins to fix
      services/browsers/database.go on lines 93..106
      protocol/message_persistence.go on lines 1775..1788

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 101.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status