Showing 31 of 31 total issues
Avoid unused parameters such as '$request'. Open
public function run($request) {- Read upRead up
- Exclude checks
UnusedFormalParameter
Since: 0.2
Avoid passing parameters to methods or constructors and then not using those parameters.
Example
class Foo
{
private function bar($howdy)
{
// $howdy is not used
}
}Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter
The method index uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
} else {
$results = false;
}- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}Source https://phpmd.org/rules/cleancode.html#elseexpression
Avoid unused private fields such as '$db'. Open
private static $db = [
'SearchifyIndexState' => 'Int(0)'
];- Read upRead up
- Exclude checks
UnusedPrivateField
Since: 0.2
Detects when a private field is declared and/or assigned a value, but not used.
Example
class Something
{
private static $FOO = 2; // Unused
private $i = 5; // Unused
private $j = 6;
public function addOne()
{
return $this->j++;
}
}Source https://phpmd.org/rules/unusedcode.html#unusedprivatefield
Avoid unused parameters such as '$records'. Open
public function removePages(ArrayList $records)- Read upRead up
- Exclude checks
UnusedFormalParameter
Since: 0.2
Avoid passing parameters to methods or constructors and then not using those parameters.
Example
class Foo
{
private function bar($howdy)
{
// $howdy is not used
}
}Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter
The variable $snippet_text is not named in camelCase. Open
public function index(SS_HTTPRequest $r)
{
$results = Searchify::inst()->search($r->requestVar('q'));
$resultStack = array();
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}Source
The variable $snippet_text is not named in camelCase. Open
public function index(SS_HTTPRequest $r)
{
$results = Searchify::inst()->search($r->requestVar('q'));
$resultStack = array();
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}Source
The variable $snippet_summary is not named in camelCase. Open
public function index(SS_HTTPRequest $r)
{
$results = Searchify::inst()->search($r->requestVar('q'));
$resultStack = array();
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}Source
The variable $snippet_summary is not named in camelCase. Open
public function index(SS_HTTPRequest $r)
{
$results = Searchify::inst()->search($r->requestVar('q'));
$resultStack = array();
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}Source
The variable $snippet_summary is not named in camelCase. Open
public function index(SS_HTTPRequest $r)
{
$results = Searchify::inst()->search($r->requestVar('q'));
$resultStack = array();
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}Source
The variable $snippet_text is not named in camelCase. Open
public function index(SS_HTTPRequest $r)
{
$results = Searchify::inst()->search($r->requestVar('q'));
$resultStack = array();
- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}Source
The method SearchForm is not named in camelCase. Open
public function SearchForm()
{
return SearchForm::create(
$this,
"SearchForm",- Read upRead up
- Exclude checks
CamelCaseMethodName
Since: 0.2
It is considered best practice to use the camelCase notation to name methods.
Example
class ClassName {
public function get_name() {
}
}