Sign upLogin

steadlane/silverstripe-vision6

View on GitHub
Star
code/controllers/Vision6PageController.php

Summary

Maintainability
A
2 hrs
Test Coverage

Method subscribe has 42 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function subscribe($data, Form $form)
    {
        if (!$this->request->isPOST()) {
            // Bad Request
            return new SS_HTTPResponse(
Severity: Minor
Found in code/controllers/Vision6PageController.php - About 1 hr to fix

    Function normalizeFormData has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

        public function normalizeFormData(array $postVars)
    {
        $output = array();

        foreach ($postVars as $key => $val) {
    Severity: Minor
    Found in code/controllers/Vision6PageController.php - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Missing class import via use statement (line '78', column '24').
    Open

                return new SS_HTTPResponse(
    Severity: Minor
    Found in code/controllers/Vision6PageController.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
    return new \stdClass();
}

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '22', column '20').
    Open

            return new SS_HTTPResponse(
    Severity: Minor
    Found in code/controllers/Vision6PageController.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
    return new \stdClass();
}

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Avoid using static access to class 'Session' in method 'getForm'.
    Open

                if (!Session::get('LastGeneratedV6Form')) {
    Severity: Minor
    Found in code/controllers/Vision6PageController.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class 'Session' in method 'getForm'.
    Open

            Session::set('LastGeneratedV6Form', $listId);
    Severity: Minor
    Found in code/controllers/Vision6PageController.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class 'Director' in method 'Link'.
    Open

            return Controller::join_links(Director::baseURL(), 'vision6', $action);
    Severity: Minor
    Found in code/controllers/Vision6PageController.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class 'Session' in method 'getForm'.
    Open

                $listId = Session::get('LastGeneratedV6Form');
    Severity: Minor
    Found in code/controllers/Vision6PageController.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class 'Controller' in method 'Link'.
    Open

            return Controller::join_links(Director::baseURL(), 'vision6', $action);
    Severity: Minor
    Found in code/controllers/Vision6PageController.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class 'FieldList' in method 'getForm'.
    Open

            $actions = FieldList::create(
            array(
                FormAction::create('subscribe', 'Subscribe')->setUseButtonTag(true)
            )
        );
    Severity: Minor
    Found in code/controllers/Vision6PageController.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class 'Vision6Api' in method 'subscribe'.
    Open

            $api = Vision6Api::create();
    Severity: Minor
    Found in code/controllers/Vision6PageController.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class 'Vision6FieldFactory' in method 'getForm'.
    Open

            $factory = Vision6FieldFactory::create();
    Severity: Minor
    Found in code/controllers/Vision6PageController.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class 'Form' in method 'getForm'.
    Open

            $form = Form::create($this, __FUNCTION__, $fields, $actions, $validator);
    Severity: Minor
    Found in code/controllers/Vision6PageController.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid using static access to class 'Director' in method 'subscribe'.
    Open

                if (Director::isDev()) {
    Severity: Minor
    Found in code/controllers/Vision6PageController.php by phpmd

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    Avoid unused private fields such as '$allowed_actions'.
    Open

        private static $allowed_actions = array(
        'subscribe',
        'getForm'
    );
    Severity: Minor
    Found in code/controllers/Vision6PageController.php by phpmd

    UnusedPrivateField

    Since: 0.2

    Detects when a private field is declared and/or assigned a value, but not used.

    Example

    class Something
{
    private static $FOO = 2; // Unused
    private $i = 5; // Unused
    private $j = 6;
    public function addOne()
    {
        return $this->j++;
    }
}

    Source https://phpmd.org/rules/unusedcode.html#unusedprivatefield

    Avoid unused parameters such as '$data'.
    Open

        public function subscribe($data, Form $form)
    Severity: Minor
    Found in code/controllers/Vision6PageController.php by phpmd

    UnusedFormalParameter

    Since: 0.2

    Avoid passing parameters to methods or constructors and then not using those parameters.

    Example

    class Foo
{
    private function bar($howdy)
    {
        // $howdy is not used
    }
}

    Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter

    The property $allowed_actions is not named in camelCase.
    Open

    class Vision6PageController extends Page_Controller
{
    /** @var array */
    private static $allowed_actions = array(
        'subscribe',
    Severity: Minor
    Found in code/controllers/Vision6PageController.php by phpmd

    CamelCasePropertyName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name attributes.

    Example

    class ClassName {
    protected $property_name;
}

    Source

    The method Link is not named in camelCase.
    Open

        public function Link($action = null)
    {
        return Controller::join_links(Director::baseURL(), 'vision6', $action);
    }
    Severity: Minor
    Found in code/controllers/Vision6PageController.php by phpmd

    CamelCaseMethodName

    Since: 0.2

    It is considered best practice to use the camelCase notation to name methods.

    Example

    class ClassName {
    public function get_name() {
    }
}

    Source

    There are no issues that match your filters.

    Category
    Status