steadlane/silverstripe-vision6

View on GitHub
code/models/Vision6Field.php

Summary

Maintainability
A
0 mins
Test Coverage

Avoid variables with short names like $db. Configured minimum length is 3.
Open

    protected static $db = array(
        "FieldID" => "Int", // The ID of the Field.
        "Name" => "Varchar(100)", // The name of the Field in the List.
        "Type" => "Varchar", // The type of the Field. See below for a list of supported Field types.
        "IsMandatory" => "Int(0)", // A value indicating whether the Field is displayed as mandatory in Web Forms by default.
Severity: Minor
Found in code/models/Vision6Field.php by phpmd

ShortVariable

Since: 0.2

Detects when a field, local, or parameter has a very short name.

Example

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Source https://phpmd.org/rules/naming.html#shortvariable

The property $belongs_many_many is not named in camelCase.
Open

class Vision6Field extends DataObject
{
    protected static $db = array(
        "FieldID" => "Int", // The ID of the Field.
        "Name" => "Varchar(100)", // The name of the Field in the List.
Severity: Minor
Found in code/models/Vision6Field.php by phpmd

CamelCasePropertyName

Since: 0.2

It is considered best practice to use the camelCase notation to name attributes.

Example

class ClassName {
    protected $property_name;
}

Source

There are no issues that match your filters.

Category
Status