FML/Controls/Frame.php
The method getFormat has a boolean flag argument $createIfEmpty, which is a certain sign of a Single Responsibility Principle violation. Open
Open
public function getFormat($createIfEmpty = true)
- Read upRead up
- Exclude checks
BooleanArgumentFlag
Since: 1.4.0
A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.
Example
class Foo {
public function bar($flag = true) {
}
}
Source https://phpmd.org/rules/cleancode.html#booleanargumentflag
The closing brace for the class must go on the next line after the body Open
Open
}
- Exclude checks