Sign upLogin

steeffeen/FancyManiaLinks

View on GitHub
Star
FML/Script/Features/GraphSettings.php

Summary

Maintainability
A
0 mins
Test Coverage
B
83%

Avoid using static access to class '\FML\Script\Builder' in method 'getOnInitScriptText'.
Open

            $maximumCoordinatesValue = Builder::getVec2($this->maximumCoordinates);
Severity: Minor
Found in FML/Script/Features/GraphSettings.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid using static access to class '\FML\Script\Builder' in method 'getOnInitScriptText'.
Open

            $minimumCoordinatesValue = Builder::getVec2($this->minimumCoordinates);
Severity: Minor
Found in FML/Script/Features/GraphSettings.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Avoid excessively long variable names like $maximumCoordinatesValue. Keep variable name length under 20.
Open

            $maximumCoordinatesValue = Builder::getVec2($this->maximumCoordinates);
Severity: Minor
Found in FML/Script/Features/GraphSettings.php by phpmd

LongVariable

Since: 0.2

Detects when a field, formal or local variable is declared with a long name.

Example

class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

Source https://phpmd.org/rules/naming.html#longvariable

Avoid excessively long variable names like $minimumCoordinatesValue. Keep variable name length under 20.
Open

            $minimumCoordinatesValue = Builder::getVec2($this->minimumCoordinates);
Severity: Minor
Found in FML/Script/Features/GraphSettings.php by phpmd

LongVariable

Since: 0.2

Detects when a field, formal or local variable is declared with a long name.

Example

class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

Source https://phpmd.org/rules/naming.html#longvariable

The closing brace for the class must go on the next line after the body
Open

}
Severity: Minor
Found in FML/Script/Features/GraphSettings.php by phpcodesniffer

There are no issues that match your filters.

Category
Status