steeffeen/FancyManiaLinks

View on GitHub
FML/Script/Features/UISound.php

Summary

Maintainability
A
0 mins
Test Coverage
B
80%

Avoid using static access to class '\FML\Script\Builder' in method 'getScriptText'.
Open

            $controlId = Builder::escapeText($this->control->getId());
Severity: Minor
Found in FML/Script/Features/UISound.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

Class constants must be uppercase; expected TIMEOUT but found TimeOut
Open

    const TimeOut          = "TimeOut";

Class constants must be uppercase; expected ENDMATCH but found EndMatch
Open

    const EndMatch         = "EndMatch";

Class constants must be uppercase; expected STARTROUND but found StartRound
Open

    const StartRound       = "StartRound";

Class constants must be uppercase; expected CAPTURE but found Capture
Open

    const Capture          = "Capture";

Class constants must be uppercase; expected PLAYERSREMAINING but found PlayersRemaining
Open

    const PlayersRemaining = "PlayersRemaining";

Class constants must be uppercase; expected CUSTOM3 but found Custom3
Open

    const Custom3          = "Custom3";

Class constants must be uppercase; expected DEFAULT_ but found Default_
Open

    const Default_         = "Default";

Class constants must be uppercase; expected NOTICE but found Notice
Open

    const Notice           = "Notice";

Class constants must be uppercase; expected PLAYERELIMINATED but found PlayerEliminated
Open

    const PlayerEliminated = "PlayerEliminated";

Class constants must be uppercase; expected STARTMATCH but found StartMatch
Open

    const StartMatch       = "StartMatch";

Class constants must be uppercase; expected CUSTOM4 but found Custom4
Open

    const Custom4          = "Custom4";

Class constants must be uppercase; expected SILENCE but found Silence
Open

    const Silence          = "Silence";

Class constants must be uppercase; expected CHECKPOINT but found Checkpoint
Open

    const Checkpoint       = "Checkpoint";

Class constants must be uppercase; expected COMBO but found Combo
Open

    const Combo            = "Combo";

Class constants must be uppercase; expected PLAYERHIT but found PlayerHit
Open

    const PlayerHit        = "PlayerHit";

Class constants must be uppercase; expected SCOREPROGRESS but found ScoreProgress
Open

    const ScoreProgress    = "ScoreProgress";

Class constants must be uppercase; expected TIEPOINT but found TiePoint
Open

    const TiePoint         = "TiePoint";

Class constants must be uppercase; expected VICTORYPOINT but found VictoryPoint
Open

    const VictoryPoint     = "VictoryPoint";

Class constants must be uppercase; expected ENDROUND but found EndRound
Open

    const EndRound         = "EndRound";

Class constants must be uppercase; expected FIRSTHIT but found FirstHit
Open

    const FirstHit         = "FirstHit";

Class constants must be uppercase; expected PHASECHANGE but found PhaseChange
Open

    const PhaseChange      = "PhaseChange";

Class constants must be uppercase; expected FINISH but found Finish
Open

    const Finish           = "Finish";

Class constants must be uppercase; expected RANKCHANGE but found RankChange
Open

    const RankChange       = "RankChange";

Class constants must be uppercase; expected CUSTOM1 but found Custom1
Open

    const Custom1          = "Custom1";

The closing brace for the class must go on the next line after the body
Open

}

Class constants must be uppercase; expected RECORD but found Record
Open

    const Record           = "Record";

Class constants must be uppercase; expected BONUS but found Bonus
Open

    const Bonus            = "Bonus";

Class constants must be uppercase; expected CUSTOM2 but found Custom2
Open

    const Custom2          = "Custom2";

Class constants must be uppercase; expected WARNING but found Warning
Open

    const Warning          = "Warning";

Class constants must be uppercase; expected TIEBREAKPOINT but found TieBreakPoint
Open

    const TieBreakPoint    = "TieBreakPoint";

Constant Bonus should be defined in uppercase
Open

    const Bonus            = "Bonus";
Severity: Minor
Found in FML/Script/Features/UISound.php by phpmd

ConstantNamingConventions

Since: 0.2

Class/Interface constant names should always be defined in uppercase.

Example

class Foo {
    const MY_NUM = 0; // ok
    const myTest = ""; // fail
}

Source https://phpmd.org/rules/naming.html#constantnamingconventions

Constant Checkpoint should be defined in uppercase
Open

    const Checkpoint       = "Checkpoint";
Severity: Minor
Found in FML/Script/Features/UISound.php by phpmd

ConstantNamingConventions

Since: 0.2

Class/Interface constant names should always be defined in uppercase.

Example

class Foo {
    const MY_NUM = 0; // ok
    const myTest = ""; // fail
}

Source https://phpmd.org/rules/naming.html#constantnamingconventions

Constant Notice should be defined in uppercase
Open

    const Notice           = "Notice";
Severity: Minor
Found in FML/Script/Features/UISound.php by phpmd

ConstantNamingConventions

Since: 0.2

Class/Interface constant names should always be defined in uppercase.

Example

class Foo {
    const MY_NUM = 0; // ok
    const myTest = ""; // fail
}

Source https://phpmd.org/rules/naming.html#constantnamingconventions

Constant StartMatch should be defined in uppercase
Open

    const StartMatch       = "StartMatch";
Severity: Minor
Found in FML/Script/Features/UISound.php by phpmd

ConstantNamingConventions

Since: 0.2

Class/Interface constant names should always be defined in uppercase.

Example

class Foo {
    const MY_NUM = 0; // ok
    const myTest = ""; // fail
}

Source https://phpmd.org/rules/naming.html#constantnamingconventions

Constant Custom2 should be defined in uppercase
Open

    const Custom2          = "Custom2";
Severity: Minor
Found in FML/Script/Features/UISound.php by phpmd

ConstantNamingConventions

Since: 0.2

Class/Interface constant names should always be defined in uppercase.

Example

class Foo {
    const MY_NUM = 0; // ok
    const myTest = ""; // fail
}

Source https://phpmd.org/rules/naming.html#constantnamingconventions

Constant EndMatch should be defined in uppercase
Open

    const EndMatch         = "EndMatch";
Severity: Minor
Found in FML/Script/Features/UISound.php by phpmd

ConstantNamingConventions

Since: 0.2

Class/Interface constant names should always be defined in uppercase.

Example

class Foo {
    const MY_NUM = 0; // ok
    const myTest = ""; // fail
}

Source https://phpmd.org/rules/naming.html#constantnamingconventions

Constant PlayersRemaining should be defined in uppercase
Open

    const PlayersRemaining = "PlayersRemaining";
Severity: Minor
Found in FML/Script/Features/UISound.php by phpmd

ConstantNamingConventions

Since: 0.2

Class/Interface constant names should always be defined in uppercase.

Example

class Foo {
    const MY_NUM = 0; // ok
    const myTest = ""; // fail
}

Source https://phpmd.org/rules/naming.html#constantnamingconventions

Constant TiePoint should be defined in uppercase
Open

    const TiePoint         = "TiePoint";
Severity: Minor
Found in FML/Script/Features/UISound.php by phpmd

ConstantNamingConventions

Since: 0.2

Class/Interface constant names should always be defined in uppercase.

Example

class Foo {
    const MY_NUM = 0; // ok
    const myTest = ""; // fail
}

Source https://phpmd.org/rules/naming.html#constantnamingconventions

Constant RankChange should be defined in uppercase
Open

    const RankChange       = "RankChange";
Severity: Minor
Found in FML/Script/Features/UISound.php by phpmd

ConstantNamingConventions

Since: 0.2

Class/Interface constant names should always be defined in uppercase.

Example

class Foo {
    const MY_NUM = 0; // ok
    const myTest = ""; // fail
}

Source https://phpmd.org/rules/naming.html#constantnamingconventions

Constant ScoreProgress should be defined in uppercase
Open

    const ScoreProgress    = "ScoreProgress";
Severity: Minor
Found in FML/Script/Features/UISound.php by phpmd

ConstantNamingConventions

Since: 0.2

Class/Interface constant names should always be defined in uppercase.

Example

class Foo {
    const MY_NUM = 0; // ok
    const myTest = ""; // fail
}

Source https://phpmd.org/rules/naming.html#constantnamingconventions

Constant Combo should be defined in uppercase
Open

    const Combo            = "Combo";
Severity: Minor
Found in FML/Script/Features/UISound.php by phpmd

ConstantNamingConventions

Since: 0.2

Class/Interface constant names should always be defined in uppercase.

Example

class Foo {
    const MY_NUM = 0; // ok
    const myTest = ""; // fail
}

Source https://phpmd.org/rules/naming.html#constantnamingconventions

Constant Custom4 should be defined in uppercase
Open

    const Custom4          = "Custom4";
Severity: Minor
Found in FML/Script/Features/UISound.php by phpmd

ConstantNamingConventions

Since: 0.2

Class/Interface constant names should always be defined in uppercase.

Example

class Foo {
    const MY_NUM = 0; // ok
    const myTest = ""; // fail
}

Source https://phpmd.org/rules/naming.html#constantnamingconventions

Constant PlayerHit should be defined in uppercase
Open

    const PlayerHit        = "PlayerHit";
Severity: Minor
Found in FML/Script/Features/UISound.php by phpmd

ConstantNamingConventions

Since: 0.2

Class/Interface constant names should always be defined in uppercase.

Example

class Foo {
    const MY_NUM = 0; // ok
    const myTest = ""; // fail
}

Source https://phpmd.org/rules/naming.html#constantnamingconventions

Constant Silence should be defined in uppercase
Open

    const Silence          = "Silence";
Severity: Minor
Found in FML/Script/Features/UISound.php by phpmd

ConstantNamingConventions

Since: 0.2

Class/Interface constant names should always be defined in uppercase.

Example

class Foo {
    const MY_NUM = 0; // ok
    const myTest = ""; // fail
}

Source https://phpmd.org/rules/naming.html#constantnamingconventions

Constant Custom3 should be defined in uppercase
Open

    const Custom3          = "Custom3";
Severity: Minor
Found in FML/Script/Features/UISound.php by phpmd

ConstantNamingConventions

Since: 0.2

Class/Interface constant names should always be defined in uppercase.

Example

class Foo {
    const MY_NUM = 0; // ok
    const myTest = ""; // fail
}

Source https://phpmd.org/rules/naming.html#constantnamingconventions

Constant Default_ should be defined in uppercase
Open

    const Default_         = "Default";
Severity: Minor
Found in FML/Script/Features/UISound.php by phpmd

ConstantNamingConventions

Since: 0.2

Class/Interface constant names should always be defined in uppercase.

Example

class Foo {
    const MY_NUM = 0; // ok
    const myTest = ""; // fail
}

Source https://phpmd.org/rules/naming.html#constantnamingconventions

Constant PlayerEliminated should be defined in uppercase
Open

    const PlayerEliminated = "PlayerEliminated";
Severity: Minor
Found in FML/Script/Features/UISound.php by phpmd

ConstantNamingConventions

Since: 0.2

Class/Interface constant names should always be defined in uppercase.

Example

class Foo {
    const MY_NUM = 0; // ok
    const myTest = ""; // fail
}

Source https://phpmd.org/rules/naming.html#constantnamingconventions

Constant StartRound should be defined in uppercase
Open

    const StartRound       = "StartRound";
Severity: Minor
Found in FML/Script/Features/UISound.php by phpmd

ConstantNamingConventions

Since: 0.2

Class/Interface constant names should always be defined in uppercase.

Example

class Foo {
    const MY_NUM = 0; // ok
    const myTest = ""; // fail
}

Source https://phpmd.org/rules/naming.html#constantnamingconventions

Constant FirstHit should be defined in uppercase
Open

    const FirstHit         = "FirstHit";
Severity: Minor
Found in FML/Script/Features/UISound.php by phpmd

ConstantNamingConventions

Since: 0.2

Class/Interface constant names should always be defined in uppercase.

Example

class Foo {
    const MY_NUM = 0; // ok
    const myTest = ""; // fail
}

Source https://phpmd.org/rules/naming.html#constantnamingconventions

Constant Warning should be defined in uppercase
Open

    const Warning          = "Warning";
Severity: Minor
Found in FML/Script/Features/UISound.php by phpmd

ConstantNamingConventions

Since: 0.2

Class/Interface constant names should always be defined in uppercase.

Example

class Foo {
    const MY_NUM = 0; // ok
    const myTest = ""; // fail
}

Source https://phpmd.org/rules/naming.html#constantnamingconventions

Constant Capture should be defined in uppercase
Open

    const Capture          = "Capture";
Severity: Minor
Found in FML/Script/Features/UISound.php by phpmd

ConstantNamingConventions

Since: 0.2

Class/Interface constant names should always be defined in uppercase.

Example

class Foo {
    const MY_NUM = 0; // ok
    const myTest = ""; // fail
}

Source https://phpmd.org/rules/naming.html#constantnamingconventions

Constant PhaseChange should be defined in uppercase
Open

    const PhaseChange      = "PhaseChange";
Severity: Minor
Found in FML/Script/Features/UISound.php by phpmd

ConstantNamingConventions

Since: 0.2

Class/Interface constant names should always be defined in uppercase.

Example

class Foo {
    const MY_NUM = 0; // ok
    const myTest = ""; // fail
}

Source https://phpmd.org/rules/naming.html#constantnamingconventions

Constant TieBreakPoint should be defined in uppercase
Open

    const TieBreakPoint    = "TieBreakPoint";
Severity: Minor
Found in FML/Script/Features/UISound.php by phpmd

ConstantNamingConventions

Since: 0.2

Class/Interface constant names should always be defined in uppercase.

Example

class Foo {
    const MY_NUM = 0; // ok
    const myTest = ""; // fail
}

Source https://phpmd.org/rules/naming.html#constantnamingconventions

Constant Finish should be defined in uppercase
Open

    const Finish           = "Finish";
Severity: Minor
Found in FML/Script/Features/UISound.php by phpmd

ConstantNamingConventions

Since: 0.2

Class/Interface constant names should always be defined in uppercase.

Example

class Foo {
    const MY_NUM = 0; // ok
    const myTest = ""; // fail
}

Source https://phpmd.org/rules/naming.html#constantnamingconventions

Constant TimeOut should be defined in uppercase
Open

    const TimeOut          = "TimeOut";
Severity: Minor
Found in FML/Script/Features/UISound.php by phpmd

ConstantNamingConventions

Since: 0.2

Class/Interface constant names should always be defined in uppercase.

Example

class Foo {
    const MY_NUM = 0; // ok
    const myTest = ""; // fail
}

Source https://phpmd.org/rules/naming.html#constantnamingconventions

Constant Custom1 should be defined in uppercase
Open

    const Custom1          = "Custom1";
Severity: Minor
Found in FML/Script/Features/UISound.php by phpmd

ConstantNamingConventions

Since: 0.2

Class/Interface constant names should always be defined in uppercase.

Example

class Foo {
    const MY_NUM = 0; // ok
    const myTest = ""; // fail
}

Source https://phpmd.org/rules/naming.html#constantnamingconventions

Constant EndRound should be defined in uppercase
Open

    const EndRound         = "EndRound";
Severity: Minor
Found in FML/Script/Features/UISound.php by phpmd

ConstantNamingConventions

Since: 0.2

Class/Interface constant names should always be defined in uppercase.

Example

class Foo {
    const MY_NUM = 0; // ok
    const myTest = ""; // fail
}

Source https://phpmd.org/rules/naming.html#constantnamingconventions

Constant VictoryPoint should be defined in uppercase
Open

    const VictoryPoint     = "VictoryPoint";
Severity: Minor
Found in FML/Script/Features/UISound.php by phpmd

ConstantNamingConventions

Since: 0.2

Class/Interface constant names should always be defined in uppercase.

Example

class Foo {
    const MY_NUM = 0; // ok
    const myTest = ""; // fail
}

Source https://phpmd.org/rules/naming.html#constantnamingconventions

Constant Record should be defined in uppercase
Open

    const Record           = "Record";
Severity: Minor
Found in FML/Script/Features/UISound.php by phpmd

ConstantNamingConventions

Since: 0.2

Class/Interface constant names should always be defined in uppercase.

Example

class Foo {
    const MY_NUM = 0; // ok
    const myTest = ""; // fail
}

Source https://phpmd.org/rules/naming.html#constantnamingconventions

Line exceeds 120 characters; contains 127 characters
Open

    public function __construct($soundName = null, Control $control = null, $variant = 0, $labelName = ScriptLabel::MOUSECLICK)

There are no issues that match your filters.

Category
Status