steeffeen/FancyManiaLinks

View on GitHub
FML/Stylesheet/Style3d.php

Summary

Maintainability
B
5 hrs
Test Coverage
A
100%

Style3d has 26 functions (exceeds 20 allowed). Consider refactoring.
Open

class Style3d
{

    /*
     * Constants
Severity: Minor
Found in FML/Stylesheet/Style3d.php - About 3 hrs to fix

    Method render has 36 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        public function render(\DOMDocument $domDocument)
        {
            $style3dXml = $domDocument->createElement("style3d");
            $this->checkId();
            if ($this->styleId) {
    Severity: Minor
    Found in FML/Stylesheet/Style3d.php - About 1 hr to fix

      Function render has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
      Open

          public function render(\DOMDocument $domDocument)
          {
              $style3dXml = $domDocument->createElement("style3d");
              $this->checkId();
              if ($this->styleId) {
      Severity: Minor
      Found in FML/Stylesheet/Style3d.php - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      The method render() has an NPath complexity of 2048. The configured NPath complexity threshold is 200.
      Open

          public function render(\DOMDocument $domDocument)
          {
              $style3dXml = $domDocument->createElement("style3d");
              $this->checkId();
              if ($this->styleId) {
      Severity: Minor
      Found in FML/Stylesheet/Style3d.php by phpmd

      NPathComplexity

      Since: 0.1

      The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.

      Example

      class Foo {
          function bar() {
              // lots of complicated code
          }
      }

      Source https://phpmd.org/rules/codesize.html#npathcomplexity

      The method render() has a Cyclomatic Complexity of 12. The configured cyclomatic complexity threshold is 10.
      Open

          public function render(\DOMDocument $domDocument)
          {
              $style3dXml = $domDocument->createElement("style3d");
              $this->checkId();
              if ($this->styleId) {
      Severity: Minor
      Found in FML/Stylesheet/Style3d.php by phpmd

      CyclomaticComplexity

      Since: 0.1

      Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

      Example

      // Cyclomatic Complexity = 11
      class Foo {
      1   public function example() {
      2       if ($a == $b) {
      3           if ($a1 == $b1) {
                      fiddle();
      4           } elseif ($a2 == $b2) {
                      fiddle();
                  } else {
                      fiddle();
                  }
      5       } elseif ($c == $d) {
      6           while ($c == $d) {
                      fiddle();
                  }
      7        } elseif ($e == $f) {
      8           for ($n = 0; $n < $h; $n++) {
                      fiddle();
                  }
              } else {
                  switch ($z) {
      9               case 1:
                          fiddle();
                          break;
      10              case 2:
                          fiddle();
                          break;
      11              case 3:
                          fiddle();
                          break;
                      default:
                          fiddle();
                          break;
                  }
              }
          }
      }

      Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

      Class constants must be uppercase; expected MODEL_BOX but found MODEL_Box
      Open

          const MODEL_Box     = "Box";
      Severity: Minor
      Found in FML/Stylesheet/Style3d.php by phpcodesniffer

      Class constants must be uppercase; expected MODEL_WINDOW but found MODEL_Window
      Open

          const MODEL_Window  = "Window";
      Severity: Minor
      Found in FML/Stylesheet/Style3d.php by phpcodesniffer

      The closing brace for the class must go on the next line after the body
      Open

      }
      Severity: Minor
      Found in FML/Stylesheet/Style3d.php by phpcodesniffer

      Class constants must be uppercase; expected MODEL_BUTTON but found MODEL_Button
      Open

          const MODEL_Button  = "Button";
      Severity: Minor
      Found in FML/Stylesheet/Style3d.php by phpcodesniffer

      Class constants must be uppercase; expected MODEL_TITLE but found MODEL_Title
      Open

          const MODEL_Title   = "Title";
      Severity: Minor
      Found in FML/Stylesheet/Style3d.php by phpcodesniffer

      Class constants must be uppercase; expected MODEL_BUTTONH but found MODEL_ButtonH
      Open

          const MODEL_ButtonH = "ButtonH";
      Severity: Minor
      Found in FML/Stylesheet/Style3d.php by phpcodesniffer

      Constant MODEL_Title should be defined in uppercase
      Open

          const MODEL_Title   = "Title";
      Severity: Minor
      Found in FML/Stylesheet/Style3d.php by phpmd

      ConstantNamingConventions

      Since: 0.2

      Class/Interface constant names should always be defined in uppercase.

      Example

      class Foo {
          const MY_NUM = 0; // ok
          const myTest = ""; // fail
      }

      Source https://phpmd.org/rules/naming.html#constantnamingconventions

      Constant MODEL_ButtonH should be defined in uppercase
      Open

          const MODEL_ButtonH = "ButtonH";
      Severity: Minor
      Found in FML/Stylesheet/Style3d.php by phpmd

      ConstantNamingConventions

      Since: 0.2

      Class/Interface constant names should always be defined in uppercase.

      Example

      class Foo {
          const MY_NUM = 0; // ok
          const myTest = ""; // fail
      }

      Source https://phpmd.org/rules/naming.html#constantnamingconventions

      Constant MODEL_Window should be defined in uppercase
      Open

          const MODEL_Window  = "Window";
      Severity: Minor
      Found in FML/Stylesheet/Style3d.php by phpmd

      ConstantNamingConventions

      Since: 0.2

      Class/Interface constant names should always be defined in uppercase.

      Example

      class Foo {
          const MY_NUM = 0; // ok
          const myTest = ""; // fail
      }

      Source https://phpmd.org/rules/naming.html#constantnamingconventions

      Constant MODEL_Button should be defined in uppercase
      Open

          const MODEL_Button  = "Button";
      Severity: Minor
      Found in FML/Stylesheet/Style3d.php by phpmd

      ConstantNamingConventions

      Since: 0.2

      Class/Interface constant names should always be defined in uppercase.

      Example

      class Foo {
          const MY_NUM = 0; // ok
          const myTest = ""; // fail
      }

      Source https://phpmd.org/rules/naming.html#constantnamingconventions

      Constant MODEL_Box should be defined in uppercase
      Open

          const MODEL_Box     = "Box";
      Severity: Minor
      Found in FML/Stylesheet/Style3d.php by phpmd

      ConstantNamingConventions

      Since: 0.2

      Class/Interface constant names should always be defined in uppercase.

      Example

      class Foo {
          const MY_NUM = 0; // ok
          const myTest = ""; // fail
      }

      Source https://phpmd.org/rules/naming.html#constantnamingconventions

      There are no issues that match your filters.

      Category
      Status