steeffeen/FancyManiaLinks

TMUIProperties has 51 functions (exceeds 20 allowed). Consider refactoring.

Open

class TMUIProperties extends UIProperties
{

    /**
     * @var array $liveInfoProperties Live info properties

The class TMUIProperties has an overall complexity of 51 which is very high. The configured complexity threshold is 50.

Open

class TMUIProperties extends UIProperties
{

    /**
     * @var array $liveInfoProperties Live info properties

• Exclude checks
  • Disable engine
  • Disable check

File TMUIProperties.php has 261 lines of code (exceeds 250 allowed). Consider refactoring.

Open

<?php

namespace FML\XmlRpc;

/**

The class TMUIProperties has 50 public methods and attributes. Consider reducing the number of public items to less than 45.

Open

class TMUIProperties extends UIProperties
{

    /**
     * @var array $liveInfoProperties Live info properties

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

public class Foo {
    public $value;
    public $something;
    public $var;
    // [... more more public attributes ...]

    public function doWork() {}
    public function doMoreWork() {}
    public function doWorkAgain() {}
    // [... more more public methods ...]
}

Avoid excessively long variable names like $spectatorInfoProperties. Keep variable name length under 20.

Open

    protected $spectatorInfoProperties = array();

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

Avoid excessively long variable names like $roundScoresProperties. Keep variable name length under 20.

Open

    protected $roundScoresProperties = array();

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

Avoid excessively long variable names like $checkpointListProperties. Keep variable name length under 20.

Open

    protected $checkpointListProperties = array();

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

Avoid excessively long variable names like $multiLapInfoProperties. Keep variable name length under 20.

Open

    protected $multiLapInfoProperties = array();

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

Avoid excessively long variable names like $speedAndDistanceProperties. Keep variable name length under 20.

Open

    protected $speedAndDistanceProperties = array();

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

Avoid excessively long variable names like $personalBestAndRankProperties. Keep variable name length under 20.

Open

    protected $personalBestAndRankProperties = array();

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

Avoid excessively long variable names like $checkpointRankingProperties. Keep variable name length under 20.

Open

    protected $checkpointRankingProperties = array();

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

Avoid excessively long variable names like $opponentsInfoProperties. Keep variable name length under 20.

Open

    protected $opponentsInfoProperties = array();

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

Avoid excessively long variable names like $checkpointTimeProperties. Keep variable name length under 20.

Open

    protected $checkpointTimeProperties = array();

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

The closing brace for the class must go on the next line after the body

Open

}

• Exclude checks
  • Disable engine
  • Disable check

The 'getRoundScoresVisible()' method which returns a boolean should be named 'is...()' or 'has...()'

Open

    public function getRoundScoresVisible()
    {
        return $this->getVisibleProperty($this->roundScoresProperties);
    }

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo {
    /**
     * @return boolean
     */
    public function getFoo() {} // bad
    /**
     * @return bool
     */
    public function isFoo(); // ok
    /**
     * @return boolean
     */
    public function getFoo($bar); // ok, unless checkParameterizedMethods=true
}

The 'getLiveInfoVisible()' method which returns a boolean should be named 'is...()' or 'has...()'

Open

    public function getLiveInfoVisible()
    {
        return $this->getVisibleProperty($this->liveInfoProperties);
    }

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo {
    /**
     * @return boolean
     */
    public function getFoo() {} // bad
    /**
     * @return bool
     */
    public function isFoo(); // ok
    /**
     * @return boolean
     */
    public function getFoo($bar); // ok, unless checkParameterizedMethods=true
}

The 'getSpectatorInfoVisible()' method which returns a boolean should be named 'is...()' or 'has...()'

Open

    public function getSpectatorInfoVisible()
    {
        return $this->getVisibleProperty($this->spectatorInfoProperties);
    }

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo {
    /**
     * @return boolean
     */
    public function getFoo() {} // bad
    /**
     * @return bool
     */
    public function isFoo(); // ok
    /**
     * @return boolean
     */
    public function getFoo($bar); // ok, unless checkParameterizedMethods=true
}

The 'getSpeedAndDistanceVisible()' method which returns a boolean should be named 'is...()' or 'has...()'

Open

    public function getSpeedAndDistanceVisible()
    {
        return $this->getVisibleProperty($this->speedAndDistanceProperties);
    }

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo {
    /**
     * @return boolean
     */
    public function getFoo() {} // bad
    /**
     * @return bool
     */
    public function isFoo(); // ok
    /**
     * @return boolean
     */
    public function getFoo($bar); // ok, unless checkParameterizedMethods=true
}

The 'getCheckpointListVisible()' method which returns a boolean should be named 'is...()' or 'has...()'

Open

    public function getCheckpointListVisible()
    {
        return $this->getVisibleProperty($this->checkpointListProperties);
    }

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo {
    /**
     * @return boolean
     */
    public function getFoo() {} // bad
    /**
     * @return bool
     */
    public function isFoo(); // ok
    /**
     * @return boolean
     */
    public function getFoo($bar); // ok, unless checkParameterizedMethods=true
}

The 'getPersonalBestAndRankVisible()' method which returns a boolean should be named 'is...()' or 'has...()'

Open

    public function getPersonalBestAndRankVisible()
    {
        return $this->getVisibleProperty($this->personalBestAndRankProperties);
    }

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo {
    /**
     * @return boolean
     */
    public function getFoo() {} // bad
    /**
     * @return bool
     */
    public function isFoo(); // ok
    /**
     * @return boolean
     */
    public function getFoo($bar); // ok, unless checkParameterizedMethods=true
}

The 'getWarmUpVisible()' method which returns a boolean should be named 'is...()' or 'has...()'

Open

    public function getWarmUpVisible()
    {
        return $this->getVisibleProperty($this->warmUpProperties);
    }

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo {
    /**
     * @return boolean
     */
    public function getFoo() {} // bad
    /**
     * @return bool
     */
    public function isFoo(); // ok
    /**
     * @return boolean
     */
    public function getFoo($bar); // ok, unless checkParameterizedMethods=true
}

The 'getCheckpointTimeVisible()' method which returns a boolean should be named 'is...()' or 'has...()'

Open

    public function getCheckpointTimeVisible()
    {
        return $this->getVisibleProperty($this->checkpointTimeProperties);
    }

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo {
    /**
     * @return boolean
     */
    public function getFoo() {} // bad
    /**
     * @return bool
     */
    public function isFoo(); // ok
    /**
     * @return boolean
     */
    public function getFoo($bar); // ok, unless checkParameterizedMethods=true
}

The 'getMultiLapInfoVisible()' method which returns a boolean should be named 'is...()' or 'has...()'

Open

    public function getMultiLapInfoVisible()
    {
        return $this->getVisibleProperty($this->multiLapInfoProperties);
    }

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo {
    /**
     * @return boolean
     */
    public function getFoo() {} // bad
    /**
     * @return bool
     */
    public function isFoo(); // ok
    /**
     * @return boolean
     */
    public function getFoo($bar); // ok, unless checkParameterizedMethods=true
}

The 'getOpponentsInfoVisible()' method which returns a boolean should be named 'is...()' or 'has...()'

Open

    public function getOpponentsInfoVisible()
    {
        return $this->getVisibleProperty($this->opponentsInfoProperties);
    }

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo {
    /**
     * @return boolean
     */
    public function getFoo() {} // bad
    /**
     * @return bool
     */
    public function isFoo(); // ok
    /**
     * @return boolean
     */
    public function getFoo($bar); // ok, unless checkParameterizedMethods=true
}

The 'getPositionVisible()' method which returns a boolean should be named 'is...()' or 'has...()'

Open

    public function getPositionVisible()
    {
        return $this->getVisibleProperty($this->positionProperties);
    }

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo {
    /**
     * @return boolean
     */
    public function getFoo() {} // bad
    /**
     * @return bool
     */
    public function isFoo(); // ok
    /**
     * @return boolean
     */
    public function getFoo($bar); // ok, unless checkParameterizedMethods=true
}

The 'getChronoVisible()' method which returns a boolean should be named 'is...()' or 'has...()'

Open

    public function getChronoVisible()
    {
        return $this->getVisibleProperty($this->chronoProperties);
    }

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo {
    /**
     * @return boolean
     */
    public function getFoo() {} // bad
    /**
     * @return bool
     */
    public function isFoo(); // ok
    /**
     * @return boolean
     */
    public function getFoo($bar); // ok, unless checkParameterizedMethods=true
}

The 'getCheckpointRankingVisible()' method which returns a boolean should be named 'is...()' or 'has...()'

Open

    public function getCheckpointRankingVisible()
    {
        return $this->getVisibleProperty($this->checkpointRankingProperties);
    }

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo {
    /**
     * @return boolean
     */
    public function getFoo() {} // bad
    /**
     * @return bool
     */
    public function isFoo(); // ok
    /**
     * @return boolean
     */
    public function getFoo($bar); // ok, unless checkParameterizedMethods=true
}