Sign upLogin

steeffeen/FancyManiaLinks

View on GitHub
Star

Showing 2,233 of 2,233 total issues

The class Quad_UIConstructionBullet_Buttons is not named in CamelCase.
Open

class Quad_UIConstructionBullet_Buttons extends Quad
{

    /*
     * Constants
Severity: Minor
Found in FML/Controls/Quads/Quad_UIConstructionBullet_Buttons.php by phpmd

CamelCaseClassName

Since: 0.2

It is considered best practice to use the CamelCase notation to name classes.

Example

class class_name {
}

Source

Avoid variables with short names like $ip. Configured minimum length is 3.
Open

    public function setIp($ip, $port = null)
Severity: Minor
Found in FML/ManiaCode/AddFavorite.php by phpmd

ShortVariable

Since: 0.2

Detects when a field, local, or parameter has a very short name.

Example

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Source https://phpmd.org/rules/naming.html#shortvariable

Avoid variables with short names like $ip. Configured minimum length is 3.
Open

    public function setIp($ip, $port = null)
Severity: Minor
Found in FML/ManiaCode/JoinServer.php by phpmd

ShortVariable

Since: 0.2

Detects when a field, local, or parameter has a very short name.

Example

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Source https://phpmd.org/rules/naming.html#shortvariable

The class Quad_ManiaPlanetLogos is not named in CamelCase.
Open

class Quad_ManiaPlanetLogos extends Quad
{

    /*
     * Constants
Severity: Minor
Found in FML/Controls/Quads/Quad_ManiaPlanetLogos.php by phpmd

CamelCaseClassName

Since: 0.2

It is considered best practice to use the CamelCase notation to name classes.

Example

class class_name {
}

Source

The class Quad_ManiaPlanetMainMenu is not named in CamelCase.
Open

class Quad_ManiaPlanetMainMenu extends Quad
{

    /*
     * Constants
Severity: Minor
Found in FML/Controls/Quads/Quad_ManiaPlanetMainMenu.php by phpmd

CamelCaseClassName

Since: 0.2

It is considered best practice to use the CamelCase notation to name classes.

Example

class class_name {
}

Source

The class Quad_UIConstruction_Buttons2 is not named in CamelCase.
Open

class Quad_UIConstruction_Buttons2 extends Quad
{

    /*
     * Constants
Severity: Minor
Found in FML/Controls/Quads/Quad_UIConstruction_Buttons2.php by phpmd

CamelCaseClassName

Since: 0.2

It is considered best practice to use the CamelCase notation to name classes.

Example

class class_name {
}

Source

Avoid variables with short names like $ip. Configured minimum length is 3.
Open

    protected $ip = null;
Severity: Minor
Found in FML/ManiaCode/AddFavorite.php by phpmd

ShortVariable

Since: 0.2

Detects when a field, local, or parameter has a very short name.

Example

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Source https://phpmd.org/rules/naming.html#shortvariable

The class Quad_UIConstruction_Buttons is not named in CamelCase.
Open

class Quad_UIConstruction_Buttons extends Quad
{

    /*
     * Constants
Severity: Minor
Found in FML/Controls/Quads/Quad_UIConstruction_Buttons.php by phpmd

CamelCaseClassName

Since: 0.2

It is considered best practice to use the CamelCase notation to name classes.

Example

class class_name {
}

Source

Avoid variables with short names like $ip. Configured minimum length is 3.
Open

    protected $ip = null;
Severity: Minor
Found in FML/ManiaCode/JoinServer.php by phpmd

ShortVariable

Since: 0.2

Detects when a field, local, or parameter has a very short name.

Example

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}

Source https://phpmd.org/rules/naming.html#shortvariable

Function render has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

    public function render(\DOMDocument $domDocument)
    {
        $domElement = parent::render($domDocument);
        if ($this->style3d) {
            $this->style3d->checkId();
Severity: Minor
Found in FML/Controls/Frame3d.php - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function render has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

    public function render(\DOMDocument $domDocument)
    {
        $domElement = parent::render($domDocument);
        if ($this->ratio) {
            $domElement->setAttribute("ratio", $this->ratio);
Severity: Minor
Found in FML/Controls/Gauge.php - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function render has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

    public function render(\DOMDocument $domDocument)
    {
        $domElement = $domDocument->createElement("format");
        if ($this->backgroundColor) {
            $domElement->setAttribute("bgcolor", $this->backgroundColor);
Severity: Minor
Found in FML/Elements/Format.php - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function getScriptText has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

    protected function getScriptText()
    {
        $actionName = Builder::escapeText($this->actionName);
        $key        = null;
        $value      = null;
Severity: Minor
Found in FML/Script/Features/KeyAction.php - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

The class ManiaCode has a coupling between objects value of 18. Consider to reduce the number of dependencies under 13.
Open

class ManiaCode
{

    /**
     * @var bool $disableConfirmation Disable the confirmation
Severity: Minor
Found in FML/ManiaCode.php by phpmd

CouplingBetweenObjects

Since: 1.1.0

A class with too many dependencies has negative impacts on several quality aspects of a class. This includes quality criteria like stability, maintainability and understandability

Example

class Foo {
    /**
     * @var \foo\bar\X
     */
    private $x = null;

    /**
     * @var \foo\bar\Y
     */
    private $y = null;

    /**
     * @var \foo\bar\Z
     */
    private $z = null;

    public function setFoo(\Foo $foo) {}
    public function setBar(\Bar $bar) {}
    public function setBaz(\Baz $baz) {}

    /**
     * @return \SplObjectStorage
     * @throws \OutOfRangeException
     * @throws \InvalidArgumentException
     * @throws \ErrorException
     */
    public function process(\Iterator $it) {}

    // ...
}

Source https://phpmd.org/rules/design.html#couplingbetweenobjects

Method __construct has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

        Control $togglingControl = null,
        Control $toggledControl = null,
        $labelName = ScriptLabel::MOUSECLICK,
        $onlyShow = false,
        $onlyHide = false
Severity: Minor
Found in FML/Script/Features/Toggle.php - About 35 mins to fix

    Method __construct has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        public function __construct(Control $hoverControl = null, Control $tooltipControl = null, $stayOnClick = null, $invert = null, $text = null)
    Severity: Minor
    Found in FML/Script/Features/Tooltip.php - About 35 mins to fix

      Function getKeyPressScriptText has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

          protected function getKeyPressScriptText()
    {
        $scriptText  = null;
        $keyProperty = null;
        $keyValue    = null;
      Severity: Minor
      Found in FML/Script/Features/ToggleInterface.php - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function removeEntry has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

          public function removeEntry($entryId, $language = null)
    {
        $entryId = (string)$entryId;
        foreach ($this->entries as $languageKey => $entries) {
            if ($language && $language !== $languageKey) {
      Severity: Minor
      Found in FML/Elements/Dico.php - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Class constants must be uppercase; expected MATHLIB but found MathLib
      Open

          const MathLib = "MathLib";
      Severity: Minor
      Found in FML/Script/ScriptInclude.php by phpcodesniffer

      Class constants must be uppercase; expected MODEL_WINDOW but found MODEL_Window
      Open

          const MODEL_Window  = "Window";
      Severity: Minor
      Found in FML/Stylesheet/Style3d.php by phpcodesniffer
      Severity
      Category
      Status
      Source
      Language