steeffeen/FancyManiaLinks

View on GitHub

Showing 2,233 of 2,233 total issues

Constant SUBSTYLE_UpGood should be defined in uppercase
Open

    const SUBSTYLE_UpGood     = 'UpGood';
Severity: Minor
Found in FML/Controls/Quads/Quad_Copilot.php by phpmd

ConstantNamingConventions

Since: 0.2

Class/Interface constant names should always be defined in uppercase.

Example

class Foo {
    const MY_NUM = 0; // ok
    const myTest = ""; // fail
}

Source https://phpmd.org/rules/naming.html#constantnamingconventions

Constant SUBSTYLE_PlayerJunction should be defined in uppercase
Open

    CONST SUBSTYLE_PlayerJunction     = 'PlayerJunction';

ConstantNamingConventions

Since: 0.2

Class/Interface constant names should always be defined in uppercase.

Example

class Foo {
    const MY_NUM = 0; // ok
    const myTest = ""; // fail
}

Source https://phpmd.org/rules/naming.html#constantnamingconventions

Constant SUBSTYLE_EnergyBar_0_25 should be defined in uppercase
Open

    const SUBSTYLE_EnergyBar_0_25   = 'EnergyBar_0.25';
Severity: Minor
Found in FML/Controls/Quads/Quad_EnergyBar.php by phpmd

ConstantNamingConventions

Since: 0.2

Class/Interface constant names should always be defined in uppercase.

Example

class Foo {
    const MY_NUM = 0; // ok
    const myTest = ""; // fail
}

Source https://phpmd.org/rules/naming.html#constantnamingconventions

Constant SUBSTYLE_Nations should be defined in uppercase
Open

    const SUBSTYLE_Nations          = 'Nations';

ConstantNamingConventions

Since: 0.2

Class/Interface constant names should always be defined in uppercase.

Example

class Foo {
    const MY_NUM = 0; // ok
    const myTest = ""; // fail
}

Source https://phpmd.org/rules/naming.html#constantnamingconventions

getValue accesses the super-global variable $_GET.
Open

    public static function getValue($name)
    {
        if (array_key_exists($name, $_GET)) {
            return $_GET[$name];
        }
Severity: Minor
Found in FML/Form/Parameters.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

Constant SUBSTYLE_Padlock should be defined in uppercase
Open

    const SUBSTYLE_Padlock          = 'Padlock';

ConstantNamingConventions

Since: 0.2

Class/Interface constant names should always be defined in uppercase.

Example

class Foo {
    const MY_NUM = 0; // ok
    const myTest = ""; // fail
}

Source https://phpmd.org/rules/naming.html#constantnamingconventions

Constant SUBSTYLE_Options should be defined in uppercase
Open

    const SUBSTYLE_Options          = 'Options';

ConstantNamingConventions

Since: 0.2

Class/Interface constant names should always be defined in uppercase.

Example

class Foo {
    const MY_NUM = 0; // ok
    const myTest = ""; // fail
}

Source https://phpmd.org/rules/naming.html#constantnamingconventions

Constant SUBSTYLE_Puzzle should be defined in uppercase
Open

    const SUBSTYLE_Puzzle           = 'Puzzle';

ConstantNamingConventions

Since: 0.2

Class/Interface constant names should always be defined in uppercase.

Example

class Foo {
    const MY_NUM = 0; // ok
    const myTest = ""; // fail
}

Source https://phpmd.org/rules/naming.html#constantnamingconventions

Constant SUBSTYLE_ManiaPlanet should be defined in uppercase
Open

    const SUBSTYLE_ManiaPlanet     = 'ManiaPlanet';

ConstantNamingConventions

Since: 0.2

Class/Interface constant names should always be defined in uppercase.

Example

class Foo {
    const MY_NUM = 0; // ok
    const myTest = ""; // fail
}

Source https://phpmd.org/rules/naming.html#constantnamingconventions

Constant SUBSTYLE_RT_Cup should be defined in uppercase
Open

    const SUBSTYLE_RT_Cup          = 'RT_Cup';

ConstantNamingConventions

Since: 0.2

Class/Interface constant names should always be defined in uppercase.

Example

class Foo {
    const MY_NUM = 0; // ok
    const myTest = ""; // fail
}

Source https://phpmd.org/rules/naming.html#constantnamingconventions

Constant SUBSTYLE_Windowed should be defined in uppercase
Open

    const SUBSTYLE_Windowed        = 'Windowed';

ConstantNamingConventions

Since: 0.2

Class/Interface constant names should always be defined in uppercase.

Example

class Foo {
    const MY_NUM = 0; // ok
    const myTest = ""; // fail
}

Source https://phpmd.org/rules/naming.html#constantnamingconventions

Constant SUBSTYLE_Browser should be defined in uppercase
Open

    const SUBSTYLE_Browser               = 'Browser';

ConstantNamingConventions

Since: 0.2

Class/Interface constant names should always be defined in uppercase.

Example

class Foo {
    const MY_NUM = 0; // ok
    const myTest = ""; // fail
}

Source https://phpmd.org/rules/naming.html#constantnamingconventions

Constant SUBSTYLE_LvlYellow should be defined in uppercase
Open

    const SUBSTYLE_LvlYellow             = 'LvlYellow';

ConstantNamingConventions

Since: 0.2

Class/Interface constant names should always be defined in uppercase.

Example

class Foo {
    const MY_NUM = 0; // ok
    const myTest = ""; // fail
}

Source https://phpmd.org/rules/naming.html#constantnamingconventions

Constant SUBSTYLE_ManiaLinkPrev should be defined in uppercase
Open

    const SUBSTYLE_ManiaLinkPrev         = 'ManiaLinkPrev';

ConstantNamingConventions

Since: 0.2

Class/Interface constant names should always be defined in uppercase.

Example

class Foo {
    const MY_NUM = 0; // ok
    const myTest = ""; // fail
}

Source https://phpmd.org/rules/naming.html#constantnamingconventions

Constant SUBSTYLE_OfficialRace should be defined in uppercase
Open

    const SUBSTYLE_OfficialRace          = 'OfficialRace';

ConstantNamingConventions

Since: 0.2

Class/Interface constant names should always be defined in uppercase.

Example

class Foo {
    const MY_NUM = 0; // ok
    const myTest = ""; // fail
}

Source https://phpmd.org/rules/naming.html#constantnamingconventions

Constant SUBSTYLE_Third should be defined in uppercase
Open

    const SUBSTYLE_Third                 = 'Third';

ConstantNamingConventions

Since: 0.2

Class/Interface constant names should always be defined in uppercase.

Example

class Foo {
    const MY_NUM = 0; // ok
    const myTest = ""; // fail
}

Source https://phpmd.org/rules/naming.html#constantnamingconventions

Constant SUBSTYLE_ArrowHit should be defined in uppercase
Open

    const SUBSTYLE_ArrowHit           = 'ArrowHit';

ConstantNamingConventions

Since: 0.2

Class/Interface constant names should always be defined in uppercase.

Example

class Foo {
    const MY_NUM = 0; // ok
    const myTest = ""; // fail
}

Source https://phpmd.org/rules/naming.html#constantnamingconventions

Constant SUBSTYLE_Disconnected should be defined in uppercase
Open

    const SUBSTYLE_Disconnected       = 'Disconnected';

ConstantNamingConventions

Since: 0.2

Class/Interface constant names should always be defined in uppercase.

Example

class Foo {
    const MY_NUM = 0; // ok
    const myTest = ""; // fail
}

Source https://phpmd.org/rules/naming.html#constantnamingconventions

Constant SUBSTYLE_IconAdd should be defined in uppercase
Open

    const SUBSTYLE_IconAdd      = 'IconAdd';

ConstantNamingConventions

Since: 0.2

Class/Interface constant names should always be defined in uppercase.

Example

class Foo {
    const MY_NUM = 0; // ok
    const myTest = ""; // fail
}

Source https://phpmd.org/rules/naming.html#constantnamingconventions

Constant SUBSTYLE_IconHome should be defined in uppercase
Open

    const SUBSTYLE_IconHome     = 'IconHome';

ConstantNamingConventions

Since: 0.2

Class/Interface constant names should always be defined in uppercase.

Example

class Foo {
    const MY_NUM = 0; // ok
    const myTest = ""; // fail
}

Source https://phpmd.org/rules/naming.html#constantnamingconventions

Severity
Category
Status
Source
Language