Sign upLogin

steeffeen/FancyManiaLinks

View on GitHub
Star

Showing 2,233 of 2,233 total issues

Class constants must be uppercase; expected SUBSTYLE_COPY but found SUBSTYLE_Copy
Open

    const SUBSTYLE_Copy        = 'Copy';
Severity: Minor
Found in FML/Controls/Quads/Quad_UIConstruction_Buttons2.php by phpcodesniffer

Class constants must be uppercase; expected SUBSTYLE_KEYSADD but found SUBSTYLE_KeysAdd
Open

    const SUBSTYLE_KeysAdd     = 'KeysAdd';
Severity: Minor
Found in FML/Controls/Quads/Quad_UIConstruction_Buttons2.php by phpcodesniffer

PHP keywords must be lowercase; expected "const" but found "CONST"
Open

    CONST SUBSTYLE_CenterShield       = 'CenterShield';
Severity: Minor
Found in FML/Controls/Quads/Quad_UiSMSpectatorScoreBig.php by phpcodesniffer

Class constants must be uppercase; expected SUBSTYLE_CENTERSHIELDSMALL but found SUBSTYLE_CenterShieldSmall
Open

    CONST SUBSTYLE_CenterShieldSmall  = 'CenterShieldSmall';
Severity: Minor
Found in FML/Controls/Quads/Quad_UiSMSpectatorScoreBig.php by phpcodesniffer

PHP keywords must be lowercase; expected "const" but found "CONST"
Open

    CONST SUBSTYLE_PlayerJunction     = 'PlayerJunction';
Severity: Minor
Found in FML/Controls/Quads/Quad_UiSMSpectatorScoreBig.php by phpcodesniffer

Class constants must be uppercase; expected SUBSTYLE_PLAYERSLOTSMALLREV but found SUBSTYLE_PlayerSlotSmallRev
Open

    CONST SUBSTYLE_PlayerSlotSmallRev = 'PlayerSlotSmallRev';
Severity: Minor
Found in FML/Controls/Quads/Quad_UiSMSpectatorScoreBig.php by phpcodesniffer

PHP keywords must be lowercase; expected "const" but found "CONST"
Open

    CONST SUBSTYLE_UIRange1Bg         = 'UIRange1Bg';
Severity: Minor
Found in FML/Controls/Quads/Quad_UiSMSpectatorScoreBig.php by phpcodesniffer

The closing brace for the class must go on the next line after the body
Open

}
Severity: Minor
Found in FML/Controls/TextEdit.php by phpcodesniffer

The closing brace for the class must go on the next line after the body
Open

}
Severity: Minor
Found in FML/Elements/Format.php by phpcodesniffer

The closing brace for the class must go on the next line after the body
Open

}
Severity: Minor
Found in FML/Elements/Including.php by phpcodesniffer

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    public function addScriptFunction($name, $text = null)
    {
        if ($name instanceof ScriptFunction) {
            $scriptFunction = $name;
        } else {
Severity: Minor
Found in FML/Script/Script.php and 2 other locations - About 30 mins to fix
FML/Script/Script.php on lines 104..115
FML/Script/Script.php on lines 156..167

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 91.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    public function addScriptConstant($name, $value = null)
    {
        if ($name instanceof ScriptConstant) {
            $scriptConstant = $name;
        } else {
Severity: Minor
Found in FML/Script/Script.php and 2 other locations - About 30 mins to fix
FML/Script/Script.php on lines 135..146
FML/Script/Script.php on lines 156..167

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 91.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

    public function addCustomScriptLabel($name, $text = null)
    {
        if ($name instanceof ScriptLabel) {
            $scriptLabel = $name;
        } else {
Severity: Minor
Found in FML/Script/Script.php and 2 other locations - About 30 mins to fix
FML/Script/Script.php on lines 104..115
FML/Script/Script.php on lines 135..146

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 91.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

The method getMood has a boolean flag argument $createIfEmpty, which is a certain sign of a Single Responsibility Principle violation.
Open

    public function getMood($createIfEmpty = true)
Severity: Minor
Found in FML/Stylesheet/Stylesheet.php by phpmd

BooleanArgumentFlag

Since: 1.4.0

A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

Example

class Foo {
    public function bar($flag = true) {
    }
}

Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

The method addTooltipLabelFeature has a boolean flag argument $stayOnClick, which is a certain sign of a Single Responsibility Principle violation.
Open

    public function addTooltipLabelFeature(Label $tooltipLabel, $text, $stayOnClick = false, $invert = false)
Severity: Minor
Found in FML/Controls/Control.php by phpmd

BooleanArgumentFlag

Since: 1.4.0

A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

Example

class Foo {
    public function bar($flag = true) {
    }
}

Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

The method addToggleFeature has a boolean flag argument $onlyShow, which is a certain sign of a Single Responsibility Principle violation.
Open

    public function addToggleFeature(Control $toggledControl, $labelName = ScriptLabel::MOUSECLICK, $onlyShow = false, $onlyHide = false)
Severity: Minor
Found in FML/Controls/Control.php by phpmd

BooleanArgumentFlag

Since: 1.4.0

A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

Example

class Foo {
    public function bar($flag = true) {
    }
}

Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

The method addClockFeature has a boolean flag argument $showSeconds, which is a certain sign of a Single Responsibility Principle violation.
Open

    public function addClockFeature($showSeconds = true, $showFullDate = false)
Severity: Minor
Found in FML/Controls/Label.php by phpmd

BooleanArgumentFlag

Since: 1.4.0

A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

Example

class Foo {
    public function bar($flag = true) {
    }
}

Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

The method getFormat has a boolean flag argument $createIfEmpty, which is a certain sign of a Single Responsibility Principle violation.
Open

    public function getFormat($createIfEmpty = true)
Severity: Minor
Found in FML/Controls/Frame.php by phpmd

BooleanArgumentFlag

Since: 1.4.0

A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

Example

class Foo {
    public function bar($flag = true) {
    }
}

Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

The method addClockFeature has a boolean flag argument $showFullDate, which is a certain sign of a Single Responsibility Principle violation.
Open

    public function addClockFeature($showSeconds = true, $showFullDate = false)
Severity: Minor
Found in FML/Controls/Label.php by phpmd

BooleanArgumentFlag

Since: 1.4.0

A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

Example

class Foo {
    public function bar($flag = true) {
    }
}

Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

The method getFormat has a boolean flag argument $createIfEmpty, which is a certain sign of a Single Responsibility Principle violation.
Open

    public function getFormat($createIfEmpty = true);
Severity: Minor
Found in FML/Types/Container.php by phpmd

BooleanArgumentFlag

Since: 1.4.0

A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

Example

class Foo {
    public function bar($flag = true) {
    }
}

Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

Severity
Category
Status
Source
Language