Sign upLogin

steeffeen/FancyManiaLinks

View on GitHub
Star

Showing 2,233 of 2,233 total issues

Avoid using static access to class '\FML\UniqueID' in method 'checkId'.
Open

        return UniqueID::check($this);
Severity: Minor
Found in FML/Controls/Control.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

The 'getLiveInfoVisible()' method which returns a boolean should be named 'is...()' or 'has...()'
Open

    public function getLiveInfoVisible()
    {
        return $this->getVisibleProperty($this->liveInfoProperties);
    }
Severity: Minor
Found in FML/XmlRpc/TMUIProperties.php by phpmd

BooleanGetMethodName

Since: 0.2

Looks for methods named 'getX()' with 'boolean' as the return type. The convention is to name these methods 'isX()' or 'hasX()'.

Example

class Foo {
    /**
     * @return boolean
     */
    public function getFoo() {} // bad
    /**
     * @return bool
     */
    public function isFoo(); // ok
    /**
     * @return boolean
     */
    public function getFoo($bar); // ok, unless checkParameterizedMethods=true
}

Source https://phpmd.org/rules/naming.html#booleangetmethodname

The 'getSpectatorInfoVisible()' method which returns a boolean should be named 'is...()' or 'has...()'
Open

    public function getSpectatorInfoVisible()
    {
        return $this->getVisibleProperty($this->spectatorInfoProperties);
    }
Severity: Minor
Found in FML/XmlRpc/TMUIProperties.php by phpmd

BooleanGetMethodName

Since: 0.2

Looks for methods named 'getX()' with 'boolean' as the return type. The convention is to name these methods 'isX()' or 'hasX()'.

Example

class Foo {
    /**
     * @return boolean
     */
    public function getFoo() {} // bad
    /**
     * @return bool
     */
    public function isFoo(); // ok
    /**
     * @return boolean
     */
    public function getFoo($bar); // ok, unless checkParameterizedMethods=true
}

Source https://phpmd.org/rules/naming.html#booleangetmethodname

The 'getPositionVisible()' method which returns a boolean should be named 'is...()' or 'has...()'
Open

    public function getPositionVisible()
    {
        return $this->getVisibleProperty($this->positionProperties);
    }
Severity: Minor
Found in FML/XmlRpc/TMUIProperties.php by phpmd

BooleanGetMethodName

Since: 0.2

Looks for methods named 'getX()' with 'boolean' as the return type. The convention is to name these methods 'isX()' or 'hasX()'.

Example

class Foo {
    /**
     * @return boolean
     */
    public function getFoo() {} // bad
    /**
     * @return bool
     */
    public function isFoo(); // ok
    /**
     * @return boolean
     */
    public function getFoo($bar); // ok, unless checkParameterizedMethods=true
}

Source https://phpmd.org/rules/naming.html#booleangetmethodname

The 'getCheckpointTimeVisible()' method which returns a boolean should be named 'is...()' or 'has...()'
Open

    public function getCheckpointTimeVisible()
    {
        return $this->getVisibleProperty($this->checkpointTimeProperties);
    }
Severity: Minor
Found in FML/XmlRpc/TMUIProperties.php by phpmd

BooleanGetMethodName

Since: 0.2

Looks for methods named 'getX()' with 'boolean' as the return type. The convention is to name these methods 'isX()' or 'hasX()'.

Example

class Foo {
    /**
     * @return boolean
     */
    public function getFoo() {} // bad
    /**
     * @return bool
     */
    public function isFoo(); // ok
    /**
     * @return boolean
     */
    public function getFoo($bar); // ok, unless checkParameterizedMethods=true
}

Source https://phpmd.org/rules/naming.html#booleangetmethodname

The 'getTextEmboss()' method which returns a boolean should be named 'is...()' or 'has...()'
Open

    public function getTextEmboss()
    {
        return $this->textEmboss;
    }
Severity: Minor
Found in FML/Controls/Label.php by phpmd

BooleanGetMethodName

Since: 0.2

Looks for methods named 'getX()' with 'boolean' as the return type. The convention is to name these methods 'isX()' or 'hasX()'.

Example

class Foo {
    /**
     * @return boolean
     */
    public function getFoo() {} // bad
    /**
     * @return bool
     */
    public function isFoo(); // ok
    /**
     * @return boolean
     */
    public function getFoo($bar); // ok, unless checkParameterizedMethods=true
}

Source https://phpmd.org/rules/naming.html#booleangetmethodname

The method render() has an NPath complexity of 24576. The configured NPath complexity threshold is 200.
Open

    public function render(\DOMDocument $domDocument)
    {
        $domElement = $domDocument->createElement("mood");
        if ($this->lightAmbientColor) {
            $domElement->setAttribute("LAmbient_LinearRgb", $this->lightAmbientColor);
Severity: Minor
Found in FML/Stylesheet/Mood.php by phpmd

NPathComplexity

Since: 0.1

The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.

Example

class Foo {
    function bar() {
        // lots of complicated code
    }
}

Source https://phpmd.org/rules/codesize.html#npathcomplexity

The 'getPersonalBestAndRankVisible()' method which returns a boolean should be named 'is...()' or 'has...()'
Open

    public function getPersonalBestAndRankVisible()
    {
        return $this->getVisibleProperty($this->personalBestAndRankProperties);
    }
Severity: Minor
Found in FML/XmlRpc/TMUIProperties.php by phpmd

BooleanGetMethodName

Since: 0.2

Looks for methods named 'getX()' with 'boolean' as the return type. The convention is to name these methods 'isX()' or 'hasX()'.

Example

class Foo {
    /**
     * @return boolean
     */
    public function getFoo() {} // bad
    /**
     * @return bool
     */
    public function isFoo(); // ok
    /**
     * @return boolean
     */
    public function getFoo($bar); // ok, unless checkParameterizedMethods=true
}

Source https://phpmd.org/rules/naming.html#booleangetmethodname

The 'getDefault()' method which returns a boolean should be named 'is...()' or 'has...()'
Open

    public function getDefault()
    {
        return $this->feature->getDefault();
    }
Severity: Minor
Found in FML/Components/CheckBox.php by phpmd

BooleanGetMethodName

Since: 0.2

Looks for methods named 'getX()' with 'boolean' as the return type. The convention is to name these methods 'isX()' or 'hasX()'.

Example

class Foo {
    /**
     * @return boolean
     */
    public function getFoo() {} // bad
    /**
     * @return bool
     */
    public function isFoo(); // ok
    /**
     * @return boolean
     */
    public function getFoo($bar); // ok, unless checkParameterizedMethods=true
}

Source https://phpmd.org/rules/naming.html#booleangetmethodname

The 'getDrawBackground()' method which returns a boolean should be named 'is...()' or 'has...()'
Open

    public function getDrawBackground()
    {
        return $this->drawBackground;
    }
Severity: Minor
Found in FML/Controls/Gauge.php by phpmd

BooleanGetMethodName

Since: 0.2

Looks for methods named 'getX()' with 'boolean' as the return type. The convention is to name these methods 'isX()' or 'hasX()'.

Example

class Foo {
    /**
     * @return boolean
     */
    public function getFoo() {} // bad
    /**
     * @return bool
     */
    public function isFoo(); // ok
    /**
     * @return boolean
     */
    public function getFoo($bar); // ok, unless checkParameterizedMethods=true
}

Source https://phpmd.org/rules/naming.html#booleangetmethodname

The 'getDrawBlockBackground()' method which returns a boolean should be named 'is...()' or 'has...()'
Open

    public function getDrawBlockBackground()
    {
        return $this->drawBlockBackground;
    }
Severity: Minor
Found in FML/Controls/Gauge.php by phpmd

BooleanGetMethodName

Since: 0.2

Looks for methods named 'getX()' with 'boolean' as the return type. The convention is to name these methods 'isX()' or 'hasX()'.

Example

class Foo {
    /**
     * @return boolean
     */
    public function getFoo() {} // bad
    /**
     * @return bool
     */
    public function isFoo(); // ok
    /**
     * @return boolean
     */
    public function getFoo($bar); // ok, unless checkParameterizedMethods=true
}

Source https://phpmd.org/rules/naming.html#booleangetmethodname

Avoid using static access to class 'FML\Script\Builder' in method '__toString'.
Open

        return Builder::getInclude($this->file, $this->namespace);
Severity: Minor
Found in FML/Script/ScriptInclude.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

The 'getCrosshairVisible()' method which returns a boolean should be named 'is...()' or 'has...()'
Open

    public function getCrosshairVisible()
    {
        return $this->getVisibleProperty($this->crosshairProperties);
    }
Severity: Minor
Found in FML/XmlRpc/SMUIProperties.php by phpmd

BooleanGetMethodName

Since: 0.2

Looks for methods named 'getX()' with 'boolean' as the return type. The convention is to name these methods 'isX()' or 'hasX()'.

Example

class Foo {
    /**
     * @return boolean
     */
    public function getFoo() {} // bad
    /**
     * @return bool
     */
    public function isFoo(); // ok
    /**
     * @return boolean
     */
    public function getFoo($bar); // ok, unless checkParameterizedMethods=true
}

Source https://phpmd.org/rules/naming.html#booleangetmethodname

The 'getSpeedAndDistanceVisible()' method which returns a boolean should be named 'is...()' or 'has...()'
Open

    public function getSpeedAndDistanceVisible()
    {
        return $this->getVisibleProperty($this->speedAndDistanceProperties);
    }
Severity: Minor
Found in FML/XmlRpc/TMUIProperties.php by phpmd

BooleanGetMethodName

Since: 0.2

Looks for methods named 'getX()' with 'boolean' as the return type. The convention is to name these methods 'isX()' or 'hasX()'.

Example

class Foo {
    /**
     * @return boolean
     */
    public function getFoo() {} // bad
    /**
     * @return bool
     */
    public function isFoo(); // ok
    /**
     * @return boolean
     */
    public function getFoo($bar); // ok, unless checkParameterizedMethods=true
}

Source https://phpmd.org/rules/naming.html#booleangetmethodname

The 'getEndMapLadderRecapVisible()' method which returns a boolean should be named 'is...()' or 'has...()'
Open

    public function getEndMapLadderRecapVisible()
    {
        return $this->getVisibleProperty($this->endMapLadderRecapProperties);
    }
Severity: Minor
Found in FML/XmlRpc/UIProperties.php by phpmd

BooleanGetMethodName

Since: 0.2

Looks for methods named 'getX()' with 'boolean' as the return type. The convention is to name these methods 'isX()' or 'hasX()'.

Example

class Foo {
    /**
     * @return boolean
     */
    public function getFoo() {} // bad
    /**
     * @return bool
     */
    public function isFoo(); // ok
    /**
     * @return boolean
     */
    public function getFoo($bar); // ok, unless checkParameterizedMethods=true
}

Source https://phpmd.org/rules/naming.html#booleangetmethodname

Avoid using static access to class '\FML\Script\Features\ScriptFeature' in method 'getScriptFeatures'.
Open

        return ScriptFeature::collect($this->feature, $this->getQuad(), $this->getEntry());
Severity: Minor
Found in FML/Components/CheckBox.php by phpmd

StaticAccess

Since: 1.4.0

Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

Example

class Foo
{
    public function bar()
    {
        Bar::baz();
    }
}

Source https://phpmd.org/rules/cleancode.html#staticaccess

The method render() has an NPath complexity of 384. The configured NPath complexity threshold is 200.
Open

    public function render(\DOMDocument $domDocument)
    {
        $domElement = parent::render($domDocument);
        if ($this->data) {
            $domElement->setAttribute("data", $this->data);
Severity: Minor
Found in FML/Controls/Audio.php by phpmd

NPathComplexity

Since: 0.1

The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.

Example

class Foo {
    function bar() {
        // lots of complicated code
    }
}

Source https://phpmd.org/rules/codesize.html#npathcomplexity

The 'getSelectText()' method which returns a boolean should be named 'is...()' or 'has...()'
Open

    public function getSelectText()
    {
        return $this->selectText;
    }
Severity: Minor
Found in FML/Controls/Entry.php by phpmd

BooleanGetMethodName

Since: 0.2

Looks for methods named 'getX()' with 'boolean' as the return type. The convention is to name these methods 'isX()' or 'hasX()'.

Example

class Foo {
    /**
     * @return boolean
     */
    public function getFoo() {} // bad
    /**
     * @return bool
     */
    public function isFoo(); // ok
    /**
     * @return boolean
     */
    public function getFoo($bar); // ok, unless checkParameterizedMethods=true
}

Source https://phpmd.org/rules/naming.html#booleangetmethodname

The 'getNoticesVisible()' method which returns a boolean should be named 'is...()' or 'has...()'
Open

    public function getNoticesVisible()
    {
        return $this->getVisibleProperty($this->noticesProperties);
    }
Severity: Minor
Found in FML/XmlRpc/SMUIProperties.php by phpmd

BooleanGetMethodName

Since: 0.2

Looks for methods named 'getX()' with 'boolean' as the return type. The convention is to name these methods 'isX()' or 'hasX()'.

Example

class Foo {
    /**
     * @return boolean
     */
    public function getFoo() {} // bad
    /**
     * @return bool
     */
    public function isFoo(); // ok
    /**
     * @return boolean
     */
    public function getFoo($bar); // ok, unless checkParameterizedMethods=true
}

Source https://phpmd.org/rules/naming.html#booleangetmethodname

The 'getScoresTableAltVisible()' method which returns a boolean should be named 'is...()' or 'has...()'
Open

    public function getScoresTableAltVisible()
    {
        return $this->getProperty($this->scoresTableProperties, "alt_visible");
    }
Severity: Minor
Found in FML/XmlRpc/UIProperties.php by phpmd

BooleanGetMethodName

Since: 0.2

Looks for methods named 'getX()' with 'boolean' as the return type. The convention is to name these methods 'isX()' or 'hasX()'.

Example

class Foo {
    /**
     * @return boolean
     */
    public function getFoo() {} // bad
    /**
     * @return bool
     */
    public function isFoo(); // ok
    /**
     * @return boolean
     */
    public function getFoo($bar); // ok, unless checkParameterizedMethods=true
}

Source https://phpmd.org/rules/naming.html#booleangetmethodname

Severity
Category
Status
Source
Language