steeffffeen/FancyManiaLinks

View on GitHub
FML/CustomUI.php

Summary

Maintainability
A
2 hrs
Test Coverage
A
100%

CustomUI has 21 functions (exceeds 20 allowed). Consider refactoring.
Open

class CustomUI
{

    /**
     * @var bool $globalVisible If the UI should be shown at all
Severity: Minor
Found in FML/CustomUI.php - About 2 hrs to fix

    Missing class import via use statement (line '265', column '43').
    Open

            $domDocument                = new \DOMDocument("1.0", "utf-8");
    Severity: Minor
    Found in FML/CustomUI.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
        return new \stdClass();
    }

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Avoid excessively long variable names like $checkpointListVisible. Keep variable name length under 20.
    Open

        protected $checkpointListVisible = null;
    Severity: Minor
    Found in FML/CustomUI.php by phpmd

    LongVariable

    Since: 0.2

    Detects when a field, formal or local variable is declared with a long name.

    Example

    class Something {
        protected $reallyLongIntName = -3; // VIOLATION - Field
        public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
            $otherReallyLongName = -5; // VIOLATION - Local
            for ($interestingIntIndex = 0; // VIOLATION - For
                 $interestingIntIndex < 10;
                 $interestingIntIndex++ ) {
            }
        }
    }

    Source https://phpmd.org/rules/naming.html#longvariable

    The closing brace for the class must go on the next line after the body
    Open

    }
    Severity: Minor
    Found in FML/CustomUI.php by phpcodesniffer

    The 'getChallengeInfoVisible()' method which returns a boolean should be named 'is...()' or 'has...()'
    Open

        public function getChallengeInfoVisible()
        {
            return $this->challengeInfoVisible;
        }
    Severity: Minor
    Found in FML/CustomUI.php by phpmd

    BooleanGetMethodName

    Since: 0.2

    Looks for methods named 'getX()' with 'boolean' as the return type. The convention is to name these methods 'isX()' or 'hasX()'.

    Example

    class Foo {
        /**
         * @return boolean
         */
        public function getFoo() {} // bad
        /**
         * @return bool
         */
        public function isFoo(); // ok
        /**
         * @return boolean
         */
        public function getFoo($bar); // ok, unless checkParameterizedMethods=true
    }

    Source https://phpmd.org/rules/naming.html#booleangetmethodname

    The 'getCheckpointListVisible()' method which returns a boolean should be named 'is...()' or 'has...()'
    Open

        public function getCheckpointListVisible()
        {
            return $this->checkpointListVisible;
        }
    Severity: Minor
    Found in FML/CustomUI.php by phpmd

    BooleanGetMethodName

    Since: 0.2

    Looks for methods named 'getX()' with 'boolean' as the return type. The convention is to name these methods 'isX()' or 'hasX()'.

    Example

    class Foo {
        /**
         * @return boolean
         */
        public function getFoo() {} // bad
        /**
         * @return bool
         */
        public function isFoo(); // ok
        /**
         * @return boolean
         */
        public function getFoo($bar); // ok, unless checkParameterizedMethods=true
    }

    Source https://phpmd.org/rules/naming.html#booleangetmethodname

    The 'getGlobalVisible()' method which returns a boolean should be named 'is...()' or 'has...()'
    Open

        public function getGlobalVisible()
        {
            return $this->globalVisible;
        }
    Severity: Minor
    Found in FML/CustomUI.php by phpmd

    BooleanGetMethodName

    Since: 0.2

    Looks for methods named 'getX()' with 'boolean' as the return type. The convention is to name these methods 'isX()' or 'hasX()'.

    Example

    class Foo {
        /**
         * @return boolean
         */
        public function getFoo() {} // bad
        /**
         * @return bool
         */
        public function isFoo(); // ok
        /**
         * @return boolean
         */
        public function getFoo($bar); // ok, unless checkParameterizedMethods=true
    }

    Source https://phpmd.org/rules/naming.html#booleangetmethodname

    The 'getChatVisible()' method which returns a boolean should be named 'is...()' or 'has...()'
    Open

        public function getChatVisible()
        {
            return $this->chatVisible;
        }
    Severity: Minor
    Found in FML/CustomUI.php by phpmd

    BooleanGetMethodName

    Since: 0.2

    Looks for methods named 'getX()' with 'boolean' as the return type. The convention is to name these methods 'isX()' or 'hasX()'.

    Example

    class Foo {
        /**
         * @return boolean
         */
        public function getFoo() {} // bad
        /**
         * @return bool
         */
        public function isFoo(); // ok
        /**
         * @return boolean
         */
        public function getFoo($bar); // ok, unless checkParameterizedMethods=true
    }

    Source https://phpmd.org/rules/naming.html#booleangetmethodname

    The 'getRoundScoresVisible()' method which returns a boolean should be named 'is...()' or 'has...()'
    Open

        public function getRoundScoresVisible()
        {
            return $this->roundScoresVisible;
        }
    Severity: Minor
    Found in FML/CustomUI.php by phpmd

    BooleanGetMethodName

    Since: 0.2

    Looks for methods named 'getX()' with 'boolean' as the return type. The convention is to name these methods 'isX()' or 'hasX()'.

    Example

    class Foo {
        /**
         * @return boolean
         */
        public function getFoo() {} // bad
        /**
         * @return bool
         */
        public function isFoo(); // ok
        /**
         * @return boolean
         */
        public function getFoo($bar); // ok, unless checkParameterizedMethods=true
    }

    Source https://phpmd.org/rules/naming.html#booleangetmethodname

    The 'getNetInfosVisible()' method which returns a boolean should be named 'is...()' or 'has...()'
    Open

        public function getNetInfosVisible()
        {
            return $this->netInfosVisible;
        }
    Severity: Minor
    Found in FML/CustomUI.php by phpmd

    BooleanGetMethodName

    Since: 0.2

    Looks for methods named 'getX()' with 'boolean' as the return type. The convention is to name these methods 'isX()' or 'hasX()'.

    Example

    class Foo {
        /**
         * @return boolean
         */
        public function getFoo() {} // bad
        /**
         * @return bool
         */
        public function isFoo(); // ok
        /**
         * @return boolean
         */
        public function getFoo($bar); // ok, unless checkParameterizedMethods=true
    }

    Source https://phpmd.org/rules/naming.html#booleangetmethodname

    The 'getNoticeVisible()' method which returns a boolean should be named 'is...()' or 'has...()'
    Open

        public function getNoticeVisible()
        {
            return $this->noticeVisible;
        }
    Severity: Minor
    Found in FML/CustomUI.php by phpmd

    BooleanGetMethodName

    Since: 0.2

    Looks for methods named 'getX()' with 'boolean' as the return type. The convention is to name these methods 'isX()' or 'hasX()'.

    Example

    class Foo {
        /**
         * @return boolean
         */
        public function getFoo() {} // bad
        /**
         * @return bool
         */
        public function isFoo(); // ok
        /**
         * @return boolean
         */
        public function getFoo($bar); // ok, unless checkParameterizedMethods=true
    }

    Source https://phpmd.org/rules/naming.html#booleangetmethodname

    The 'getScoretableVisible()' method which returns a boolean should be named 'is...()' or 'has...()'
    Open

        public function getScoretableVisible()
        {
            return $this->scoretableVisible;
        }
    Severity: Minor
    Found in FML/CustomUI.php by phpmd

    BooleanGetMethodName

    Since: 0.2

    Looks for methods named 'getX()' with 'boolean' as the return type. The convention is to name these methods 'isX()' or 'hasX()'.

    Example

    class Foo {
        /**
         * @return boolean
         */
        public function getFoo() {} // bad
        /**
         * @return bool
         */
        public function isFoo(); // ok
        /**
         * @return boolean
         */
        public function getFoo($bar); // ok, unless checkParameterizedMethods=true
    }

    Source https://phpmd.org/rules/naming.html#booleangetmethodname

    There are no issues that match your filters.

    Category
    Status