steeffffeen/FancyManiaLinks

View on GitHub
FML/Script/Builder.php

Summary

Maintainability
A
0 mins
Test Coverage
A
98%

The method getLabelImplementationBlock has a boolean flag argument $isolate, which is a certain sign of a Single Responsibility Principle violation.
Open

    public static function getLabelImplementationBlock($labelName, $implementationCode, $isolate = true)
Severity: Minor
Found in FML/Script/Builder.php by phpmd

BooleanArgumentFlag

Since: 1.4.0

A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

Example

class Foo {
    public function bar($flag = true) {
    }
}

Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

The method getArray has a boolean flag argument $associative, which is a certain sign of a Single Responsibility Principle violation.
Open

    public static function getArray(array $array, $associative = true)
Severity: Minor
Found in FML/Script/Builder.php by phpmd

BooleanArgumentFlag

Since: 1.4.0

A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

Example

class Foo {
    public function bar($flag = true) {
    }
}

Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

The method escapeText has a boolean flag argument $addApostrophes, which is a certain sign of a Single Responsibility Principle violation.
Open

    public static function escapeText($text, $addApostrophes = true)
Severity: Minor
Found in FML/Script/Builder.php by phpmd

BooleanArgumentFlag

Since: 1.4.0

A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

Example

class Foo {
    public function bar($flag = true) {
    }
}

Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

The closing brace for the class must go on the next line after the body
Open

}
Severity: Minor
Found in FML/Script/Builder.php by phpcodesniffer

There are no issues that match your filters.

Category
Status