Sign upLogin

steeffffeen/FancyManiaLinks

View on GitHub
Star
FML/XmlRpc/SMUIProperties.php

Summary

Maintainability
A
0 mins
Test Coverage
A
100%

Avoid excessively long variable names like $consumablesProperties. Keep variable name length under 20.
Open

    protected $consumablesProperties = array();
Severity: Minor
Found in FML/XmlRpc/SMUIProperties.php by phpmd

LongVariable

Since: 0.2

Detects when a field, formal or local variable is declared with a long name.

Example

class Something {
    protected $reallyLongIntName = -3; // VIOLATION - Field
    public static function main( array $interestingArgumentsList[] ) { // VIOLATION - Formal
        $otherReallyLongName = -5; // VIOLATION - Local
        for ($interestingIntIndex = 0; // VIOLATION - For
             $interestingIntIndex < 10;
             $interestingIntIndex++ ) {
        }
    }
}

Source https://phpmd.org/rules/naming.html#longvariable

The closing brace for the class must go on the next line after the body
Open

}
Severity: Minor
Found in FML/XmlRpc/SMUIProperties.php by phpcodesniffer

The 'getConsumablesVisible()' method which returns a boolean should be named 'is...()' or 'has...()'
Open

    public function getConsumablesVisible()
    {
        return $this->getVisibleProperty($this->consumablesProperties);
    }
Severity: Minor
Found in FML/XmlRpc/SMUIProperties.php by phpmd

BooleanGetMethodName

Since: 0.2

Looks for methods named 'getX()' with 'boolean' as the return type. The convention is to name these methods 'isX()' or 'hasX()'.

Example

class Foo {
    /**
     * @return boolean
     */
    public function getFoo() {} // bad
    /**
     * @return bool
     */
    public function isFoo(); // ok
    /**
     * @return boolean
     */
    public function getFoo($bar); // ok, unless checkParameterizedMethods=true
}

Source https://phpmd.org/rules/naming.html#booleangetmethodname

The 'getGaugesVisible()' method which returns a boolean should be named 'is...()' or 'has...()'
Open

    public function getGaugesVisible()
    {
        return $this->getVisibleProperty($this->gaugesProperties);
    }
Severity: Minor
Found in FML/XmlRpc/SMUIProperties.php by phpmd

BooleanGetMethodName

Since: 0.2

Looks for methods named 'getX()' with 'boolean' as the return type. The convention is to name these methods 'isX()' or 'hasX()'.

Example

class Foo {
    /**
     * @return boolean
     */
    public function getFoo() {} // bad
    /**
     * @return bool
     */
    public function isFoo(); // ok
    /**
     * @return boolean
     */
    public function getFoo($bar); // ok, unless checkParameterizedMethods=true
}

Source https://phpmd.org/rules/naming.html#booleangetmethodname

The 'getNoticesVisible()' method which returns a boolean should be named 'is...()' or 'has...()'
Open

    public function getNoticesVisible()
    {
        return $this->getVisibleProperty($this->noticesProperties);
    }
Severity: Minor
Found in FML/XmlRpc/SMUIProperties.php by phpmd

BooleanGetMethodName

Since: 0.2

Looks for methods named 'getX()' with 'boolean' as the return type. The convention is to name these methods 'isX()' or 'hasX()'.

Example

class Foo {
    /**
     * @return boolean
     */
    public function getFoo() {} // bad
    /**
     * @return bool
     */
    public function isFoo(); // ok
    /**
     * @return boolean
     */
    public function getFoo($bar); // ok, unless checkParameterizedMethods=true
}

Source https://phpmd.org/rules/naming.html#booleangetmethodname

The 'getCrosshairVisible()' method which returns a boolean should be named 'is...()' or 'has...()'
Open

    public function getCrosshairVisible()
    {
        return $this->getVisibleProperty($this->crosshairProperties);
    }
Severity: Minor
Found in FML/XmlRpc/SMUIProperties.php by phpmd

BooleanGetMethodName

Since: 0.2

Looks for methods named 'getX()' with 'boolean' as the return type. The convention is to name these methods 'isX()' or 'hasX()'.

Example

class Foo {
    /**
     * @return boolean
     */
    public function getFoo() {} // bad
    /**
     * @return bool
     */
    public function isFoo(); // ok
    /**
     * @return boolean
     */
    public function getFoo($bar); // ok, unless checkParameterizedMethods=true
}

Source https://phpmd.org/rules/naming.html#booleangetmethodname

There are no issues that match your filters.

Category
Status