steem-third-party/ganymede

View on GitHub
app/controllers/follows_controller.rb

Summary

Maintainability
B
4 hrs
Test Coverage

Method has too many lines. [45/30]
Open

  def index
    @request_at = Time.now
    @activity_after = Time.parse(params[:activity_after].presence || '1970-01-01T00:00:00Z')
    @activity_before = Time.parse(params[:activity_before].presence || @request_at.to_s)
    @op = params[:op].presence || nil

This cop checks if the length of a method exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

Method index has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
Open

  def index
    @request_at = Time.now
    @activity_after = Time.parse(params[:activity_after].presence || '1970-01-01T00:00:00Z')
    @activity_before = Time.parse(params[:activity_before].presence || @request_at.to_s)
    @op = params[:op].presence || nil
Severity: Minor
Found in app/controllers/follows_controller.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Cyclomatic complexity for index is too high. [14/6]
Open

  def index
    @request_at = Time.now
    @activity_after = Time.parse(params[:activity_after].presence || '1970-01-01T00:00:00Z')
    @activity_before = Time.parse(params[:activity_before].presence || @request_at.to_s)
    @op = params[:op].presence || nil

This cop checks that the cyclomatic complexity of methods is not higher than the configured maximum. The cyclomatic complexity is the number of linearly independent paths through a method. The algorithm counts decision points and adds one.

An if statement (or unless or ?:) increases the complexity by one. An else branch does not, since it doesn't add a decision point. The && operator (or keyword and) can be converted to a nested if statement, and ||/or is shorthand for a sequence of ifs, so they also add one. Loops can be said to have an exit condition, so they add one.

Method index has 45 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def index
    @request_at = Time.now
    @activity_after = Time.parse(params[:activity_after].presence || '1970-01-01T00:00:00Z')
    @activity_before = Time.parse(params[:activity_before].presence || @request_at.to_s)
    @op = params[:op].presence || nil
Severity: Minor
Found in app/controllers/follows_controller.rb - About 1 hr to fix

    Do not use prefix _ for a variable that is used.
    Open

            _op, _type, _mapping = case @op

    This cop checks for underscore-prefixed variables that are actually used.

    Example:

    # bad
    
    [1, 2, 3].each do |_num|
      do_something(_num)
    end

    Example:

    # good
    
    [1, 2, 3].each do |num|
      do_something(num)
    end

    Example:

    # good
    
    [1, 2, 3].each do |_num|
      do_something # not using `_num`
    end

    Do not use prefix _ for a variable that is used.
    Open

            _op, _type, _mapping = case @op

    This cop checks for underscore-prefixed variables that are actually used.

    Example:

    # bad
    
    [1, 2, 3].each do |_num|
      do_something(_num)
    end

    Example:

    # good
    
    [1, 2, 3].each do |num|
      do_something(num)
    end

    Example:

    # good
    
    [1, 2, 3].each do |_num|
      do_something # not using `_num`
    end

    end at 27, 8 is not aligned with case at 16, 31.
    Open

            end

    This cop checks whether the end keywords are aligned properly.

    Three modes are supported through the EnforcedStyleAlignWith configuration parameter:

    If it's set to keyword (which is the default), the end shall be aligned with the start of the keyword (if, class, etc.).

    If it's set to variable the end shall be aligned with the left-hand-side of the variable assignment, if there is one.

    If it's set to start_of_line, the end shall be aligned with the start of the line where the matching keyword appears.

    Example: EnforcedStyleAlignWith: keyword (default)

    # bad
    
    variable = if true
        end
    
    # good
    
    variable = if true
               end

    Example: EnforcedStyleAlignWith: variable

    # bad
    
    variable = if true
        end
    
    # good
    
    variable = if true
    end

    Example: EnforcedStyleAlignWith: startofline

    # bad
    
    variable = if true
        end
    
    # good
    
    puts(if true
    end)

    Do not use prefix _ for a variable that is used.
    Open

            _op, _type, _mapping = case @op

    This cop checks for underscore-prefixed variables that are actually used.

    Example:

    # bad
    
    [1, 2, 3].each do |_num|
      do_something(_num)
    end

    Example:

    # good
    
    [1, 2, 3].each do |num|
      do_something(num)
    end

    Example:

    # good
    
    [1, 2, 3].each do |_num|
      do_something # not using `_num`
    end

    There are no issues that match your filters.

    Category
    Status