Sign upLogin

steem-third-party/ganymede

View on GitHub
Star
app/helpers/discussions_helper.rb

Summary

Maintainability
A
0 mins
Test Coverage

Cyclomatic complexity for discussion_active_class is too high. [10/6]
Open

  def discussion_active_class(current_tab, classes = [])
    classes << case [current_tab, TRUE_STRING]
    when [:other_promoted, @other_promoted] then 'active'
    when [:predicted, @predicted] then 'active'
    when [:trending, @trending_by_reputation] then 'active'
Severity: Minor
Found in app/helpers/discussions_helper.rb by rubocop

This cop checks that the cyclomatic complexity of methods is not higher than the configured maximum. The cyclomatic complexity is the number of linearly independent paths through a method. The algorithm counts decision points and adds one.

An if statement (or unless or ?:) increases the complexity by one. An else branch does not, since it doesn't add a decision point. The && operator (or keyword and) can be converted to a nested if statement, and ||/or is shorthand for a sequence of ifs, so they also add one. Loops can be said to have an exit condition, so they add one.

Cyclomatic complexity for group_pattern is too high. [10/6]
Open

  def group_pattern(discussion)
    case TRUE_STRING
    when @other_promoted
      [time_ago_in_words(discussion[:timestamp]), discussion[:from], discussion[:amount]]
    when @predicted
Severity: Minor
Found in app/helpers/discussions_helper.rb by rubocop

This cop checks that the cyclomatic complexity of methods is not higher than the configured maximum. The cyclomatic complexity is the number of linearly independent paths through a method. The algorithm counts decision points and adds one.

An if statement (or unless or ?:) increases the complexity by one. An else branch does not, since it doesn't add a decision point. The && operator (or keyword and) can be converted to a nested if statement, and ||/or is shorthand for a sequence of ifs, so they also add one. Loops can be said to have an exit condition, so they add one.

Cyclomatic complexity for discussion_title is too high. [10/6]
Open

  def discussion_title
    title = 'Gamymede - '
    
    title << case TRUE_STRING
    when @other_promoted then 'Promoted by Third Parties'
Severity: Minor
Found in app/helpers/discussions_helper.rb by rubocop

This cop checks that the cyclomatic complexity of methods is not higher than the configured maximum. The cyclomatic complexity is the number of linearly independent paths through a method. The algorithm counts decision points and adds one.

An if statement (or unless or ?:) increases the complexity by one. An else branch does not, since it doesn't add a decision point. The && operator (or keyword and) can be converted to a nested if statement, and ||/or is shorthand for a sequence of ifs, so they also add one. Loops can be said to have an exit condition, so they add one.

end at 32, 4 is not aligned with case at 22, 15.
Open

    end
Severity: Minor
Found in app/helpers/discussions_helper.rb by rubocop

This cop checks whether the end keywords are aligned properly.

Three modes are supported through the EnforcedStyleAlignWith configuration parameter:

If it's set to keyword (which is the default), the end shall be aligned with the start of the keyword (if, class, etc.).

If it's set to variable the end shall be aligned with the left-hand-side of the variable assignment, if there is one.

If it's set to start_of_line, the end shall be aligned with the start of the line where the matching keyword appears.

Example: EnforcedStyleAlignWith: keyword (default)

# bad

variable = if true
    end

# good

variable = if true
           end

Example: EnforcedStyleAlignWith: variable

# bad

variable = if true
    end

# good

variable = if true
end

Example: EnforcedStyleAlignWith: startofline

# bad

variable = if true
    end

# good

puts(if true
end)

end at 18, 4 is not aligned with case at 7, 13.
Open

    end
Severity: Minor
Found in app/helpers/discussions_helper.rb by rubocop

This cop checks whether the end keywords are aligned properly.

Three modes are supported through the EnforcedStyleAlignWith configuration parameter:

If it's set to keyword (which is the default), the end shall be aligned with the start of the keyword (if, class, etc.).

If it's set to variable the end shall be aligned with the left-hand-side of the variable assignment, if there is one.

If it's set to start_of_line, the end shall be aligned with the start of the line where the matching keyword appears.

Example: EnforcedStyleAlignWith: keyword (default)

# bad

variable = if true
    end

# good

variable = if true
           end

Example: EnforcedStyleAlignWith: variable

# bad

variable = if true
    end

# good

variable = if true
end

Example: EnforcedStyleAlignWith: startofline

# bad

variable = if true
    end

# good

puts(if true
end)

There are no issues that match your filters.

Category
Status