Sign upLogin

steem-third-party/ganymede

View on GitHub
Star
app/jobs/find_flagwar_job.rb

Summary

Maintainability
B
4 hrs
Test Coverage

Method query has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
Open

  def query(options = {})
    options[:limit] ||= 100
    tag = options[:tag]
    by_cashout = discussions_by_cashout(tag, options)
Severity: Minor
Found in app/jobs/find_flagwar_job.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method discussions_by_cashout has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
Open

  def discussions_by_cashout(tag, options = {})
    by_cashout = []
    
    if !!tag
      response = api_execute(:get_discussions_by_cashout, options)
Severity: Minor
Found in app/jobs/find_flagwar_job.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method commented_any? has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

  def commented_any?(author)
    downvoter_accounts.map do |account|
      # Author has made at least one post (thus exposed to flag).
      if account.name == author && account.post_count > 0
        # Author reputation is above 25 (0 is Rep 25), meaning their comments
Severity: Minor
Found in app/jobs/find_flagwar_job.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method extract_votes has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

  def extract_votes(comment)
    votes = comment.active_votes
    
    [
      votes.map { |vote| vote if vote.percent > 0 }.compact,
Severity: Minor
Found in app/jobs/find_flagwar_job.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

end at 144, 4 is not aligned with if at 139, 28.
Open

    end
Severity: Minor
Found in app/jobs/find_flagwar_job.rb by rubocop

This cop checks whether the end keywords are aligned properly.

Three modes are supported through the EnforcedStyleAlignWith configuration parameter:

If it's set to keyword (which is the default), the end shall be aligned with the start of the keyword (if, class, etc.).

If it's set to variable the end shall be aligned with the left-hand-side of the variable assignment, if there is one.

If it's set to start_of_line, the end shall be aligned with the start of the line where the matching keyword appears.

Example: EnforcedStyleAlignWith: keyword (default)

# bad

variable = if true
    end

# good

variable = if true
           end

Example: EnforcedStyleAlignWith: variable

# bad

variable = if true
    end

# good

variable = if true
end

Example: EnforcedStyleAlignWith: startofline

# bad

variable = if true
    end

# good

puts(if true
end)

There are no issues that match your filters.

Category
Status