lib/nucleus/adapters/v1/heroku/app_states.rb
Method application_state
has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring. Open
Open
def application_state(app, retrieved_dynos = nil)
# 1: created, both repo and slug are nil
return Enums::ApplicationStates::CREATED unless repo_or_slug_content?(app)
# all subsequent states require dynos to be determined
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Avoid too many return
statements within this method. Open
Open
return Enums::ApplicationStates::IDLE if dynos_idle?(dynos)