Method state_created?
has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring. Open
def state_created?(app, gear_groups, deployments)
# this state exists, but only within the first seconds before the original deployment is applied
return true if gear_groups[0][:gears].all? { |gear| gear[:state] == 'new' }
if app[:keep_deployments].to_i > 1
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method application_state
has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring. Open
def application_state(app, gear_groups = nil, deployments = nil)
deployments ||= load_deployments(app[:id])
gear_groups ||= load_gears(app[:id])
return :created if state_created?(app, gear_groups, deployments)
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method state_deployed?
has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring. Open
def state_deployed?(app, gear_groups, deployments)
# Gears must all be stopped
return false unless gear_groups[0][:gears].all? { |gear| gear[:state] == 'stopped' }
deployments ||= load_deployments(app[:id])
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Avoid too many return
statements within this method. Open
return :idle if gear_groups[0][:gears].all? { |gear| gear[:state] == 'idle' }