Sign upLogin

stefanjudis/grunt-photobox

View on GitHub
Star

Showing 12 of 12 total issues

File photobox.js has 345 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/*
 * grunt-photoBox
 * https://github.com/stefan/grunt-photoBox
 *
 * Copyright (c) 2013 stefan judis
Severity: Minor
Found in tasks/lib/photobox.js - About 4 hrs to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

          this.grunt.util.spawn( {
        cmd  : 'composite',
        args : this.getCompositeArguments( picture )
      }, function( err, result, code ) {
        this.compositeCallback( err, result, code, picture );
    Severity: Major
    Found in tasks/lib/photobox.js and 1 other location - About 1 hr to fix
    tasks/lib/photobox.js on lines 65..70

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 69.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

      this.grunt.util.spawn( {
    cmd  : 'convert',
    args : this.getConvertArguments( picture )
  }, function( err, code, result ) {
    this.overlayCallback( err, code, result, picture );
    Severity: Major
    Found in tasks/lib/photobox.js and 1 other location - About 1 hr to fix
    tasks/lib/photobox.js on lines 98..103

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 69.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Function diff has 41 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    function diff( pixelsA, pixelsB, config ) {
  'use strict';

  var pixelsC    = pixelsA,
      length     = pixelsA.data.length,
    Severity: Minor
    Found in tasks/assets/scripts/worker.js - About 1 hr to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

            } else if ( filter === 'darker' ) {
        pixelsC.data[ i ]     -= adjustment; // r
        pixelsC.data[ i + 1 ] -= adjustment; // g
        pixelsC.data[ i + 2 ] -= adjustment; // b
      } else if ( filter === 'grayscale' ) {
      Severity: Major
      Found in tasks/assets/scripts/worker.js and 1 other location - About 1 hr to fix
      tasks/assets/scripts/worker.js on lines 69..84

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 67.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

            if ( filter === 'brighter' ) {
        pixelsC.data[ i ]     += adjustment; // r
        pixelsC.data[ i + 1 ] += adjustment; // g
        pixelsC.data[ i + 2 ] += adjustment; // b
      } else if ( filter === 'darker' ) {
      Severity: Major
      Found in tasks/assets/scripts/worker.js and 1 other location - About 1 hr to fix
      tasks/assets/scripts/worker.js on lines 73..84

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 67.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Function exports has 38 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      module.exports = function(grunt) {

  // Project configuration.
  grunt.initConfig( {
    // Before generating any new files, remove any previously-created files.
      Severity: Minor
      Found in Gruntfile.js - About 1 hr to fix

        Function startPhotoSession has 35 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        PhotoBox.prototype.startPhotoSession = function() {
  this.grunt.log.subhead( 'PHOTOBOX STARTED PHOTO SESSION.' );

  this.writeTimestampFile();
        Severity: Minor
        Found in tasks/lib/photobox.js - About 1 hr to fix

          Function createIndexFile has 31 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          PhotoBox.prototype.createIndexFile = function() {
  this.grunt.log.subhead( 'PHOTOBOX STARTED INDEX FILE GENERATION' );

  var templateData = this.pictures.map(
    function( picture ) {
          Severity: Minor
          Found in tasks/lib/photobox.js - About 1 hr to fix

            Function diff has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
            Open

            function diff( pixelsA, pixelsB, config ) {
  'use strict';

  var pixelsC    = pixelsA,
      length     = pixelsA.data.length,
            Severity: Minor
            Found in tasks/assets/scripts/worker.js - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function createDiffImages has 26 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

            PhotoBox.prototype.createDiffImages = function() {
  var imgPath = this.options.indexPath + 'img/' ;

  this.grunt.log.subhead( 'PHOTOBOX STARTED DIFF GENERATION.');
            Severity: Minor
            Found in tasks/lib/photobox.js - About 1 hr to fix

              Function tookPictureHandler has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
              Open

              PhotoBox.prototype.tookPictureHandler = function() {
  if ( this.pictureCount === this.pictures.length ) {
    this.grunt.log.ok( 'PHOTOBOX FINISHED PHOTO SESSION SUCCESSFULLY.' );

    if ( this.template === 'magic' ) {
              Severity: Minor
              Found in tasks/lib/photobox.js - About 35 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Severity
              Category
              Status
              Source
              Language