Sign upLogin

stefanrenne/RxSonosLib

View on GitHub
Star

Showing 71 of 73 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

import Foundation
import RxSwift

protocol SingleInteractor: Interactor {
Severity: Major
Found in RxSonosLib/Framework/Common/Protocol/SingleInteractor.swift and 1 other location - About 2 hrs to fix
RxSonosLib/Framework/Common/Protocol/ObservableInteractor.swift on lines 9..35

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 169.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

import Foundation
import RxSwift

protocol ObservableInteractor: Interactor {
Severity: Major
Found in RxSonosLib/Framework/Common/Protocol/ObservableInteractor.swift and 1 other location - About 2 hrs to fix
RxSonosLib/Framework/Common/Protocol/SingleInteractor.swift on lines 9..35

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 169.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

import Foundation
import RxSwift

struct SetMuteValues: RequestValues {
    let room: Room
Severity: Major
Found in RxSonosLib/Framework/Domain/Interactors/SetMuteInteractor.swift and 1 other location - About 2 hrs to fix
RxSonosLib/Framework/Domain/Interactors/SetVolumeInteractor.swift on lines 9..36

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 145.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

import Foundation
import RxSwift

struct SetVolumeValues: RequestValues {
    let group: Group
Severity: Major
Found in RxSonosLib/Framework/Domain/Interactors/SetVolumeInteractor.swift and 1 other location - About 2 hrs to fix
RxSonosLib/Framework/Domain/Interactors/SetMuteInteractor.swift on lines 9..37

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 145.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

import UIKit
import RxSonosLib

protocol BrowseRouter {
Severity: Major
Found in RxSonosLib/iOS Demo App/Coordinator/BrowseCoordinator.swift and 2 other locations - About 2 hrs to fix
RxSonosLib/iOS Demo App/Coordinator/MySonosCoordinator.swift on lines 9..40
RxSonosLib/iOS Demo App/Coordinator/SearchCoordinator.swift on lines 9..40

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 141.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

import UIKit
import RxSonosLib

protocol MySonosRouter {
Severity: Major
Found in RxSonosLib/iOS Demo App/Coordinator/MySonosCoordinator.swift and 2 other locations - About 2 hrs to fix
RxSonosLib/iOS Demo App/Coordinator/BrowseCoordinator.swift on lines 9..40
RxSonosLib/iOS Demo App/Coordinator/SearchCoordinator.swift on lines 9..40

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 141.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

import UIKit
import RxSonosLib

protocol SearchRouter {
Severity: Major
Found in RxSonosLib/iOS Demo App/Coordinator/SearchCoordinator.swift and 2 other locations - About 2 hrs to fix
RxSonosLib/iOS Demo App/Coordinator/BrowseCoordinator.swift on lines 9..40
RxSonosLib/iOS Demo App/Coordinator/MySonosCoordinator.swift on lines 9..40

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 141.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

import Foundation
import RxSwift

struct SetPreviousTrackValues: RequestValues {
    let group: Group
Severity: Major
Found in RxSonosLib/Framework/Domain/Interactors/SetPreviousTrackInteractor.swift and 1 other location - About 1 hr to fix
RxSonosLib/Framework/Domain/Interactors/SetNextTrackInteractor.swift on lines 9..34

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 124.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

import Foundation
import RxSwift

struct SetNextTrackValues: RequestValues {
    let group: Group
Severity: Major
Found in RxSonosLib/Framework/Domain/Interactors/SetNextTrackInteractor.swift and 1 other location - About 1 hr to fix
RxSonosLib/Framework/Domain/Interactors/SetPreviousTrackInteractor.swift on lines 9..35

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 124.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    private func setupTransportStateObservable() {
        SonosInteractor
         .getActiveGroup()
         .getTransportState()
         .subscribe(actionButton.data)
Severity: Major
Found in RxSonosLib/iOS Demo App/Presentation/Now Playing/NowPlayingViewController.swift and 1 other location - About 1 hr to fix
RxSonosLib/iOS Demo App/Presentation/TabBar/TabBarViewController.swift on lines 114..133

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 118.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    private func setupTransportStateObservable() {
        SonosInteractor
            .getActiveGroup()
            .getTransportState()
            .subscribe(actionButton.data)
Severity: Major
Found in RxSonosLib/iOS Demo App/Presentation/TabBar/TabBarViewController.swift and 1 other location - About 1 hr to fix
RxSonosLib/iOS Demo App/Presentation/Now Playing/NowPlayingViewController.swift on lines 128..147

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 118.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        if let presentationStringsVersionString = element["Presentation"]["Strings"].attributes["Version"],
            let presentationStringsVersion = Int(presentationStringsVersionString),
            let presentationStringsUriString = element["Presentation"]["Strings"].attributes["Uri"],
            let presentationStringsUri = URL(string: presentationStringsUriString) {
            strings = Presentation(uri: presentationStringsUri, version: presentationStringsVersion)
Severity: Major
Found in RxSonosLib/Framework/Data/RepositoryImplementations/MusicProvidersRepositoryImpl.swift and 1 other location - About 1 hr to fix
RxSonosLib/Framework/Data/RepositoryImplementations/MusicProvidersRepositoryImpl.swift on lines 45..50

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 91.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        if let presentationMapVersionString = element["Presentation"]["PresentationMap"].attributes["Version"],
            let presentationMapVersion = Int(presentationMapVersionString),
            let presentationMapUriString = element["Presentation"]["PresentationMap"].attributes["Uri"],
            let presentationMapUri = URL(string: presentationMapUriString) {
            presentationMap = Presentation(uri: presentationMapUri, version: presentationMapVersion)
Severity: Major
Found in RxSonosLib/Framework/Data/RepositoryImplementations/MusicProvidersRepositoryImpl.swift and 1 other location - About 1 hr to fix
RxSonosLib/Framework/Data/RepositoryImplementations/MusicProvidersRepositoryImpl.swift on lines 53..58

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 91.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function dataTask has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
Open

    func dataTask(with request: URLRequest) -> Single<Data> {
        return Single.create { (event) -> Disposable in
            let task = self.base.dataTask(with: request) { (data, response, error) in
                if let error = error {
                    event(.error(error))
Severity: Minor
Found in RxSonosLib/Framework/Remote/Network/Protocol/Network.swift - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

import Foundation

enum MusicTarget: SonosTargetType {
    
    case listAvailableServices
Severity: Major
Found in RxSonosLib/Framework/Remote/Network/Target/MusicTarget.swift and 1 other location - About 1 hr to fix
RxSonosLib/Framework/Remote/Network/Target/GroupTarget.swift on lines 9..44

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 82.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

import Foundation

enum GroupTarget: SonosTargetType {
    
    case state
Severity: Major
Found in RxSonosLib/Framework/Remote/Network/Target/GroupTarget.swift and 1 other location - About 1 hr to fix
RxSonosLib/Framework/Remote/Network/Target/MusicTarget.swift on lines 9..45

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 82.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function mapService has 27 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    func mapService(element: AEXMLElement) -> MusicProvider? {
        guard let idString = element.attributes["Id"],
              let id = Int(idString),
              let name = element.attributes["Name"],
              let secureUriString = element.attributes["SecureUri"],
Severity: Minor
Found in RxSonosLib/Framework/Data/RepositoryImplementations/MusicProvidersRepositoryImpl.swift - About 1 hr to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        lazy var trackGroupDescription: NSAttributedString = {
        return track.description(filterd: [TrackDescription.album])
            .joined(separator: "  ●  ", attrs: [NSAttributedString.Key.font: UIFont.systemFont(ofSize: 8), NSAttributedString.Key.baselineOffset: 2])
    }()
    Severity: Major
    Found in RxSonosLib/iOS Demo App/Presentation/Rooms/TrackViewModel.swift and 1 other location - About 1 hr to fix
    RxSonosLib/iOS Demo App/Presentation/Rooms/TrackViewModel.swift on lines 38..41

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 70.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        lazy var trackDescription: NSAttributedString = {
        return track.description(filterd: [TrackDescription.title])
            .joined(separator: "  ●  ", attrs: [NSAttributedString.Key.font: UIFont.systemFont(ofSize: 8), NSAttributedString.Key.baselineOffset: 2])
    }()
    Severity: Major
    Found in RxSonosLib/iOS Demo App/Presentation/Rooms/TrackViewModel.swift and 1 other location - About 1 hr to fix
    RxSonosLib/iOS Demo App/Presentation/Rooms/TrackViewModel.swift on lines 43..46

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 70.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

        public func set(mute enabled: Bool) -> Completable {
        return
            self
            .take(1)
            .asSingle()
    Severity: Major
    Found in RxSonosLib/Framework/Domain/Modal/Room.swift and 2 other locations - About 55 mins to fix
    RxSonosLib/Framework/Domain/Modal/Group.swift on lines 125..133
    RxSonosLib/Framework/Domain/Modal/Group.swift on lines 143..151

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 67.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Severity
    Category
    Status
    Source
    Language