Sign upLogin

stellar/horizon-importer

View on GitHub
Star

Showing 17 of 17 total issues

File ledger_importer_job.rb has 475 lines of code (exceeds 250 allowed). Consider refactoring.
Open

require 'bigdecimal'

#
# Takes the ledger header and transaction set of the requested sequence from the
# stellar_core database and imports them into the history database.
Severity: Minor
Found in app/jobs/history/ledger_importer_job.rb - About 7 hrs to fix

    Method import_history_operations has 166 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def import_history_operations(sctx, htx)
    hops = []

    sctx.operations_with_results.each_with_index do |op_and_r, i|
      application_order = i + 1
    Severity: Major
    Found in app/jobs/history/ledger_importer_job.rb - About 6 hrs to fix

      Method import_history_effects_for_operation has a Cognitive Complexity of 43 (exceeds 5 allowed). Consider refactoring.
      Open

        def import_history_effects_for_operation(sctx, scop, scresult, hop)
    effects = History::EffectFactory.new(hop)
    source_account = scop.source_account || sctx.source_account
    op_index = sctx.operations.index(scop)
    scopm = sctx.meta.operations![op_index]
      Severity: Minor
      Found in app/jobs/history/ledger_importer_job.rb - About 6 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method import_history_operations has a Cognitive Complexity of 40 (exceeds 5 allowed). Consider refactoring.
      Open

        def import_history_operations(sctx, htx)
    hops = []

    sctx.operations_with_results.each_with_index do |op_and_r, i|
      application_order = i + 1
      Severity: Minor
      Found in app/jobs/history/ledger_importer_job.rb - About 6 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method import_history_effects_for_operation has 139 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def import_history_effects_for_operation(sctx, scop, scresult, hop)
    effects = History::EffectFactory.new(hop)
    source_account = scop.source_account || sctx.source_account
    op_index = sctx.operations.index(scop)
    scopm = sctx.meta.operations![op_index]
      Severity: Major
      Found in app/jobs/history/ledger_importer_job.rb - About 5 hrs to fix

        Method perform has a Cognitive Complexity of 25 (exceeds 5 allowed). Consider refactoring.
        Open

          def perform(ledger_sequence, rebuild_allowed=false)
    stellar_core_ledger, stellar_core_transactions = load_stellar_core_data(ledger_sequence)

    if stellar_core_ledger.blank?
      raise ActiveRecord::RecordNotFound,
        Severity: Minor
        Found in app/jobs/history/ledger_importer_job.rb - About 3 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Class Transaction has 21 methods (exceeds 20 allowed). Consider refactoring.
        Open

        class StellarCore::Transaction < StellarCore::Base
  self.table_name  = "txhistory"
  self.primary_key = "txid"

  belongs_to :ledger_header, {
        Severity: Minor
        Found in app/models/stellar_core/transaction.rb - About 2 hrs to fix

          Method perform has 43 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            def perform(ledger_sequence, rebuild_allowed=false)
    stellar_core_ledger, stellar_core_transactions = load_stellar_core_data(ledger_sequence)

    if stellar_core_ledger.blank?
      raise ActiveRecord::RecordNotFound,
          Severity: Minor
          Found in app/jobs/history/ledger_importer_job.rb - About 1 hr to fix

            Method find_path has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
            Open

              def self.find_path(source, destination, amount_needed)
    results = []
    visited = {}

    fn = -> (depth, path, amount_needed) {
            Severity: Minor
            Found in app/models/stellar_core/offer.rb - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method index has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
            Open

              def index
    tx_scope = History::Transaction

    #TODO: clean this whole friggin method up
            Severity: Minor
            Found in app/controllers/transactions_controller.rb - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method index has 28 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

              def index
    tx_scope = History::Transaction

    #TODO: clean this whole friggin method up
            Severity: Minor
            Found in app/controllers/transactions_controller.rb - About 1 hr to fix

              Method process has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
              Open

                def process

    if malformed?
      @result = :malformed
      return
              Severity: Minor
              Found in app/models/transaction_submission.rb - About 45 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method from_meta has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
              Open

                  def from_meta(meta, fee_meta)
      results = []
      all_changes = meta.operations!.flat_map(&:changes)
      all_changes += fee_meta.changes
      all_changes.each do |change|
              Severity: Minor
              Found in app/models/stellar_core/participant_finder.rb - About 35 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method import_history_accounts has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
              Open

                def import_history_accounts(sctx)
    haccs = []

    sctx.operations.each_with_index do |op, i|
      next unless op.body.type == Stellar::OperationType.create_account
              Severity: Minor
              Found in app/jobs/history/ledger_importer_job.rb - About 35 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method call has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
              Open

                def call(env)
    status, headers, body = @app.call(env)

    if should_record(env)
      @total.mark
              Severity: Minor
              Found in lib/request_metrics.rb - About 25 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                      when Stellar::AssetType.asset_type_credit_alphanum12
          hop.details["asset_type"]   = "credit_alphanum12"
          hop.details["asset_code"]   = asset.asset_code12!.strip
          hop.details["asset_issuer"] = Stellar::Convert.pk_to_address source_account
              Severity: Minor
              Found in app/jobs/history/ledger_importer_job.rb and 1 other location - About 15 mins to fix
              app/jobs/history/ledger_importer_job.rb on lines 299..302

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 25.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                      when Stellar::AssetType.asset_type_credit_alphanum4
          hop.details["asset_type"]   = "credit_alphanum4"
          hop.details["asset_code"]   = asset.asset_code4!.strip
          hop.details["asset_issuer"] = Stellar::Convert.pk_to_address source_account
              Severity: Minor
              Found in app/jobs/history/ledger_importer_job.rb and 1 other location - About 15 mins to fix
              app/jobs/history/ledger_importer_job.rb on lines 303..306

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 25.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Severity
              Category
              Status
              Source
              Language