Sign upLogin

stellar/xdrgen

View on GitHub
Star
lib/xdrgen/generators/csharp.rb

Summary

Maintainability
F
4 days
Test Coverage

File csharp.rb has 518 lines of code (exceeds 250 allowed). Consider refactoring.
Open

module Xdrgen
  module Generators
    class Csharp < Xdrgen::Generators::Base
      def generate
        render_lib
Severity: Major
Found in lib/xdrgen/generators/csharp.rb - About 1 day to fix

    Method render_union has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
    Open

          def render_union(union, out)
        has_inner_value = false

        out.puts "public #{name union} () {}"
        out.puts <<-EOS.strip_heredoc
    Severity: Minor
    Found in lib/xdrgen/generators/csharp.rb - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method render_union has 70 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

          def render_union(union, out)
        has_inner_value = false

        out.puts "public #{name union} () {}"
        out.puts <<-EOS.strip_heredoc
    Severity: Major
    Found in lib/xdrgen/generators/csharp.rb - About 2 hrs to fix

      Class Csharp has 22 methods (exceeds 20 allowed). Consider refactoring.
      Open

          class Csharp < Xdrgen::Generators::Base
      def generate
        render_lib
        render_definitions(@top)
      end
      Severity: Minor
      Found in lib/xdrgen/generators/csharp.rb - About 2 hrs to fix

        Method render_nested_definitions has 35 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

              def render_nested_definitions(defn, out)
        return unless defn.respond_to? :nested_definitions
        defn.nested_definitions.each do |ndefn|
          case ndefn
          when AST::Definitions::Struct
        Severity: Minor
        Found in lib/xdrgen/generators/csharp.rb - About 1 hr to fix

          Method render_enum has 35 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

                def render_enum(enum, out)
        enumname = enum.name + 'Enum'

        out.puts "public enum #{enumname} {"
        out.balance_after /,[\s]*/ do
          Severity: Minor
          Found in lib/xdrgen/generators/csharp.rb - About 1 hr to fix

            Method encode_member has 34 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                  def encode_member(value, member, out)
        case member.declaration
        when AST::Declarations::Void
          return
        end
            Severity: Minor
            Found in lib/xdrgen/generators/csharp.rb - About 1 hr to fix

              Method decode_innervalue_member has 34 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                    def decode_innervalue_member(value, member, out)
        case member.declaration
        when AST::Declarations::Void
          return
        end
              Severity: Minor
              Found in lib/xdrgen/generators/csharp.rb - About 1 hr to fix

                Method decode_member has 34 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                      def decode_member(value, member, out)
        case member.declaration
        when AST::Declarations::Void
          return
        end
                Severity: Minor
                Found in lib/xdrgen/generators/csharp.rb - About 1 hr to fix

                  Method encode_innervalue_member has 34 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                        def encode_innervalue_member(value, member, out)
        case member.declaration
        when AST::Declarations::Void
          return
        end
                  Severity: Minor
                  Found in lib/xdrgen/generators/csharp.rb - About 1 hr to fix

                    Method decode_member has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
                    Open

                          def decode_member(value, member, out)
        case member.declaration
        when AST::Declarations::Void
          return
        end
                    Severity: Minor
                    Found in lib/xdrgen/generators/csharp.rb - About 1 hr to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Method encode_member has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
                    Open

                          def encode_member(value, member, out)
        case member.declaration
        when AST::Declarations::Void
          return
        end
                    Severity: Minor
                    Found in lib/xdrgen/generators/csharp.rb - About 1 hr to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Method decode_innervalue_member has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
                    Open

                          def decode_innervalue_member(value, member, out)
        case member.declaration
        when AST::Declarations::Void
          return
        end
                    Severity: Minor
                    Found in lib/xdrgen/generators/csharp.rb - About 1 hr to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Method encode_innervalue_member has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
                    Open

                          def encode_innervalue_member(value, member, out)
        case member.declaration
        when AST::Declarations::Void
          return
        end
                    Severity: Minor
                    Found in lib/xdrgen/generators/csharp.rb - About 1 hr to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Method render_struct has 27 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                          def render_struct(struct, out)
        out.puts "public #{name struct} () {}"
        struct.members.each do |m|
          out.puts <<-EOS.strip_heredoc
                public #{decl_string(m.declaration)} #{m.name.camelize} {get; set;}
                    Severity: Minor
                    Found in lib/xdrgen/generators/csharp.rb - About 1 hr to fix

                      Method encode_type has 26 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                            def encode_type(type, value)
        case type
        when AST::Typespecs::Int
          "stream.WriteInt(#{value})"
        when AST::Typespecs::UnsignedInt
                      Severity: Minor
                      Found in lib/xdrgen/generators/csharp.rb - About 1 hr to fix

                        Method type_string has 26 lines of code (exceeds 25 allowed). Consider refactoring.
                        Open

                              def type_string(type)
        case type
        when AST::Typespecs::Int
          'int'
        when AST::Typespecs::UnsignedInt
                        Severity: Minor
                        Found in lib/xdrgen/generators/csharp.rb - About 1 hr to fix

                          Method decode_type has 26 lines of code (exceeds 25 allowed). Consider refactoring.
                          Open

                                def decode_type(type)
        case type
        when AST::Typespecs::Int
          'stream.ReadInt()'
        when AST::Typespecs::UnsignedInt
                          Severity: Minor
                          Found in lib/xdrgen/generators/csharp.rb - About 1 hr to fix

                            Method render_nested_definitions has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                            Open

                                  def render_nested_definitions(defn, out)
        return unless defn.respond_to? :nested_definitions
        defn.nested_definitions.each do |ndefn|
          case ndefn
          when AST::Definitions::Struct
                            Severity: Minor
                            Found in lib/xdrgen/generators/csharp.rb - About 25 mins to fix

                            Cognitive Complexity

                            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                            A method's cognitive complexity is based on a few simple rules:

                            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                            • Code is considered more complex for each "break in the linear flow of the code"
                            • Code is considered more complex when "flow breaking structures are nested"

                            Further reading

                            Similar blocks of code found in 2 locations. Consider refactoring.
                            Open

                                    union.arms.each do |arm|
          case arm
          when AST::Definitions::UnionDefaultArm
            out.puts 'default:'
          else
                            Severity: Major
                            Found in lib/xdrgen/generators/csharp.rb and 1 other location - About 1 hr to fix
                            lib/xdrgen/generators/csharp.rb on lines 253..267

                            Duplicated Code

                            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                            Tuning

                            This issue has a mass of 65.

                            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                            Refactorings

                            Further Reading

                            Similar blocks of code found in 2 locations. Consider refactoring.
                            Open

                                    union.arms.each do |arm|
          case arm
          when AST::Definitions::UnionDefaultArm
            out.puts 'default:'
          else
                            Severity: Major
                            Found in lib/xdrgen/generators/csharp.rb and 1 other location - About 1 hr to fix
                            lib/xdrgen/generators/csharp.rb on lines 223..237

                            Duplicated Code

                            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                            Tuning

                            This issue has a mass of 65.

                            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                            Refactorings

                            Further Reading

                            Similar blocks of code found in 2 locations. Consider refactoring.
                            Open

                                      when AST::Definitions::Struct
            name = name ndefn
            out.puts "public class #{name} {"
            out.indent do
              render_struct ndefn, out
                            Severity: Minor
                            Found in lib/xdrgen/generators/csharp.rb and 1 other location - About 20 mins to fix
                            lib/xdrgen/generators/csharp.rb on lines 58..65

                            Duplicated Code

                            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                            Tuning

                            This issue has a mass of 27.

                            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                            Refactorings

                            Further Reading

                            Similar blocks of code found in 4 locations. Consider refactoring.
                            Open

                                  def render_source_comment(out, defn)
        return if defn.is_a?(AST::Definitions::Namespace)

        out.puts <<-EOS.strip_heredoc
            // === xdr source ============================================================
                            Severity: Minor
                            Found in lib/xdrgen/generators/csharp.rb and 3 other locations - About 20 mins to fix
                            lib/xdrgen/generators/elixir.rb on lines 47..58
                            lib/xdrgen/generators/javascript.rb on lines 47..57
                            lib/xdrgen/generators/ruby.rb on lines 172..182

                            Duplicated Code

                            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                            Tuning

                            This issue has a mass of 27.

                            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                            Refactorings

                            Further Reading

                            Similar blocks of code found in 2 locations. Consider refactoring.
                            Open

                                      when AST::Definitions::Union
            name = name ndefn
            out.puts "public class #{name} {"
            out.indent do
              render_union ndefn, out
                            Severity: Minor
                            Found in lib/xdrgen/generators/csharp.rb and 1 other location - About 20 mins to fix
                            lib/xdrgen/generators/csharp.rb on lines 43..50

                            Duplicated Code

                            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                            Tuning

                            This issue has a mass of 27.

                            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                            Refactorings

                            Further Reading

                            There are no issues that match your filters.

                            Category
                            Status