step1profit/r.js

View on GitHub

Showing 6 of 6 total issues

Function R has 125 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  var R = root.R = (function(){
    var instance;

    function init(){
      // http://stackoverflow.com/a/18560314
Severity: Major
Found in r.js - About 5 hrs to fix

    Function init has 115 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        function init(){
          // http://stackoverflow.com/a/18560314
          if (!Object.keys) {
            Object.keys = function (obj) {
              var arr = [], key;
    Severity: Major
    Found in r.js - About 4 hrs to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

        it('should return cloned array when arg is array', function() {
          var arg = [1,2,3];
          var exp = [1,2,3];
          expect(R.clone(arg)).toEqual(exp);
        });
      Severity: Major
      Found in __tests__/clone-test.js and 1 other location - About 1 hr to fix
      __tests__/uniq-test.js on lines 12..16

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 58.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

        it('should return same array when array has no duplicates', function() {
          var arg = [1,2,3];
          var exp = [1,2,3];
          expect(R.uniq(arg)).toEqual(exp);
        });
      Severity: Major
      Found in __tests__/uniq-test.js and 1 other location - About 1 hr to fix
      __tests__/clone-test.js on lines 12..16

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 58.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Avoid too many return statements within this function.
      Open

                  return true;
      Severity: Major
      Found in r.js - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

                return false;
        Severity: Major
        Found in r.js - About 30 mins to fix
          Severity
          Category
          Status
          Source
          Language