Sign upLogin

step1profit/yamlr

View on GitHub
Star

Showing 13 of 13 total issues

Method hash_to_array has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
Open

      def self.hash_to_array(arr, inp, opt, spc)
        inp.each do |key,val|
          case
          when val.is_a?(Hash)
            key = self.sym_to_str(key)
Severity: Minor
Found in lib/yamlr/writer/builder.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method read has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
Open

    def self.read(input, options)
      raise Yamlr::Reader::EmptyInputError if input.is_a?(String) && input.strip.empty?
      raise Yamlr::Reader::InvalidInputError unless input.is_a?(String) or input.is_a?(File)
      input = File.exists?(input) ? IO.readlines(input) : input.split("\n")
      raise Yamlr::Reader::EmptyFileError if input.empty?
Severity: Minor
Found in lib/yamlr/reader.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method build has 34 lines of code (exceeds 25 allowed). Consider refactoring.
Open

      def self.build(hsh, phs)
        add = false
        upd = nil
        msg = phs[:msg]
        self.doc_new(hsh) if hsh.empty? && msg != "doc"
Severity: Minor
Found in lib/yamlr/reader/builder.rb - About 1 hr to fix

    Method build has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
    Open

          def self.build(hsh, phs)
        add = false
        upd = nil
        msg = phs[:msg]
        self.doc_new(hsh) if hsh.empty? && msg != "doc"
    Severity: Minor
    Found in lib/yamlr/reader/builder.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

          def self.val_to_true(phs)
        x = []
        x << phs[:opt][:auto_true].is_a?(TrueClass)
        x << phs[:opt][:auto_true_vals].is_a?(TrueClass)
        if x.any?
    Severity: Major
    Found in lib/yamlr/reader/format.rb and 1 other location - About 1 hr to fix
    lib/yamlr/reader/format.rb on lines 39..46

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 53.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

          def self.key_to_true(phs)
        x = []
        x << phs[:opt][:auto_true].is_a?(TrueClass)
        x << phs[:opt][:auto_true_keys].is_a?(TrueClass)
        if x.any?
    Severity: Major
    Found in lib/yamlr/reader/format.rb and 1 other location - About 1 hr to fix
    lib/yamlr/reader/format.rb on lines 53..60

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 53.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Method parse_line has 27 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

          def self.parse_line(line, opts)
        nod = Yamlr::Reader::Node
        spc = opts[:space]
        hsh = opts[:hash]
        sym = opts[:symbol]
    Severity: Minor
    Found in lib/yamlr/reader/parser.rb - About 1 hr to fix

      Method write has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

          def self.write(object, filename, options)
      filename = "#{ENV['HOME']}/#{File.basename(filename.to_s)}" if (filename =~ /^~/)
      raise Yamlr::Writer::EmptyInputError if (object.is_a?(String) && object.strip.empty?)
      raise Yamlr::Writer::InvalidInputError unless (object.is_a?(String) or object.is_a?(Array) or object.is_a?(Hash))
      raise Yamlr::Writer::EmptyFilenameError if File.basename(filename.to_s).strip.empty?
      Severity: Minor
      Found in lib/yamlr/writer.rb - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method hash_to_lines has 6 arguments (exceeds 4 allowed). Consider refactoring.
      Open

            def self.hash_to_lines(arr, hsh, kys, opt, spc, idt = nil)
      Severity: Minor
      Found in lib/yamlr/writer/builder.rb - About 45 mins to fix

        Method array_to_lines has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

              def self.array_to_lines(arr, val, opt, spc, idt = nil)
        Severity: Minor
        Found in lib/yamlr/writer/builder.rb - About 35 mins to fix

          Method array_to_lines has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
          Open

                def self.array_to_lines(arr, val, opt, spc, idt = nil)
        idt = 0 if idt.nil?
        ist = spc * idt
        ind = opt[:array]
        until val.empty? do
          Severity: Minor
          Found in lib/yamlr/writer/builder.rb - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                def self.key_to_int(phs)
        x = []
        x << phs[:opt][:int].is_a?(TrueClass)
        x << phs[:opt][:int_keys].is_a?(TrueClass)
        phs[:key] = self.string_to_int(phs[:key]) if x.any?
          Severity: Minor
          Found in lib/yamlr/reader/format.rb and 1 other location - About 35 mins to fix
          lib/yamlr/reader/format.rb on lines 102..106

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 34.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                def self.val_to_int(phs)
        x = []
        x << phs[:opt][:int].is_a?(TrueClass)
        x << phs[:opt][:int_vals].is_a?(TrueClass)
        phs[:val] = self.string_to_int(phs[:val]) if x.any?
          Severity: Minor
          Found in lib/yamlr/reader/format.rb and 1 other location - About 35 mins to fix
          lib/yamlr/reader/format.rb on lines 93..97

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 34.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Severity
          Category
          Status
          Source
          Language