Sign upLogin

steroid-team/app

View on GitHub
Star

Showing 38 of 72 total issues

Method storeDrawing has 26 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    private void storeDrawing() {
        String tmpFileName = "bitmap_tmp_" + UUID.randomUUID().toString() + ".png";
        File tmpFile =
                new File(
                        Environment.getExternalStoragePublicDirectory(
Severity: Minor
Found in app/src/main/java/com/github/steroidteam/todolist/view/DrawingFragment.java - About 1 hr to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        public void createList(View view) {

        DialogListener dialogListener =
                new DialogListener() {
    Severity: Minor
    Found in app/src/main/java/com/github/steroidteam/todolist/view/ListSelectionFragment.java and 1 other location - About 1 hr to fix
    app/src/main/java/com/github/steroidteam/todolist/view/NoteSelectionFragment.java on lines 116..140

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 68.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        private void createNote(View view) {

        DialogListener dialogListener =
                new DialogListener() {
    Severity: Minor
    Found in app/src/main/java/com/github/steroidteam/todolist/view/NoteSelectionFragment.java and 1 other location - About 1 hr to fix
    app/src/main/java/com/github/steroidteam/todolist/view/ListSelectionFragment.java on lines 95..119

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 68.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

            userViewModel
                .getErrorOccurred()
                .observe(
                        getViewLifecycleOwner(),
                        bool -> {
    Severity: Minor
    Found in app/src/main/java/com/github/steroidteam/todolist/view/ProfileFragment.java and 1 other location - About 45 mins to fix
    app/src/main/java/com/github/steroidteam/todolist/view/ProfileFragment.java on lines 59..74

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 56.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

            userViewModel
                .getErrorOccurred()
                .observe(
                        getViewLifecycleOwner(),
                        bool -> {
    Severity: Minor
    Found in app/src/main/java/com/github/steroidteam/todolist/view/ProfileFragment.java and 1 other location - About 45 mins to fix
    app/src/main/java/com/github/steroidteam/todolist/view/ProfileFragment.java on lines 76..91

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 56.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Method init has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

        private void init() {
        localTags = viewModel.getTagsFromList();
        if (localTags == null) {
            localTags = new ArrayList<>();
        }
    Severity: Minor
    Found in app/src/main/java/com/github/steroidteam/todolist/view/misc/TagView.java - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        public void updatePassword(String newPassword) {
        if (userLiveData.getValue() != null) {
            userLiveData
                    .getValue()
                    .updatePassword(newPassword)
    Severity: Minor
    Found in app/src/main/java/com/github/steroidteam/todolist/viewmodel/UserViewModel.java and 1 other location - About 35 mins to fix
    app/src/main/java/com/github/steroidteam/todolist/viewmodel/UserViewModel.java on lines 54..62

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 46.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        public void updateUserMail(String newMail) {
        if (userLiveData.getValue() != null) {
            userLiveData
                    .getValue()
                    .updateEmail(newMail)
    Severity: Minor
    Found in app/src/main/java/com/github/steroidteam/todolist/viewmodel/UserViewModel.java and 1 other location - About 35 mins to fix
    app/src/main/java/com/github/steroidteam/todolist/viewmodel/UserViewModel.java on lines 64..72

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 46.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 3 locations. Consider refactoring.
    Open

                            todoList -> {
                            byte[] bytes =
                                    JSONSerializer.serializeTodoList(todoList)
                                            .getBytes(StandardCharsets.UTF_8);
                            return this.storageService
    Severity: Minor
    Found in app/src/main/java/com/github/steroidteam/todolist/database/FileStorageDatabase.java and 2 other locations - About 30 mins to fix
    app/src/main/java/com/github/steroidteam/todolist/database/FileStorageDatabase.java on lines 182..189
    app/src/main/java/com/github/steroidteam/todolist/database/FileStorageDatabase.java on lines 455..462

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 42.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 3 locations. Consider refactoring.
    Open

                            todoList -> {
                            byte[] bytes =
                                    JSONSerializer.serializeTodoList(todoList)
                                            .getBytes(StandardCharsets.UTF_8);
                            return this.storageService
    Severity: Minor
    Found in app/src/main/java/com/github/steroidteam/todolist/database/FileStorageDatabase.java and 2 other locations - About 30 mins to fix
    app/src/main/java/com/github/steroidteam/todolist/database/FileStorageDatabase.java on lines 157..164
    app/src/main/java/com/github/steroidteam/todolist/database/FileStorageDatabase.java on lines 182..189

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 42.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 3 locations. Consider refactoring.
    Open

                            todoList -> {
                            byte[] bytes =
                                    JSONSerializer.serializeTodoList(todoList)
                                            .getBytes(StandardCharsets.UTF_8);
                            return this.storageService
    Severity: Minor
    Found in app/src/main/java/com/github/steroidteam/todolist/database/FileStorageDatabase.java and 2 other locations - About 30 mins to fix
    app/src/main/java/com/github/steroidteam/todolist/database/FileStorageDatabase.java on lines 157..164
    app/src/main/java/com/github/steroidteam/todolist/database/FileStorageDatabase.java on lines 455..462

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 42.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Avoid too many return statements within this method.
    Open

                return true;
    Severity: Major
    Found in app/src/main/java/com/github/steroidteam/todolist/view/adapter/ParentTaskAdapter.java - About 30 mins to fix

      Avoid too many return statements within this method.
      Open

                  return true;
      Severity: Major
      Found in app/src/main/java/com/github/steroidteam/todolist/view/adapter/ParentTaskAdapter.java - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

                return diffDay >= 7 && category == TASK_LATER;
        Severity: Major
        Found in app/src/main/java/com/github/steroidteam/todolist/view/adapter/ParentTaskAdapter.java - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                      return true;
          Severity: Major
          Found in app/src/main/java/com/github/steroidteam/todolist/view/adapter/ParentTaskAdapter.java - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                    return this;
            Severity: Major
            Found in app/src/main/java/com/github/steroidteam/todolist/model/todo/TodoList.java - About 30 mins to fix

              Avoid too many return statements within this method.
              Open

                          return true;
              Severity: Major
              Found in app/src/main/java/com/github/steroidteam/todolist/view/adapter/ParentTaskAdapter.java - About 30 mins to fix

                Method onChildDraw has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                Open

                    @Override
    public void onChildDraw(
            Canvas c,
            RecyclerView recyclerView,
            RecyclerView.ViewHolder holder,
                Severity: Minor
                Found in app/src/main/java/com/github/steroidteam/todolist/view/misc/SwipeTouchHelper.java - About 25 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Severity
                Category
                Status
                Source
                Language