stevegrossi/stevegrossi

View on GitHub
lib/tasks/heroku.rake

Summary

Maintainability
Test Coverage

Please use Rails.root.join('path', 'to') instead.
Open

    system "pg_restore --verbose --clean --no-acl --no-owner -h #{host} -U #{local_user} -d #{local_db} #{Rails.root.join('tmp', 'production.dump')}"
Severity: Minor
Found in lib/tasks/heroku.rake by rubocop

This cop is used to identify usages of file path joining process to use Rails.root.join clause.

Example:

# bad Rails.root.join('app/models/goober') File.join(Rails.root, 'app/models/goober') "#{Rails.root}/app/models/goober"

# good Rails.root.join('app', 'models', 'goober')

Please use Rails.root.join('path', 'to') instead.
Open

    system "curl -o #{Rails.root.join('tmp', 'production.dump')} $(heroku pg:backups public-url -r production)"
Severity: Minor
Found in lib/tasks/heroku.rake by rubocop

This cop is used to identify usages of file path joining process to use Rails.root.join clause.

Example:

# bad Rails.root.join('app/models/goober') File.join(Rails.root, 'app/models/goober') "#{Rails.root}/app/models/goober"

# good Rails.root.join('app', 'models', 'goober')

Missing magic comment # frozen_string_literal: true.
Open

namespace :herokudb do
Severity: Minor
Found in lib/tasks/heroku.rake by rubocop

This cop is designed to help upgrade to Ruby 3.0. It will add the comment # frozen_string_literal: true to the top of files to enable frozen string literals. Frozen string literals may be default in Ruby 3.0. The comment will be added below a shebang and encoding comment. The frozen string literal comment is only valid in Ruby 2.3+.

Example: EnforcedStyle: when_needed (default)

# The `when_needed` style will add the frozen string literal comment
# to files only when the `TargetRubyVersion` is set to 2.3+.
# bad
module Foo
  # ...
end

# good
# frozen_string_literal: true

module Foo
  # ...
end

Example: EnforcedStyle: always

# The `always` style will always add the frozen string literal comment
# to a file, regardless of the Ruby version or if `freeze` or `<<` are
# called on a string literal.
# bad
module Bar
  # ...
end

# good
# frozen_string_literal: true

module Bar
  # ...
end

Example: EnforcedStyle: never

# The `never` will enforce that the frozen string literal comment does
# not exist in a file.
# bad
# frozen_string_literal: true

module Baz
  # ...
end

# good
module Baz
  # ...
end

Use %i or %I for an array of symbols.
Open

  task update_staging: [:backup_staging, :backup_production] do
Severity: Minor
Found in lib/tasks/heroku.rake by rubocop

This cop can check for array literals made up of symbols that are not using the %i() syntax.

Alternatively, it checks for symbol arrays using the %i() syntax on projects which do not want to use that syntax.

Configuration option: MinSize If set, arrays with fewer elements than this value will not trigger the cop. For example, a MinSize of3` will not enforce a style on an array of 2 or fewer elements.

Example: EnforcedStyle: percent (default)

# good
%i[foo bar baz]

# bad
[:foo, :bar, :baz]

Example: EnforcedStyle: brackets

# good
[:foo, :bar, :baz]

# bad
%i[foo bar baz]

There are no issues that match your filters.

Category
Status