Sign upLogin

stevenallen05/osbourne

View on GitHub
Star

Showing 2 of 133 total issues

Method fetch_existing_subscriptions_for has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    def fetch_existing_subscriptions_for(topic)
      results = []
      r = nil
      loop do
        params = {topic_arn: topic.arn}
Severity: Minor
Found in lib/osbourne/existing_subscriptions.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method try_with_lock has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

      def try_with_lock(id, hard_lock: false)
        if lock(lock_key(id), soft_ttl)
          begin
            yield
            unlock(id)
Severity: Minor
Found in lib/osbourne/locks/base.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Severity
Category
Status
Source
Language