Sign upLogin

stevotvr/phpbb-groupsub

View on GitHub
Star
controller/acp_subs_controller.php

Summary

Maintainability
D
1 day
Test Coverage

The class acp_subs_controller has an overall complexity of 68 which is very high. The configured complexity threshold is 50.
Open

class acp_subs_controller extends acp_base_controller implements acp_subs_interface
{
    /**
     * @var pkg_operator
     */
Severity: Minor
Found in controller/acp_subs_controller.php by phpmd

The method add_edit_sub_data() has 109 lines of code. Current threshold is set to 100. Avoid really long methods.
Open

    protected function add_edit_sub_data(sub_entity $entity, $params)
    {
        $this->add_lang();

        $errors = array();
Severity: Minor
Found in controller/acp_subs_controller.php by phpmd

The method add_edit_sub_data() has an NPath complexity of 10806. The configured NPath complexity threshold is 200.
Open

    protected function add_edit_sub_data(sub_entity $entity, $params)
    {
        $this->add_lang();

        $errors = array();
Severity: Minor
Found in controller/acp_subs_controller.php by phpmd

NPathComplexity

Since: 0.1

The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.

Example

class Foo {
    function bar() {
        // lots of complicated code
    }
}

Source https://phpmd.org/rules/codesize.html#npathcomplexity

The method add_edit_sub_data() has a Cyclomatic Complexity of 22. The configured cyclomatic complexity threshold is 10.
Open

    protected function add_edit_sub_data(sub_entity $entity, $params)
    {
        $this->add_lang();

        $errors = array();
Severity: Minor
Found in controller/acp_subs_controller.php by phpmd

CyclomaticComplexity

Since: 0.1

Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

Example

// Cyclomatic Complexity = 11
class Foo {
1   public function example() {
2       if ($a == $b) {
3           if ($a1 == $b1) {
                fiddle();
4           } elseif ($a2 == $b2) {
                fiddle();
            } else {
                fiddle();
            }
5       } elseif ($c == $d) {
6           while ($c == $d) {
                fiddle();
            }
7        } elseif ($e == $f) {
8           for ($n = 0; $n < $h; $n++) {
                fiddle();
            }
        } else {
            switch ($z) {
9               case 1:
                    fiddle();
                    break;
10              case 2:
                    fiddle();
                    break;
11              case 3:
                    fiddle();
                    break;
                default:
                    fiddle();
                    break;
            }
        }
    }
}

Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    public function restart($id)
    {
        if (!$this->auth->acl_get('a_groupsub_subscriptions_edit'))
        {
            return;
Severity: Major
Found in controller/acp_subs_controller.php and 1 other location - About 7 hrs to fix
controller/acp_subs_controller.php on lines 557..593

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 244.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    public function delete($id)
    {
        if (!$this->auth->acl_get('a_groupsub_subscriptions_edit'))
        {
            return;
Severity: Major
Found in controller/acp_subs_controller.php and 1 other location - About 7 hrs to fix
controller/acp_subs_controller.php on lines 516..552

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 244.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status