Sign upLogin

stevotvr/phpbb-groupsub

View on GitHub
Star
controller/main_controller.php

Summary

Maintainability
A
0 mins
Test Coverage

The method __construct has 12 parameters. Consider reducing the number of parameters to less than 10.
Open

    public function __construct(auth $auth, config $config, db_text $config_text, currency_interface $currency, helper $helper, language $language, package_interface $pkg_operator, request_interface $request, subscription_interface $sub_operator, template $template, unit_helper_interface $unit_helper, user $user)
    {
        $this->auth = $auth;
        $this->config = $config;
        $this->config_text = $config_text;
Severity: Minor
Found in controller/main_controller.php by phpmd

The class main_controller has a coupling between objects value of 14. Consider to reduce the number of dependencies under 13.
Open

class main_controller
{
    /**
     * @var auth
     */
Severity: Minor
Found in controller/main_controller.php by phpmd

CouplingBetweenObjects

Since: 1.1.0

A class with too many dependencies has negative impacts on several quality aspects of a class. This includes quality criteria like stability, maintainability and understandability

Example

class Foo {
    /**
     * @var \foo\bar\X
     */
    private $x = null;

    /**
     * @var \foo\bar\Y
     */
    private $y = null;

    /**
     * @var \foo\bar\Z
     */
    private $z = null;

    public function setFoo(\Foo $foo) {}
    public function setBar(\Bar $bar) {}
    public function setBaz(\Baz $baz) {}

    /**
     * @return \SplObjectStorage
     * @throws \OutOfRangeException
     * @throws \InvalidArgumentException
     * @throws \ErrorException
     */
    public function process(\Iterator $it) {}

    // ...
}

Source https://phpmd.org/rules/design.html#couplingbetweenobjects

There are no issues that match your filters.

Category
Status