Sign upLogin

stevotvr/phpbb-groupsub

View on GitHub
Star
operator/package_interface.php

Summary

Maintainability
A
0 mins
Test Coverage

The method get_packages has a boolean flag argument $name, which is a certain sign of a Single Responsibility Principle violation.
Wontfix

    public function get_packages($name = false, $enabled = true);
Severity: Minor
Found in operator/package_interface.php by phpmd

BooleanArgumentFlag

Since: 1.4.0

A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

Example

class Foo {
    public function bar($flag = true) {
    }
}

Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

The method get_packages has a boolean flag argument $enabled, which is a certain sign of a Single Responsibility Principle violation.
Wontfix

    public function get_packages($name = false, $enabled = true);
Severity: Minor
Found in operator/package_interface.php by phpmd

BooleanArgumentFlag

Since: 1.4.0

A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

Example

class Foo {
    public function bar($flag = true) {
    }
}

Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

The method get_terms has a boolean flag argument $package_id, which is a certain sign of a Single Responsibility Principle violation.
Invalid

    public function get_terms($package_id = false);
Severity: Minor
Found in operator/package_interface.php by phpmd

BooleanArgumentFlag

Since: 1.4.0

A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

Example

class Foo {
    public function bar($flag = true) {
    }
}

Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

There are no issues that match your filters.

Category
Status