Method callbackAction has 42 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function callbackAction(Request $request): RedirectResponse
{
try {
$oauthToken = null;
if ($this->has('stingus_jira.oauth_token_manager')) {Method connectAction has 34 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function connectAction(Request $request): RedirectResponse
{
$tokenId = $request->query->get('tokenId');
$consumerKey = $request->query->get('consumerKey');
$baseUrl = $request->query->get('baseUrl');Function callbackAction has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring. Open
public function callbackAction(Request $request): RedirectResponse
{
try {
$oauthToken = null;
if ($this->has('stingus_jira.oauth_token_manager')) {- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function connectAction has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring. Open
public function connectAction(Request $request): RedirectResponse
{
$tokenId = $request->query->get('tokenId');
$consumerKey = $request->query->get('consumerKey');
$baseUrl = $request->query->get('baseUrl');- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
The method connectAction uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
} else {
$this->addFlash(
'error',
$this->get('translator')->trans('jira.errors.general', [], 'StingusJiraBundle')
);- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}Source https://phpmd.org/rules/cleancode.html#elseexpression
Avoid assigning values to variables in if clauses and the like (line '82', column '30'). Open
public function callbackAction(Request $request): RedirectResponse
{
try {
$oauthToken = null;
if ($this->has('stingus_jira.oauth_token_manager')) {- Read upRead up
- Exclude checks
IfStatementAssignment
Since: 2.7.0
Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.
Example
class Foo
{
public function bar($flag)
{
if ($foo = 'bar') { // possible typo
// ...
}
if ($baz = 0) { // always false
// ...
}
}
}Source http://phpmd.org/rules/cleancode.html#ifstatementassignment
Avoid assigning values to variables in if clauses and the like (line '33', column '22'). Open
public function connectAction(Request $request): RedirectResponse
{
$tokenId = $request->query->get('tokenId');
$consumerKey = $request->query->get('consumerKey');
$baseUrl = $request->query->get('baseUrl');- Read upRead up
- Exclude checks
IfStatementAssignment
Since: 2.7.0
Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.
Example
class Foo
{
public function bar($flag)
{
if ($foo = 'bar') { // possible typo
// ...
}
if ($baz = 0) { // always false
// ...
}
}
}Source http://phpmd.org/rules/cleancode.html#ifstatementassignment
The method callbackAction uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
} else {
$this->addFlash(
'error',
$this->get('translator')->trans('jira.errors.general', [], 'StingusJiraBundle')
);- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}